[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#26). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 26: Build Started http://104.196.14.100/job/kudu-gerrit/3184/ -- To view, visit http://gerrit.c

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3185/ -- To view, visit http://gerrit.

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#8). Change subject: Fix kudu-ts-cli crash when there is no data in tablet ..

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 8: (9 comments) TFTR again Todd, please see updated patch and responses inline. http://gerrit.

[kudu-CR] docs: update installation with new OS support

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4128 To unsubscribe, visit http://

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-09-01 Thread Dan Burkert (Code Review)
Hello Matthew Jacobs, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4173 to look at the new patch set (#3). Change subject: [java-client] Add ScanToken.stringifySerializedToken

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3186/ -- To view, visit http://gerrit.c

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 3: Turns out adding/dropping a checked exception does *not* break binary compat in Java, and sin

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-09-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4184 To uns

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4206 Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. KUDU-1113 pushed predicates not displaying on scans web p

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3187/ -- To view, visit http://

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4184/1/src/kudu/consensus/con

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4184/1/src/kudu/consensus/con

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4134/8/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#9). Change subject: Fix kudu-ts-cli crash when there is no data in tablet ..

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3188/ -- To view, visit http://gerrit.

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4173 To unsubscribe, visit ht

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. [java-client] Add ScanToken.stringifySerializedToken stringifySerializedToken takes a serialized s

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4206/1/src/kudu/tserver/tablet_servic

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 26: Code-Review+1 couple spelling/phrasing nits, but code LGTM! -- To view, visit http://gerrit.

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 26: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3952/26/src/kudu/client/client

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 26: Woops, I meant that to be a +1, definitely want to give Adar and others a chance to weigh in.

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/9/src/kudu/tools/kudu-ts-cli-test.cc Fi

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2//COMMIT_MSG Commit Message: Does it make sense

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-09-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: add --checksum_scan_concurrency to optional flags .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4183 To unsubscribe, visit

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (97 comments) http://gerrit.cloudera.org:8080/#/c/3990/3//COMMIT_MSG Commit Message: Line 16: https://github.com/a

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4164/2//COMMIT_MSG Commit Message: Line 6: line width

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 26: (2 comments) Thank you for the review! Will send an updated patch in a moment. http://ger

[kudu-CR] tracing: gzip the trace JSON ajax response

2016-09-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4154 To unsubscribe, visit http

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 27: Build Started http://104.196.14.100/job/kudu-gerrit/3189/ -- To view, visit http://gerrit.c

[kudu-CR] transaction tracker: back-off when logging in-flight transactions

2016-09-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: transaction_tracker: back-off when logging in-flight transactions .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4159/1/sr

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#27). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ...

[kudu-CR] tracing: gzip the trace JSON ajax response

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tracing: gzip the trace JSON ajax response .. tracing: gzip the trace JSON ajax response This enables gzipping of the actual trace which is sent back over

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ksck: add --checksum_scan_concurrency to optional flags .. ksck: add --checksum_scan_concurrency to optional flags Change-Id: Iaaa76215e0c30860eebd99db054

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4134/9/src/kudu/tools/kudu-ts-cli-test.cc Fi

[kudu-CR] transaction tracker: back-off when logging in-flight transactions

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: transaction_tracker: back-off when logging in-flight transactions .. transaction_tracker: back-off when logging in-flight transactions On a test cluster

[kudu-CR] tablet peer: clean up TabletStatusListener interface

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tablet_peer: clean up TabletStatusListener interface .. tablet_peer: clean up TabletStatusListener interface This class duplicated a lot of TabletPeer info

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus_que

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, vis

[kudu-CR] ts tablet manager: set status message after failed tablet copy

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ts_tablet_manager: set status message after failed tablet copy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4194 To unsubscribe,

[kudu-CR] tablet peer: clean up TabletStatusListener interface

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit htt

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 9: (6 comments) Ugh, I forgot to publish the comments I had last night. I think Todd ended up s

[kudu-CR] tool: port log-dump

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4167/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc:

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/4133/5//COMMIT_MSG Commit Message: Line 45: The

[kudu-CR] tracing: gzip the trace JSON ajax response

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/server/tracing-path-handlers.cc File

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/kudu-admin-test.cc File src/kudu/too

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3190/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-01 Thread Adar Dembo (Code Review)
Hello Dinesh Bhat, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4180 to look at the new patch set (#4). Change subject: tool: port kudu-admin to 'kudu cluster' .

[kudu-CR] ts tablet manager: set status message after failed tablet copy

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: ts_tablet_manager: set status message after failed tablet copy .. ts_tablet_manager: set status message after failed tablet copy I noticed in a test cluste

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 27: (9 comments) Almost there. http://gerrit.cloudera.org:8080/#/c/3952/27/src/kudu/client/client

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/3191/ -- To view, visit http://gerrit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#10). Change subject: Fix kudu-ts-cli crash when there is no data in tablet .

[kudu-CR] cache: dynamically determine the number of cache shards

2016-09-01 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4292 to review the following change. Change subject: cache: dynamically determine the number of cache shards .. cac

[kudu-CR] cache: dynamically determine the number of cache shards

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: cache: dynamically determine the number of cache shards .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3192/ -- To view, visit http://gerri

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: (13 comments) TFTR folks, updated the diffs after a round of testing again. This addresses

[kudu-CR] tracing: gzip the trace JSON ajax response

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/server/tracing-path-handlers.cc File s

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/10/src/kudu/tools/kudu-ts-cli-test.cc F

[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d

2016-09-01 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4293 to review the following change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d

[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3193/ -- To view, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2//COMMIT_MSG Commit Message: > Does it make sense

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 27: (9 comments) Will send a new version in a moment. http://gerrit.cloudera.org:8080/#/c/3952

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 28: Build Started http://104.196.14.100/job/kudu-gerrit/3194/ -- To view, visit http://gerrit.c

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#28). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ...

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 28: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit htt

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3196/ -- To vi

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4295 to review the following change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister ..

[kudu-CR] maintenance manager: simplify test

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: maintenance_manager: simplify test .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3195/ -- To view, visit http://gerrit.cloudera.org:8080/4

[kudu-CR] maintenance manager: simplify test

2016-09-01 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4294 to review the following change. Change subject: maintenance_manager: simplify test .. maintenance_manager: simplify tes

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3197/ -- To view,

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first

2016-09-01 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4296 to review the following change. Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first ..

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4206/1/src/kudu/tserver/tablet_servic

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 1: should also note this fixes KUDU-1513 in the commit message -- To view, visi

[kudu-CR] maintenance manager: simplify test

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: maintenance_manager: simplify test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4294 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4295/1/src/kudu/util

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4296 To u

[kudu-CR] tserver: sort /tablets list by table name first

2016-09-01 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4297 to review the following change. Change subject: tserver: sort /tablets list by table name first .. tserv

[kudu-CR] tserver: sort /tablets list by table name first

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tserver: sort /tablets list by table name first .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3198/ -- To view, visit http://gerrit.cloude

[kudu-CR] tserver: sort /tablets list by table name first

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tserver: sort /tablets list by table name first .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4297 To unsubscribe, visit http://g

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4295/1/src/kudu/uti

[kudu-CR] tserver: sort /tablets list by table name first

2016-09-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: tserver: sort /tablets list by table name first .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4297 To unsubscribe, visit http:

[kudu-CR] docs: update installation with new OS support

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4128 To unsubscribe, visit http://ge

[kudu-CR] docs: update installation with new OS support

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: docs: update installation with new OS support .. docs: update installation with new OS support At the time of writing, a couple things are broken: 1. The

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4295/1/src/kudu/util

[kudu-CR] maintenance manager: simplify test

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: maintenance_manager: simplify test .. maintenance_manager: simplify test This simplifies maintenance_manager-test a bit to avoid a condition variable, and

[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3199/ -- To v

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/3990/7/src/kudu/cfile/binary_prefix_block.h File src/kudu/cfile/bi

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_plain_block.h File src/kudu/cfile/binar

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4295 to look at the new patch set (#2). Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister ...

[kudu-CR] tserver: sort /tablets list by table name first

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tserver: sort /tablets list by table name first .. tserver: sort /tablets list by table name first I noticed when I'm looking at /tablets I usually am mos

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3200/ -- To vi

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3974/5/src/kudu/integration-tests/mini_c

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-01 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3201/ -- To view, visit http://ger

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-01 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3974 to look at the new patch set (#6). Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Cre

[kudu-CR] cache: dynamically determine the number of cache shards

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cache: dynamically determine the number of cache shards .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4292/1/src/kudu/util/cache.cc

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3974/6/src/kudu/integration-tests/exter

[kudu-CR] KUDU-1495. Maintenance manager should not schedule new ops during unregister

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1495. Maintenance manager should not schedule new ops during unregister .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4295

[kudu-CR] cache: dynamically determine the number of cache shards

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: cache: dynamically determine the number of cache shards .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4292/1/src/kudu/util/cache.cc File src/kud

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-09-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for the Kudu

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/3974/6/src/kudu/integration-tests/mini_c

  1   2   >