[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-01-09 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5176 to look at the new patch set (#13). Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates ..

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-01-09 Thread Haijie Hong (Code Review)
Haijie Hong has posted comments on this change. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 13: (7 comments) > (9 comments) > > Sorry this took so long, was out on holiday break

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5619/3//COMMIT_MSG Commit Message: PS3, Line

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (4 comments) I forgot to press send on this friday. Thinking out loud, I am trying to see what's the real adv

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: > Intuitively restart means "stop then start" for me, and as s

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.c

[kudu-CR] KUDU-1821. Noisy warning from catalog manager

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1821. Noisy warning from catalog manager .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5637/2/src/kudu/master/catalog_manager.cc File src/k

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5176 To unsubscribe,

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates .. KUDU-1643 Prune hash partitions based on IN-list predicates I change optional to vector so

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.c

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#16). Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen te

[kudu-CR] [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section .. [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc secti

[kudu-CR](branch-1.2.x) [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5642 Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section .. [doc] KUDU-1810 Missing part of text in ku

[kudu-CR] [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR](branch-1.2.x) [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR](branch-1.2.x) [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section .. [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc secti

[kudu-CR] Fix some minor compilation issues

2017-01-09 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5643 Change subject: Fix some minor compilation issues .. Fix some minor compilation issues A few small issues manifested themselves while c

[kudu-CR] Fix some minor compilation issues

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix some minor compilation issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5643 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] log block manager: update list of buggy el6 versions

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log_block_manager: update list of buggy el6 versions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5632 To unsubscribe, visit htt

[kudu-CR] log block manager: update list of buggy el6 versions

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: log_block_manager: update list of buggy el6 versions .. log_block_manager: update list of buggy el6 versions The bug fix for ext4 extents tree corruption h

[kudu-CR] thirdparty: upgrade to llvm 3.9.1

2017-01-09 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5650 to review the following change. Change subject: thirdparty: upgrade to llvm 3.9.1 .. thirdparty: upgrade

[kudu-CR] thirdparty: upgrade to llvm 3.9.1

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: upgrade to llvm 3.9.1 .. Patch Set 1: It'd help if I had uploaded the new LLVM tarball to the S3 bucket... -- To view, visit http://gerrit.cloudera.or

[kudu-CR] Fix some minor compilation issues

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix some minor compilation issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5643 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: Personally I think this patch is fine as-is, because the partic

[kudu-CR] Fix some minor compilation issues

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix some minor compilation issues .. Fix some minor compilation issues A few small issues manifested themselves while compiling Impala with Kudu's RPC and

[kudu-CR] Add some path / env related helper functions

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5618/3/src/kudu/util/env_posix.cc File src/kudu/util/

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Add some path / env related helper functions

2017-01-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 3: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/5618/3/src/kudu/util/env_posix.cc File s

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: > Personally I think this patch is fine as-is, because the part

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: Adar, I agree with everything you said. The semantics you descr

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/5619/3//COMMIT_MSG Commit Message: PS3, Line 13: This chang

[kudu-CR] KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-01-09 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5598 to look at the new patch set (#2). Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart ...

[kudu-CR] KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-01-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart .. Patch Set 2: > > Personally I think this patch is fine as-is, because the >

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5604 To unsubscribe,

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Initial draft of release notes and doc updates for 1.2 .. Initial draft of release notes and doc updates for 1.2 Change-Id: I08326171dd2bf6097a7594

[kudu-CR] [doc] update on external consistency mode availability

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: [doc] update on external consistency mode availability .. Abandoned incorporating this into https://gerrit.cloudera.org/#/c/5605/1 -- To view, visit http://gerrit.clouder

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (32 comments) http://gerrit.cloudera.org:8080/#/c/5620/3//COMMIT_MSG Commit Message: Line 7: Add Google Breakp

[kudu-CR] KUDU-1733. Update consistency semantics doc

2017-01-09 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Jean-Daniel Cryans, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5605 to look at the new patch set (#2). Change subject: KUDU-1733. Update consistency semantics doc .

[kudu-CR] thirdparty: upgrade to llvm 3.9.1

2017-01-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: upgrade to llvm 3.9.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5650 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] thirdparty: upgrade to llvm 3.9.1

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: thirdparty: upgrade to llvm 3.9.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5650 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] thirdparty: upgrade to llvm 3.9.1

2017-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: upgrade to llvm 3.9.1 .. thirdparty: upgrade to llvm 3.9.1 Rarely, some builds break due to this bug [1], which is fixed in LLVM 3.9.1. 1. htt

[kudu-CR] GetLastOpId() fails to serialize response when using LocalConsensus

2017-01-09 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: GetLastOpId() fails to serialize response when using LocalConsensus .. Abandoned we removed localconsensus -- To view, visit http://gerrit.cloudera.org:8080/994 To unsubs

[kudu-CR] KUDU-1733. Update consistency semantics doc

2017-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1733. Update consistency semantics doc .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5605/2/docs/transaction_semantics.adoc File docs/tr

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#17). Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen te

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5624 to look at the new patch set (#5). Change subject: [kudu-jepsen] added Jenkins script .. [kudu-jepsen] added Jenkin

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 16: (20 comments) http://gerrit.cloudera.org:8080/#/c/5492/16/java/kudu-jepsen/.gitignore File java/kudu-jepsen/.giti

[kudu-CR] KUDU-1733. Update consistency semantics doc

2017-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1733. Update consistency semantics doc .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5605/2/docs/transaction_semantics.adoc File docs/tran

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5464/3/docs/transaction_semantics.adoc Fil

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-09 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5464 to look at the new patch set (#4). Change subject: docs: KUDU-1767. Document possible client op reordering ..

[kudu-CR] KUDU-1733. Update consistency semantics doc

2017-01-09 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Jean-Daniel Cryans, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5605 to look at the new patch set (#3). Change subject: KUDU-1733. Update consistency semantics doc .

[kudu-CR] KUDU-1821. Noisy warning from catalog manager

2017-01-09 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1821. Noisy warning from catalog manager .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5637/2/src/kudu/master/catalog_manager.cc File src/kudu/m