[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-18 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > I'm pretty sure we don't want this limitation, see > https://gi

[kudu-CR] docs: add notes for multi master migration

2017-01-18 Thread zhen.zhang (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5728 to look at the new patch set (#2). Change subject: docs: add notes for multi master migration .. docs: add notes fo

[kudu-CR] docs: add notes for multi master migration

2017-01-18 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 1: (2 comments) I just installed "Asciidoctor.js Live Preview", it's very useful, thanks :) http://gerrit.

[kudu-CR] [security] Kudu certificate signing service

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5674 to look at the new patch set (#3). Change subject: [security] Kudu certificate signing service .. [security] Kudu c

[kudu-CR] [security] groundwork for cert signing service

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5671 to look at the new patch set (#4). Change subject: [security] groundwork for cert signing service .. [security] gro

[kudu-CR] [security] interface for certificate signing service

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5673 to look at the new patch set (#3). Change subject: [security] interface for certificate signing service .. [securit

[kudu-CR] [TLS cert management] security service units tests

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [TLS cert management] security service units tests .. Abandoned Abandoned: the unit tests are merged into item 5674. -- To view, visit http://gerrit.cloudera.org:8080/5

[kudu-CR] [TLS cert management] TLS cert generation unit tests

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [TLS cert management] TLS cert generation unit tests .. Abandoned Abandoning -- the unit tests are added into 5671 item. -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5735/4/src/kudu/cfile/cfile-test.cc

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5737/1/src/kudu/tablet/deltafile.cc File src/kudu/ta

[kudu-CR] [util] fixed env-test on OS X

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X Prior to the fix, in some cases the uninitialized portion of 64-bit variable was non-zero and since

[kudu-CR] [util] fixed env-test on OS X 10.11.5

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5738 Change subject: [util] fixed env-test on OS X 10.11.5 .. [util] fixed env-test on OS X 10.11.5 Prior to the fix, on some OS X 10.11.5 sy

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5737 Change subject: KUDU-1836. Enable compression of DeltaFiles .. KUDU-1836. Enable compression of DeltaFiles This adds a new experimental fl

[kudu-CR] WIP: KUDU-1835 (part 2): enable WAL compression

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#6). Change subject: WIP: KUDU-1835 (part 2): enable WAL compression .. WIP: KUDU-183

[kudu-CR] WIP: KUDU-1835 (part 2): enable WAL compression

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#5). Change subject: WIP: KUDU-1835 (part 2): enable WAL compression .. WIP: KUDU-183

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5735 to look at the new patch set (#4). Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. KU

[kudu-CR] WIP: KUDU-1835 (part 2): enable WAL compression

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#4). Change subject: WIP: KUDU-1835 (part 2): enable WAL compression .. WIP: KUDU-183

[kudu-CR] [TLS cert management] security service implementation

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5674 to look at the new patch set (#2). Change subject: [TLS cert management] security service implementation .. [TLS ce

[kudu-CR] [TLS cert management] added protobuf interface

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5673 to look at the new patch set (#2). Change subject: [TLS cert management] added protobuf interface .. [TLS cert mana

[kudu-CR] [TLS cert management] TLS cert generation unit tests

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5672 to look at the new patch set (#3). Change subject: [TLS cert management] TLS cert generation unit tests .. [TLS cer

[kudu-CR] [TLS cert management] security service units tests

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5675 to look at the new patch set (#2). Change subject: [TLS cert management] security service units tests .. [TLS cert

[kudu-CR] [TLS certs management] initial commit

2017-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5671 to look at the new patch set (#3). Change subject: [TLS certs management] initial commit .. [TLS certs management]

[kudu-CR] [TLS cert management] security service units tests

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [TLS cert management] security service units tests .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5675/1/src/kudu/security/test/security_servi

[kudu-CR] [TLS cert management] added protobuf interface

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [TLS cert management] added protobuf interface .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5673/1/src/kudu/security/security.proto File src

[kudu-CR] [TLS cert management] security service implementation

2017-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [TLS cert management] security service implementation .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/5674/1/src/kudu/security/security_service

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5735 to look at the new patch set (#3). Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. KU

[kudu-CR] WIP: KUDU-1835 (part 2): enable WAL compression

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#3). Change subject: WIP: KUDU-1835 (part 2): enable WAL compression .. WIP: KUDU-183

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5735 to look at the new patch set (#2). Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. KU

[kudu-CR] WIP: KUDU-1835 (part 2): enable WAL compression

2017-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5736 Change subject: WIP: KUDU-1835 (part 2): enable WAL compression .. WIP: KUDU-1835 (part 2): enable WAL compression Change-Id: I0fc790ddc72

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5735 Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. KUDU-1835 (part 1). Move compression codec classes to util T

[kudu-CR] binary plain block: fix an incorrect vector.reserve()

2017-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: binary_plain_block: fix an incorrect vector.reserve() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5734 To unsubscribe, visit ht

[kudu-CR] binary plain block: fix an incorrect vector.reserve()

2017-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: binary_plain_block: fix an incorrect vector.reserve() .. binary_plain_block: fix an incorrect vector.reserve() I noticed the following surprising stack tra

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc Fi

[kudu-CR] binary plain block: fix an incorrect vector.reserve()

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5734 to review the following change. Change subject: binary_plain_block: fix an incorrect vector.reserve() .. binary_plain_b

[kudu-CR] docs: add notes for multi master migration

2017-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 1: (5 comments) Thanks for the patch! BTW, it's helpful to view the generated documentation as well as the

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Ambreen Kazi, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5733 to review the following change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Update Impala d

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2017-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1422 [java client] modifiable error collector capacity .. Patch Set 4: I'm a fan of offering both options. I think direct users will normally want to

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2017-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1422 [java client] modifiable error collector capacity .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5291/2/java/kudu-client/src/main/java/o

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5439/2/src/kudu/common/column_predicat

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 2: (17 comments) http://gerrit.cloudera.org:8080/#/c/5439/2/java/kudu-client/src/main/jav

[kudu-CR](gh-pages) Update site for 1.2.0 release

2017-01-18 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5730 to review the following change. Change subject: Update site for 1.2.0 release .. Update site for 1.2.0 release

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

2017-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5439/2/java/kudu-client/src/main/java/

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-18 Thread eric-maynard (Code Review)
eric-maynard has posted comments on this change. Change subject: KUDU-1673 [java client] more informative kudu-spark write error .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/5725/5//COMMIT_MSG Commit Messa

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-18 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5725 to look at the new patch set (#7). Change subject: KUDU-1673 [java client] more informative kudu-spark write error .

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1673 [java client] more informative kudu-spark write error .. Patch Set 6: eric-maynard: oops! When writing that review I mistakenly thought Todd had writte

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1673 [java client] more informative kudu-spark write error .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5725/6//COMMIT_MSG Commit Message

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we don

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-18 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5725 to look at the new patch set (#6). Change subject: KUDU-1673 [java client] more informative kudu-spark write error .

[kudu-CR] KUDU-1422 [java client] modifiable error collector capacity

2017-01-18 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5291 to look at the new patch set (#4). Change subject: KUDU-1422 [java client] modifiable error collector capacity .. K