[kudu-CR] KUDU-861 Support changing column defaults and storage attributes

Dan Burkert has posted comments on this change. Change subject: KUDU-861 Support changing column defaults and storage attributes .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6725 To unsubscri

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

Dan Burkert has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6734/3/src/kudu/security/cert.cc File src/kudu/

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

Dan Burkert has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 10: Code-Review+1 This is looking good to me. I'll leave it to JD to give a +2. -- To view, visit ht

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 10: Code-Review+2 Good job on the new test. -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. KUDU-579 [java_client] Scanner fault tolerance This patch adds java client support to restart sca

[kudu-CR] mapreduce: add support for fault tolerant scanner

Jean-Daniel Cryans has posted comments on this change. Change subject: mapreduce: add support for fault tolerant scanner .. Patch Set 2: The test failure is related to the fault tolerant scanner patch: 01:09:34.954 [INFO - kudu

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6640/11/src/kudu/integration-tests/security-unknown-ts

[kudu-CR] env: Always read fully when reading files

Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6758 Change subject: env: Always read fully when reading files .. env: Always read fully when reading files In KUDU-9(see ) env_util::ReadFully

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6640/11/src/kudu/integration-tests/security-unknown-

[kudu-CR] env: Always read fully when reading files

Grant Henke has uploaded a new patch set (#2). Change subject: env: Always read fully when reading files .. env: Always read fully when reading files In KUDU-9(see ) env_util::ReadFully was added to ensure short reads were retri

[kudu-CR] env: Always read fully when reading files

Adar Dembo has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 1: (3 comments) Two high level comments: - In many places, env_util.h was only included for ReadFully(). Whe

[kudu-CR] env: Always read fully when reading files

Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 2: > In many places, env_util.h was only included for ReadFully(). Wherever you're > replacing ReadFully()

[kudu-CR] env: Always read fully when reading files

Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6758/1/src/kudu/util/env_posix.cc File src/kudu/util/en

[kudu-CR] env: Always read fully when reading files

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6758 to look at the new patch set (#3). Change subject: env: Always read fully when reading files .. env: Always read fu

[kudu-CR] env: Always read fully when reading files

Adar Dembo has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/6758/3//COMMIT_MSG Commit Message: PS3, Line 9: KUDU-9(

[kudu-CR] subprocess: add KillAndWait() and allow customization of exit signal

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6741 to look at the new patch set (#2). Change subject: subprocess: add KillAndWait() and allow customization of exit signal ...

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6715 to look at the new patch set (#4). Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. K

[kudu-CR] KUDU-1970: node density integration test

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6662 to look at the new patch set (#2). Change subject: KUDU-1970: node density integration test .. KUDU-1970: node dens

[kudu-CR] external mini cluster: spawn perf record for each daemon during Start()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6742 to look at the new patch set (#2). Change subject: external mini cluster: spawn perf record for each daemon during Start()

[kudu-CR] KUDU-1970: node density integration test

Adar Dembo has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6662/1//COMMIT_MSG Commit Message: Line 20: WIP because a

[kudu-CR] env: Always read fully when reading files

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6758 to look at the new patch set (#4). Change subject: env: Always read fully when reading files .. env: Always read fu

[kudu-CR] env: Always read fully when reading files

Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/6758/3//COMMIT_MSG Commit Message: Line 9: In KUDU-9(s

[kudu-CR] env: Always read fully when reading files

Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 3: As talked about via chat, I will follow up with a separate patch to simplify the Read() API. -- To vie

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6734 to look at the new patch set (#4). Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. KUDU-1981 K

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

Alexey Serbin has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6734/3/src/kudu/security/cert.cc File src/kud

[kudu-CR] env: Always read fully when reading files

Adar Dembo has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6758/4/src/kudu/util/env_posix.cc File src/kudu/util/env_

[kudu-CR] env: Always read fully when reading files

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6758 to look at the new patch set (#5). Change subject: env: Always read fully when reading files .. env: Always read fu

[kudu-CR] env: Always read fully when reading files

Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6758/4/src/kudu/util/env_posix.cc File src/kudu/util/env

[kudu-CR] env: Always read fully when reading files

Adar Dembo has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6758 To unsubscribe, visit http://gerrit.

[kudu-CR] env: Always read fully when reading files

Todd Lipcon has posted comments on this change. Change subject: env: Always read fully when reading files .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6758 To unsubscribe, visit http://gerrit

[kudu-CR] external mini cluster: pass options by value and move where appropriate

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6760 to review the following change. Change subject: external mini cluster: pass options by value and move where appropriate ..

[kudu-CR] WIP: annotations to make TSAN aware of RWCLock semantics

Adar Dembo has abandoned this change. Change subject: WIP: annotations to make TSAN aware of RWCLock semantics .. Abandoned It's been a year since I published this change, and since I wasn't able to get it to work, no need to

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

Todd Lipcon has posted comments on this change. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6715 To unsubscribe, v

[kudu-CR] log block manager: more container accounting

Todd Lipcon has posted comments on this change. Change subject: log block manager: more container accounting .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6716 To unsubscribe, visit http://ger

[kudu-CR] log block manager: detect and repair unpunched holes

Todd Lipcon has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6717/4/src/kudu/fs/log_block_manager-test-ut

[kudu-CR] subprocess: add KillAndWait() and allow customization of exit signal

Todd Lipcon has posted comments on this change. Change subject: subprocess: add KillAndWait() and allow customization of exit signal .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6741/1/src/kudu/integration-

[kudu-CR] [c++-client] clear non-covered entries from meta cache on table open

Dan Burkert has submitted this change and it was merged. Change subject: [c++-client] clear non-covered entries from meta cache on table open .. [c++-client] clear non-covered entries from meta cache on table open Clearing non

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 11: Also, could you update the known limitations section here: https://github.com/apache/kudu/blob/master/

[kudu-CR] log block manager: detect and repair unpunched holes

Adar Dembo has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6717/4/src/kudu/fs/log_block_manager-test-uti

[kudu-CR] external mini cluster: pass options by value and move where appropriate

Dan Burkert has posted comments on this change. Change subject: external mini cluster: pass options by value and move where appropriate .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6760 To u

[kudu-CR] external mini cluster: pass options by value and move where appropriate

Adar Dembo has submitted this change and it was merged. Change subject: external mini cluster: pass options by value and move where appropriate .. external mini cluster: pass options by value and move where appropriate I also

[kudu-CR] KUDU-1970: node density integration test

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6662 to look at the new patch set (#4). Change subject: KUDU-1970: node density integration test .. KUDU-1970: node dens

[kudu-CR] log block manager: detect and repair unpunched holes

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6717 to look at the new patch set (#5). Change subject: log block manager: detect and repair unpunched holes .. log bloc

[kudu-CR] tablet copy-itest: Reduce flakiness

Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6764 Change subject: tablet_copy-itest: Reduce flakiness .. tablet_copy-itest: Reduce flakiness This patch reduces the flakiness under heavy CPU

[kudu-CR] external mini cluster: spawn perf record for each daemon during Start()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6742 to look at the new patch set (#3). Change subject: external mini cluster: spawn perf record for each daemon during Start()

[kudu-CR] tablet copy-itest: Reduce flakiness

Adar Dembo has posted comments on this change. Change subject: tablet_copy-itest: Reduce flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6764 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] KUDU-1970: node density integration test

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6662 to look at the new patch set (#5). Change subject: KUDU-1970: node density integration test .. KUDU-1970: node dens

[kudu-CR] KUDU-1970: node density integration test

Dan Burkert has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6662/4//COMMIT_MSG Commit Message: Line 11: lots of data

[kudu-CR] KUDU-1970: node density integration test

Dan Burkert has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6662 To unsubscribe, visit http://gerrit.

[kudu-CR] subprocess: add KillAndWait() and allow customization of exit signal

Adar Dembo has posted comments on this change. Change subject: subprocess: add KillAndWait() and allow customization of exit signal .. Patch Set 3: Verified+1 Unrelated failure (minidump file left behind) in a Java test, I thi

[kudu-CR] KUDU-1970: node density integration test

Adar Dembo has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6662/4//COMMIT_MSG Commit Message: Line 11: lots of data

[kudu-CR] KUDU-1970: node density integration test

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6662 to look at the new patch set (#6). Change subject: KUDU-1970: node density integration test .. KUDU-19

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6640 to look at the new patch set (#12). Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. [rpc] handling ER

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6715 To unsubs

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. KUDU-1978: avoid corruption when deleting misaligned blocks The gist of the problem: when pu

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 12: > Also, could you update the known limitations section here: > https://github.com/apache/kudu/blob/m

[kudu-CR] log block manager: more container accounting

David Ribeiro Alves has posted comments on this change. Change subject: log block manager: more container accounting .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6716 To unsubscribe, visit ht

[kudu-CR] log block manager: more container accounting

Adar Dembo has submitted this change and it was merged. Change subject: log block manager: more container accounting .. log block manager: more container accounting This patch moves some stats accounting from the FsReport into

[kudu-CR] log block manager: detect and repair unpunched holes

David Ribeiro Alves has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 5: Adding Andrew to the review since this touches stuff he might also be touching -- To

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 12: woops, you're right. Meant to leave that comment on the reacquire patch. -- To view, visit http://ge

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6640 to look at the new patch set (#13). Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. [rpc] handling ER

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

Dan Burkert has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6734 To unsubscribe, visit http:

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 13: > woops, you're right. Meant to leave that comment on the reacquire > patch. Thanks for confirmati

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. KUDU-1981 Kudu should run at hosts len(FQDN) > 64 This is a fix for KUDU-1981: with security enable

[kudu-CR] log block manager: detect and repair unpunched holes

David Ribeiro Alves has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/6717/5/src/kudu/fs/log_block_manage

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

David Ribeiro Alves has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6583 To unsubscr

[kudu-CR] subprocess: add KillAndWait() and allow customization of exit signal

David Ribeiro Alves has posted comments on this change. Change subject: subprocess: add KillAndWait() and allow customization of exit signal .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6741

[kudu-CR] subprocess: add KillAndWait() and allow customization of exit signal

Adar Dembo has submitted this change and it was merged. Change subject: subprocess: add KillAndWait() and allow customization of exit signal .. subprocess: add KillAndWait() and allow customization of exit signal This patch do

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

Adar Dembo has submitted this change and it was merged. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. env: add RWFile::GetExtentMap for analyzing file extents This patch introduces a method to get

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/6640/12/src/kudu/integration-tests/security-unknown-ts

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6640/12/src/kudu/integration-tests/security-unknown-

[kudu-CR] log block manager: detect and repair unpunched holes

Adar Dembo has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/6717/5/src/kudu/fs/log_block_manager-test-ut

[kudu-CR] log block manager: detect and repair unpunched holes

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6717 to look at the new patch set (#6). Change subject: log block manager: detect and repair unpunched holes .. log bloc

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 13: Code-Review+2 hmm ok. You may want to do a disttest loop to make sure it's not flaky, if you haven't

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6640/12/src/kudu/integration-tests/security-unknown-

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 12: > hmm ok. You may want to do a disttest loop to make sure it's not > flaky, if you haven't already.

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 12: > > hmm ok. You may want to do a disttest loop to make sure it's not > > flaky, if you haven't alre

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Alexey Serbin has submitted this change and it was merged. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. [rpc] handling ERROR_UNAVAILABLE RPC error This patch adds handling of the newly introduced ERROR_UNAVAILA

[kudu-CR] [c++ client] re-acquire authn token if expired

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6648 to look at the new patch set (#6). Change subject: [c++ client] re-acquire authn token if expired .. [c++ client] r

[kudu-CR] [c++ client] re-acquire authn token if expired

Alexey Serbin has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired .. Patch Set 5: (15 comments) http://gerrit.cloudera.org:8080/#/c/6648/5/src/kudu/client/client-internal.cc File

[kudu-CR] [c++ client] re-acquire authn token if expired

Alexey Serbin has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6648/5/src/kudu/rpc/connection.cc File src/kudu/r

[kudu-CR] [c++ client] re-acquire authn token if expired

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6648 to look at the new patch set (#7). Change subject: [c++ client] re-acquire authn token if expired .. [c++ client] r