[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6809/1/src/kudu/integration-tes

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-05 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6809 to look at the new patch set (#2). Change subject: Refactor ConsensusStatePB to hold committed and pending configs .

[kudu-CR] WIP [java] re-acquire authn token if expired

2017-05-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6816 Change subject: WIP [java] re-acquire authn token if expired .. WIP [java] re-acquire authn token if expired This patch introduces autom

[kudu-CR] maintenance manager: schedule work immediately when threads are free

2017-05-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: maintenance_manager: schedule work immediately when threads are free .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6815/1/src/kudu

[kudu-CR] cert: add check for pending SSL errors in cert-related code

2017-05-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: cert: add check for pending SSL errors in cert-related code .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6814/1/src/kudu/security/cert.cc Fi

[kudu-CR] KUDU-1970: node density integration test

2017-05-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1970: node density integration test .. KUDU-1970: node density integration test This patch introduces a new itest that simulates a storage-dense Kudu

[kudu-CR] maintenance manager: schedule work immediately when threads are free

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6815 Change subject: maintenance_manager: schedule work immediately when threads are free .. maintenance_manager: schedule work immediately whe

[kudu-CR] cert: add check for pending SSL errors in cert-related code

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6814 Change subject: cert: add check for pending SSL errors in cert-related code .. cert: add check for pending SSL errors in cert-related code

[kudu-CR] WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-05 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#15). Change subject: WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] KUDU-1970: node density integration test

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 11: Code-Review+2 Chatting about the naming situation on another channel Adar made the point that th

[kudu-CR] [rpc] use C++11 move semantics for selected methods

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] use C++11 move semantics for selected methods .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6766/3/src/kudu/rpc/connection.cc File src/kud

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-05 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6808 to look at the new patch set (#2). Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Fix flaky test Tes

[kudu-CR] WIP: tablet: skip over gaps in rowsets using key index instead of bloom

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: tablet: skip over gaps in rowsets using key index instead of bloom .. Patch Set 2: review? -- To view, visit http://gerrit.cloudera.org:8080/6484 T

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6808/1//COMMIT_MSG Commit Message: PS1, Line 9: This t

[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered

2017-05-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6534/1//COMMIT_MSG Commit

[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered

2017-05-05 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. KUDU-1991. master: Retry background tasks even if TS UUID not registered Befor

[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered

2017-05-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 4: Verified+1 Overriding Jenkins failure due to flaky test caused by KUDU-173

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-05 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6809 Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Refactor ConsensusStatePB to hold committed and pendin

[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered

2017-05-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6534/1//COM

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: spark: add support for fault tolerant scanner .. Patch Set 5: (2 comments) Would be nice to have a test of the new functionality (setting the fault tolerant opti

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6808/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered

2017-05-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6534/1//COMMIT_MSG Commit

[kudu-CR] KUDU-1991. master: Retry background tasks even if TS UUID not registered

2017-05-05 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6534 to look at the new patch set (#4). Change subject: KUDU-1991. master: Retry background tasks even if TS UUID not registered ...

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Fix bug in incorrect response rebuilding on tablet bootstrap This fixes the bug described

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5489 To unsubscribe,

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-05 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6808 to review the following change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Fix flaky test T

[kudu-CR] WIP: reduce contention on MemTracker::Release and Consume in block cache

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: reduce contention on MemTracker::Release and Consume in block cache .. Patch Set 1: think i'll end up rolling this into some other stuff -- To view, visit

[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [webui] Fix master reg formatting and add memory use percentage. .. [webui] Fix master reg formatting and add memory use percentage. This is a lit

[kudu-CR] WIP: reduce contention on MemTracker::Release and Consume in block cache

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: reduce contention on MemTracker::Release and Consume in block cache .. Patch Set 1: needs review? or will be rolled in to other patches? -- To view

[kudu-CR] [java client] - Add getter/setter for the last propagated timestamp to KuduClient

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: [java client] - Add getter/setter for the last propagated timestamp to KuduClient .. Abandoned this change was superceded by aserbin's changes -- To view, visit

[kudu-CR] [util] use emplace() instead of insert()

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] use emplace() instead of insert() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6807/1/src/kudu/gutil/map-util.h File src/kudu/gutil/map-

[kudu-CR] WIP: release WritableLogSegment buffers when log is idle

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: release WritableLogSegment buffers when log is idle .. Patch Set 2: (2 comments) yeah, it'd nice to quantify how much data we're wasting on this. ht

[kudu-CR] cache: add a benchmark

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: cache: add a benchmark .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc File src/kudu/util/cache-bench

[kudu-CR] KUDU-1970: node density integration test

2017-05-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 11: here's your precedent (unmerged) :) https://gerrit.cloudera.org/#/c/6696/1/src/kudu/util/cache-b

[kudu-CR] WIP Don't suicide on EIO

2017-05-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6773 to look at the new patch set (#3). Change subject: WIP Don't suicide on EIO .. WIP Don't suicide on EIO Rather tha

[kudu-CR] WIP Don't suicide on EIO

2017-05-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6773 to look at the new patch set (#2). Change subject: WIP Don't suicide on EIO .. WIP Don't suicide on EIO Rather tha

[kudu-CR] [util] use emplace() instead of insert()

2017-05-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] use emplace() instead of insert() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6807/1/src/kudu/gutil/map-util.h File src/kudu/gutil/ma

[kudu-CR] cfile set: avoid Status allocation for row not found

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: cfile_set: avoid Status allocation for row not found .. cfile_set: avoid Status allocation for row not found We expect Bloom Filter lookups to typically r

[kudu-CR] KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1949. Maintenance Manager should trigger flushes earlier .. KUDU-1949. Maintenance Manager should trigger flushes earlier This changes the maintenanc

[kudu-CR] [util] use emplace() instead of insert()

2017-05-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] use emplace() instead of insert() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6807/1/src/kudu/gutil/map-util.h File src/kudu/gutil/map-

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 17: (12 comments) http://gerrit.cloudera.org:8080/#/c/6636/17/src/kudu/fs/block_manager-test.cc File

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 14: (1 comment) Looks good, just two other things: 1. What was your conclusion re: bit flipping in the test?

[kudu-CR] WIP KUDU-1826 add propagated timestamp to sync client

2017-05-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: WIP KUDU-1826 add propagated timestamp to sync client .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6798/1/java/kudu-client/src/main/java/org/ap

[kudu-CR] WIP KUDU-1826 add propagated timestamp to sync client

2017-05-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6798 to look at the new patch set (#2). Change subject: WIP KUDU-1826 add propagated timestamp to sync client .. WIP KUD

[kudu-CR](branch-1.3.x) KUDU-1993: fixed validation of 'grouped' gflags

2017-05-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6806 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-1993: fixed validation of 'grouped' gflags

2017-05-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. KUDU-1993: fixed validation of 'grouped' gflags Added generic implementation for grouped gflags

[kudu-CR] WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-05 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#14). Change subject: WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-05 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#13). Change subject: WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6514/11/src/kudu/

[kudu-CR] WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-05 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#12). Change subject: WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] [util] use emplace() instead of insert()

2017-05-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] use emplace() instead of insert() .. Patch Set 1: Verified+1 Unrelated flake: ClientTest.TestFailedDnsResolution -- To view, visit http://gerrit.clouder