[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-25 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#2). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-25 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#9). Change subject: KUDU-2191: Metadata Upgrade Tool ..

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10217/1/src

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-25 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#8). Change subject: KUDU-2191: Metadata Upgrade Tool ..

[kudu-CR] [tools] ksck improvements [6/n]: Refactor printing

2018-04-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10151 to look at the new patch set (#9). Change subject: [tools] ksck improvements [6/n]: Refactor printing ...

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-25 Thread Hao Hao (Code Review)
Hao Hao has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Removed reviewer Alexey Serbin. -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/10075/6//COMMIT_MSG Commi

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-04-25 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#7). Change subject: KUDU-2191: Metadata Upgrade Tool ..

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-04-25 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10217 Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. KUDU-2191: HMS Metadata Consistency Check Tool This commit introduces a met

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10215 Change subject: [Java] Check in the Gradle wrapper properties .. [Java] Check in the Gradle wrapper properties We were downloading the pr

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew File

[kudu-CR](branch-1.4.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10191 To unsubscri

[kudu-CR](branch-1.5.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10190 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * F

[kudu-CR](branch-1.5.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10190 To unsubscri

[kudu-CR](branch-1.4.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10191 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * F

[kudu-CR](branch-1.4.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10191 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clouder

[kudu-CR](branch-1.5.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10190 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clouder

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. [java] Upgrade to Gradle 4.7 Our build is broken on Gradle 4.7. This patch fixes

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [java] Upgrade to Gradle 4.7 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10206 To unsubscribe, visit http://gerrit.

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10206 To unsu

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gra

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-25 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6597 to look at the new patch set (#4). Change subject: cache: reduce contention on MemTracker::Release and Consume .

[kudu-CR] cache: add a benchmark

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6696 ) Change subject: cache: add a benchmark .. cache: add a benchmark In some workloads, the LRU cache is now a substantial bottleneck

[kudu-CR] Fast path scanning blocks of deleted rows

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10213 ) Change subject: Fast path scanning blocks of deleted rows .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10213/1//CO

[kudu-CR] Fast path scanning blocks of deleted rows

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mostafa Mokhtar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10213 to review the following change. Change subject: Fast path scanning blocks of deleted rows .. Fast

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 1: The table looks correct now! I cannot do +2 for Kudu, thoug

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10206 To u

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 5: Code-Review+1 Looks fine, thanks -- To view, visit http://gerr

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gra

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4425/3/java/bu

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for jav

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew File

[kudu-CR] java: fix remainder of error-prone issues

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10202/1//COMMI

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew File

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10211 Change subject: Fix table formatting in full data dirs docs .. Fix table formatting in full data dirs docs Change-Id: I098c64c3241e5fc4

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9967/6/docs/administra

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 ) Change subject: [java] Upgrade to Gradle 4.7 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew File

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 3: (3 comments) As for error-prone vs spotbugs, I think they are l

[kudu-CR] java: fix remainder of error-prone issues

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10202/1//COMM

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-25 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6597 to look at the new patch set (#3). Change subject: cache: reduce contention on MemTracker::Release and Consume .

[kudu-CR] cache: add a benchmark

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6696 ) Change subject: cache: add a benchmark .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6696 To unsubscrib

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 2: A couple tests are failing because they are m

[kudu-CR] cache: switch to std::atomic

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10209 ) Change subject: cache: switch to std::atomic .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10209 To un

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-25 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6597 to look at the new patch set (#2). Change subject: cache: reduce contention on MemTracker::Release and Consume .

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 5: The table format needs to be fixed. It is rendering with 3 columns and

[kudu-CR] cache: switch to std::atomic

2018-04-25 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10209 to review the following change. Change subject: cache: switch to std::atomic .. cache: switch to std::atomic

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9967 To

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. [docs] Add docs on full data dirs Change-Id: If1081cab4c84789d29a0ccdccfd1

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9967

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9967 To

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9967/4/docs/administ

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9967/4/docs/administra

[kudu-CR] [java] Upgrade to Gradle 4.7

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10206 Change subject: [java] Upgrade to Gradle 4.7 .. [java] Upgrade to Gradle 4.7 Our build is broken on Gradle 4.7. This patch fixes that iss

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9967/4/docs/adminis

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9967 to look at the new patch set (#5). Change subject: [docs] Add docs on full data dirs

[kudu-CR] [tools] ksck improvements [6/n]: Refactor printing

2018-04-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10151 to look at the new patch set (#8). Change subject: [tools] ksck improvements [6/n]: Refactor printing ...

[kudu-CR] cache: add a benchmark

2018-04-25 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6696 to look at the new patch set (#2). Change subject: cache: add a benchmark ..

[kudu-CR] cache: add a benchmark

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6696 ) Change subject: cache: add a benchmark .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9967/4/docs/adminis

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10188 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clouder

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10188 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * F

[kudu-CR](branch-1.6.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10189 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * F

[kudu-CR] java: fix remainder of error-prone issues

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 ) Change subject: java: fix remainder of error-prone issues .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10202/1//COMMI

[kudu-CR] [docs] Add docs on full data dirs

2018-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9967 ) Change subject: [docs] Add docs on full data dirs .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9967/4/docs/administra

[kudu-CR] java: fix various test style issues

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10201 to review the following change. Change subject: java: fix various test style issues .. java: fix various test style i

[kudu-CR] Fix missing @Override annotations

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10193 to review the following change. Change subject: Fix missing @Override annotations .. Fix missing @Override annotation

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, David Ribeiro Alves, Jean-Daniel Cryans, Kudu Jenkins, Anonymous Coward #314, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7362 to look at the new patch set (#4). Change subject: java: prohibit use of a KuduTable from an

[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10194 to review the following change. Change subject: java: fix error message when attempting to import Parquet TIMESTAMP .

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10197 to review the following change. Change subject: java: fix error-prone DefaultCharset[1] issues .. java: fix error-pro

[kudu-CR] java: make all enum members immutable

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10195 to review the following change. Change subject: java: make all enum members immutable .. java: make all enum members

[kudu-CR] java: fix various integer-math error-prone issues

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10200 to review the following change. Change subject: java: fix various integer-math error-prone issues .. java: fix variou

[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10203 to review the following change. Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .

[kudu-CR] java: fix ClassCanBeStatic[1] error-prone checks

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10198 to review the following change. Change subject: java: fix ClassCanBeStatic[1] error-prone checks .. java: fix ClassCa

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10199 to review the following change. Change subject: java: fix minor synchronization issues exposed by error-prone .. java

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10196 to review the following change. Change subject: java: fix error-prone 'StringSplit' pattern[1] .. java: fix error-pro

[kudu-CR] java: fix remainder of error-prone issues

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10202 to review the following change. Change subject: java: fix remainder of error-prone issues .. java: fix remainder of e

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4425 to look at the new patch set (#4). Change subject: java: enable error-prone for java builds ...

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10188 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR](branch-1.4.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10191 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR](branch-1.5.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10190 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR](branch-1.6.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10189 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.or

[kudu-CR](branch-1.4.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10191 Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * Fixes INTE

[kudu-CR](branch-1.5.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10190 Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * Fixes INTE

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-25 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alex Rodoni, Dan Burkert, Attila Bukor, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9849 to look at the new patch set (#4). Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsectio

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 ) Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. Patch Set 3: Code-Review+1 (1 comment) Looks good

[kudu-CR](branch-1.6.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10189 Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * Fixes INTE

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10185 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * F

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10185 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10185 To unsubscri

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10188 Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. KUDU-2416: Fix PartialRow.setMin and add a unit test * Fixes a mi

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10185 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Code-Review+2 > Patch Set 1: Code-Review+2 > > Look

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-25 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 ) Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. Patch Set 3: (4 comments) http://gerrit.clou

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-25 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alex Rodoni, Dan Burkert, Attila Bukor, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9849 to look at the new patch set (#3). Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsectio

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10187 Change subject: [Java] Use spotbugs in place of findbugs in gradle .. [Java] Use spotbugs in place of findbugs in gradle Change-Id: I2c98

[kudu-CR] KUDU-2416: Fix PartialRow.setMin and add a unit test

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10185 ) Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test .. Patch Set 1: Code-Review+2 Looks good. Would be good to understa

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 ) Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. Patch Set 2: (4 comments) One correction and