[kudu-CR] hms precheck tool

2018-07-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 ) Change subject: hms precheck tool .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/11040/2//COMMIT_MSG Commit Message:

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 ) Change subject: hms-tool: refactor check tool and combine upgrade and fix .. Patch Set 8: (9 comments)

[kudu-CR] hms tools: do not require HMS configuration flags

2018-07-25 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11036 to look at the new patch set (#5). Change subject: hms tools: do not require HMS configuration flags

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-25 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11018 to look at the new patch set (#8). Change subject: hms-tool: refactor check tool and combine upgrade and fix

[kudu-CR] schema: add is deleted virtual column

2018-07-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 9: (1 comment)

[kudu-CR] schema: add is deleted virtual column

2018-07-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 9: (1 comment) This implementation is so straightfoward and the

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-25 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. memrowset: support iteration with include_deleted_rows

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-25 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. memrowset: support iteration with snap_to_exclude Following

[kudu-CR] memrowset: support iteration with include deleted rows

2018-07-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with include_deleted_rows .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 8: Code-Review+2 I'm good with this if Grant is. -- To

[kudu-CR] KUDU-2511 fix for SingleReplicasStayOrMove scenario

2018-07-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11046 ) Change subject: KUDU-2511 fix for SingleReplicasStayOrMove scenario .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] Fix flaky 'Random Backup and Restore' test

2018-07-25 Thread Tony Foerster (Code Review)
Tony Foerster has abandoned this change. ( http://gerrit.cloudera.org:8080/10902 ) Change subject: Fix flaky 'Random Backup and Restore' test .. Abandoned This is a bad workaround and the core issue should be fixed. -- To

[kudu-CR] Scala code formatting with Scalafmt

2018-07-25 Thread Tony Foerster (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11030 to look at the new patch set (#8). Change subject: Scala code formatting with Scalafmt ..

[kudu-CR] Scala code formatting with Scalafmt

2018-07-25 Thread Tony Foerster (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11030 to look at the new patch set (#7). Change subject: Scala code formatting with Scalafmt ..