[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11389 ) Change subject: cfile-test: pass in IOContext on Open() .. Patch Set 1: Code-Review+2 I'm curious why ASAN pre-commit build didn't

[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11389 ) Change subject: cfile-test: pass in IOContext on Open() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11389 ) Change subject: cfile-test: pass in IOContext on Open() .. Patch Set 1: Currently running other corruption-relevant tests on dist-test

[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11389 Change subject: cfile-test: pass in IOContext on Open() .. cfile-test: pass in IOContext on Open() Previously, on certain machines,

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#7). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Patch Set 6: (4 comments)

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#6). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2489: Improve runtime of slow java test.

2018-09-04 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11365 ) Change subject: KUDU-2489: Improve runtime of slow java test. .. KUDU-2489: Improve runtime of slow java test. Shortened the

[kudu-CR] KUDU-2489: Improve runtime of slow java test.

2018-09-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 ) Change subject: KUDU-2489: Improve runtime of slow java test. .. Patch Set 2: Code-Review+2 This change passed 110/110 tests. lgtm.

[kudu-CR] KUDU-428: add Sentry to thirdparty, mini-sentry

2018-09-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11347 ) Change subject: KUDU-428: add Sentry to thirdparty, mini-sentry .. Patch Set 2: (1 comment)

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 9: (1 comment)

[kudu-CR] [java] Adjust the RetryRule to log to stdout

2018-09-04 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11382 ) Change subject: [java] Adjust the RetryRule to log to stdout .. [java] Adjust the RetryRule to log to stdout Changes the

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 5: (4 comments) Great progress! Some more nits in

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. [location_awareness] Assign locations

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 10: (1 comment)

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 9: Code-Review+2 (2 comments)

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5 to look at the new patch set (#9). Change subject: [location_awareness] Assign locations to registering tablet servers

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 6: NB we can't merge this until the

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 8: (3 comments)

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 8: (1 comment)

[kudu-CR] test: quell warning in disk failure-itest

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11385 ) Change subject: test: quell warning in disk_failure-itest .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] test: quell warning in disk failure-itest

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11385 ) Change subject: test: quell warning in disk_failure-itest .. test: quell warning in disk_failure-itest disk_failure-itest

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 5: > Patch Set 5: > > (14 comments) > > Hrm, I'm not

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 5: (14 comments) Hrm, I'm not sure why it's not

[kudu-CR] test: quell warning in disk failure-itest

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11385 Change subject: test: quell warning in disk_failure-itest .. test: quell warning in disk_failure-itest disk_failure-itest will yield the

[kudu-CR] build: retry all failed tests

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11374 ) Change subject: build: retry all failed tests .. Patch Set 5: Code-Review+2 But would be good to get a +1/+2 from Todd too. -- To

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 8: (2 comments)

[kudu-CR] build: retry all failed tests

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11374 ) Change subject: build: retry all failed tests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11374/4//COMMIT_MSG

[kudu-CR] build: retry all failed tests

2018-09-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11374 to look at the new patch set (#5). Change subject: build: retry all failed tests ..

[kudu-CR] build: retry all failed tests

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11374 ) Change subject: build: retry all failed tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11374/4//COMMIT_MSG

[kudu-CR] build: retry all failed tests

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11374 ) Change subject: build: retry all failed tests .. Patch Set 4: (3 comments) > Patch Set 3: > > (3 comments) > > > Ah, actually

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5 to look at the new patch set (#8). Change subject: [location_awareness] Assign locations to registering tablet servers

[kudu-CR] build: retry all failed tests

2018-09-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11374 to look at the new patch set (#4). Change subject: build: retry all failed tests ..

[kudu-CR] KUDU-2566: fix two todo list

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: fix two todo list .. Patch Set 2: (2 comments) The formatting in this patch got kind of messed up; there's a

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-09-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11378 ) Change subject: [tablet] Add tablet metric for number of diskrowsets .. [tablet] Add tablet metric for number of diskrowsets

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 ) Change subject: [tablet] Add tablet metric for number of diskrowsets .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Patch Set 5: (9 comments) Thanks for writing such

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 ) Change subject: [tablet] Add tablet metric for number of diskrowsets .. Patch Set 4: (3 comments)

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11378 to look at the new patch set (#4). Change subject: [tablet] Add tablet metric for number of diskrowsets

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 ) Change subject: [tablet] Add tablet metric for number of diskrowsets .. Patch Set 3: (2 comments)

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 7: Verified+1 Unrelated concurrent

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-09-04 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Removed reviewer Kudu Jenkins with the

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11378 to look at the new patch set (#3). Change subject: [tablet] Add tablet metric for number of diskrowsets

[kudu-CR] [java] Adjust the RetryRule to log to stdout

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11382 ) Change subject: [java] Adjust the RetryRule to log to stdout .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] Add tablet metric for number of diskrowsets

2018-09-04 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11378 to look at the new patch set (#2). Change subject: [tablet] Add tablet metric for number of diskrowsets

[kudu-CR] KUDU-2469 pt 2: fail replicas on CFile corruption

2018-09-04 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption .. KUDU-2469 pt 2: fail replicas on CFile corruption This

[kudu-CR] [java] Adjust the RetryRule to log to stdout

2018-09-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11382 ) Change subject: [java] Adjust the RetryRule to log to stdout .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2012 Kudu Flume sink auth support

2018-09-04 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11334 ) Change subject: KUDU-2012 Kudu Flume sink auth support .. Patch Set 2: > Patch Set 2: > > Grant, could you help me identify the cause

[kudu-CR] [java] Adjust the RetryRule to log to stdout

2018-09-04 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11382 Change subject: [java] Adjust the RetryRule to log to stdout .. [java] Adjust the RetryRule to log to stdout Changes the logging in

[kudu-CR] KUDU-2012 Kudu Flume sink auth support

2018-09-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11334 ) Change subject: KUDU-2012 Kudu Flume sink auth support .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-2469 pt 2: fail replicas on CFile corruption

2018-09-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption .. Patch Set 12: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2566: fix two todo list

2018-09-04 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#2). Change subject: KUDU-2566: fix two todo list .. KUDU-2566: fix two