[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#13). Change subject: KUDU-2636: LBM supports deleting dead and full containers ...

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [examples] a small update on SparkExample

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12208 ) Change subject: [examples] a small update on SparkExample .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12208/2/ex

[kudu-CR] [examples] a small update on SparkExample

2019-01-09 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, Mitch Barnett, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12208 to look at the new patch set (#3). Change subject: [examples] a small update on SparkExample ...

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 ) Change subject: [examples] fix name of the class for spark-submit .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.clouder

[kudu-CR] [examples] a small update on SparkExample

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12208 ) Change subject: [examples] a small update on SparkExample .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12208/2/exam

[kudu-CR] [examples] a small update on SparkExample

2019-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12208 ) Change subject: [examples] a small update on SparkExample .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12208/2/exam

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 ) Change subject: [examples] fix name of the class for spark-submit .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12206

[kudu-CR] [examples] a small update on SparkExample

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12208 Change subject: [examples] a small update on SparkExample .. [examples] a small update on SparkExample Updated the Spark example: * a

[kudu-CR] [examples] a small update on SparkExample

2019-01-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12208 to look at the new patch set (#2). Change subject: [examples] a small update on SparkExample .. [examples] a small

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Fix DOS line endings in TestServerInfo.java Change-Id: Id0c470e

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Support location awareness in READ_CLOSEST fo

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 ) Change subject: [examples] fix name of the class for spark-submit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/122

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12206 to look at the new patch set (#2). Change subject: [examples] fix name of the class for spark-submit .

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 7: Code-Review+2 -- To view, visit http:/

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Eliminate redundant VLOG_IS_ON calls In an expression like VLOG(3)

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Assign locations to tablet servers and the client

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 7: Code-Review+2 -- To view, visit http://g

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12194 to look at the new patch set (#4). Change subject: Eliminate redundant VLOG_IS_ON calls .

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 ) Change subject: [examples] fix name of the class for spark-submit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12206/1/e

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12206 ) Change subject: [examples] fix name of the class for spark-submit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] [examples] fix name of the class for spark-submit

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12206 Change subject: [examples] fix name of the class for spark-submit .. [examples] fix name of the class for spark-submit I also removed t

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12087/2

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12200 ) Change subject: Reduce election-related logging .. Reduce election-related logging Frequent simultaneous pre-elections on lots

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12200 ) Change subject: Reduce election-related logging .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12200 T

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12175 to look at the new patch set (#7). Change subject: Support location awareness in READ_CLOSEST for the Java client ..

[kudu-CR] generic iterators: basic MergeIterator dominance

2019-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12197/

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12194/2/src/kudu

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 5: (2 comments) http://gerrit.cloudera.or

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 4: Verified+1 Unrelated flake in raft_consensus-itest. -- T

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12200 to look at the new patch set (#2). Change subject: Reduce election-related logging

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Fix DOS line endings in TestServerInfo.java .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12180 To unsubscribe, vis

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12194 to look at the new patch set (#3). Change subject: Eliminate redundant VLOG_IS_ON calls .

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12157 to look at the new patch set (#7). Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12200 ) Change subject: Reduce election-related logging .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12200/1/src/kudu/con

[kudu-CR] WIP: KUDU-2645. tablet: Add ghost row de-duplication support to MergeIterator

2019-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12205 ) Change subject: WIP: KUDU-2645. tablet: Add ghost row de-duplication support to MergeIterator .. Patch Set 1: (2 comments) Just skimmed

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 4: Verified+1 Unrelated test failure. -- To view, visit ht

[kudu-CR] WIP: KUDU-2645. tablet: Add ghost row de-duplication support to MergeIterator

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12205 ) Change subject: WIP: KUDU-2645. tablet: Add ghost row de-duplication support to MergeIterator .. Patch Set 1: (1 comment) http://gerrit

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12087 To unsubscribe, vi

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT

[kudu-CR] WIP: KUDU-2645. tablet: Add ghost row de-duplication support to MergeIterator

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12205 Change subject: WIP: KUDU-2645. tablet: Add ghost row de-duplication support to MergeIterator .. WIP: KUDU-2645. tablet: Add ghost row de-

[kudu-CR] WIP: tablet: Add support for virtual columns to Schema

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12204 Change subject: WIP: tablet: Add support for virtual columns to Schema .. WIP: tablet: Add support for virtual columns to Schema Needs tes

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12157 ) Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] generic iterators: assorted cleanup

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 ) Change subject: generic_iterators: assorted cleanup .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/co

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 4: lgtm but I'll let Andrew take another look for the +2 if h

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12200 ) Change subject: Reduce election-related logging .. Patch Set 1: Code-Review+1 (1 comment) Nice log cleanup patch, thanks for doing this

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12200 ) Change subject: Reduce election-related logging .. Patch Set 1: Code-Review+2 (1 comment) Just a small nit, feel free to ignore. http:

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/121

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 7: Had to resolve a trivial merge conflict. -

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12174 to look at the new patch set (#7). Change subject: Assign locations to tablet servers and the client in Java ...

[kudu-CR] generic iterators: basic MergeIterator dominance

2019-01-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12197 to look at the new patch set (#3). Change subject: generic_iterators: basic MergeIterator dominance ..

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12157 to look at the new patch set (#6). Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock

[kudu-CR] generic iterators: prep for MergeIterator dominance

2019-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12196 ) Change subject: generic_iterators: prep for MergeIterator dominance .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] Reduce election-related logging

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12200 Change subject: Reduce election-related logging .. Reduce election-related logging Frequent simultaneous pre-elections on lots of table

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12184/1/src/kud

[kudu-CR] generic iterators: move MergeIterState into the header

2019-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12195 ) Change subject: generic_iterators: move MergeIterState into the header .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12087 to look at the new patch set (#4). Change subject: KUDU-2640: Add Spark Structured Streaming Sink

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12087/2

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12087 to look at the new patch set (#3). Change subject: KUDU-2640: Add Spark Structured Streaming Sink

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12087/2/j

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 1: (4 comments) LGTM and it compiles and runs on macOS. Just so

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12194

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12194 to look at the new patch set (#2). Change subject: Eliminate redundant VLOG_IS_ON calls .

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 5: (3 comments) http://gerrit.cloudera.or

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:808

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 10: (1 comment) http://gerrit.cloudera.org

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12174 to look at the new patch set (#6). Change subject: Assign locations to tablet servers and the client in Java ...

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12175 to look at the new patch set (#5). Change subject: Support location awareness in READ_CLOSEST for the Java client ..

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 5: Verified+1 Unrelated trace-test failure in T

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Assign locations to tablet servers and the client in Java .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12174 To un

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Support location awareness in READ_CLOSEST for

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12157 to look at the new patch set (#5). Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock

[kudu-CR] generic iterators: basic MergeIterator dominance

2019-01-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12197 to look at the new patch set (#2). Change subject: generic_iterators: basic MergeIterator dominance ..

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12157 ) Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:

[kudu-CR] generic iterators: assorted cleanup

2019-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 ) Change subject: generic_iterators: assorted cleanup .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/c

[kudu-CR] [build] Update repo URL

2019-01-09 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [build] Update repo URL .. Removed Verified-1 by Attila Bukor -- To view, visit http://gerrit.cloudera.org:8080/12150 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] [build] Update repo URL

2019-01-09 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12150 ) Change subject: [build] Update repo URL .. [build] Update repo URL According to Apache Infra Team the git repo needs to be move

[kudu-CR](gh-pages) [build] Update repo URL

2019-01-09 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12151 ) Change subject: [build] Update repo URL .. [build] Update repo URL According to Apache Infra Team the git repo needs to be move

[kudu-CR](gh-pages) [build] Update repo URL

2019-01-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12151 ) Change subject: [build] Update repo URL .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12151 To unsubscr

[kudu-CR](gh-pages) [build] Update repo URL

2019-01-09 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [build] Update repo URL .. Removed Verified-1 by Attila Bukor -- To view, visit http://gerrit.cloudera.org:8080/12151 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata

2019-01-09 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12186 ) Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata .. KUDU-2195. Add additional gflag to force s

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 9: Code-Review+2 Nice catch regarding the f

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT_

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT_

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT_

[kudu-CR] Eliminate redundant VLOG IS ON calls

2019-01-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 ) Change subject: Eliminate redundant VLOG_IS_ON calls .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT_

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 9: Code-Review+1 (1 comment) http://gerrit.c

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#

  1   2   >