[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-22 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#4). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 11: Code-Review+1 -- To view, visit

[kudu-CR] De-flake sentry tests

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 ) Change subject: De-flake sentry tests .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11961 To

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 11: (2 comments)

[kudu-CR] python: fix Python 3.4 based tests

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12255 ) Change subject: python: fix Python 3.4 based tests .. Patch Set 2: Code-Review+2 (2 comments) Addressed my own feedback in PS2.

[kudu-CR] python: fix Python 3.4 based tests

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#2) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/12255 ) Change subject: python: fix Python 3.4 based tests .. python: fix Python 3.4 based tests Pip

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: Code-Review+2 Given that block_manager-stress-test is

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. KUDU-2665: deflake block_manager-stress-test After commit

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: Verified+1 Overriding Jenkins; the Python3 build breakages

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: > Reread the ThreadPool code, it seems that

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] python: fix Python 3.4 based tests

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12255 ) Change subject: python: fix Python 3.4 based tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: Code-Review+1 Reread the ThreadPool code, it seems that

[kudu-CR] [docker] Add an initial docker build

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 ) Change subject: [docker] Add an initial docker build .. Patch Set 3: (1 comment)

[kudu-CR] [spark] Add some logging to trace KuduContext operations

2019-01-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12252 ) Change subject: [spark] Add some logging to trace KuduContext operations .. Patch Set 1: (1 comment)

[kudu-CR] [docker] Add an initial docker build

2019-01-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 ) Change subject: [docker] Add an initial docker build .. Patch Set 2: (7 comments)

[kudu-CR] [docker] Add an initial docker build

2019-01-22 Thread Grant Henke (Code Review)
Hello Attila Bukor, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12173 to look at the new patch set (#3). Change subject: [docker] Add an initial docker build

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: my preference 2) is not safe because we can't be sure when the

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: (1 comment)

[kudu-CR] python: fix Python 3.4 based tests

2019-01-22 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12255 Change subject: python: fix Python 3.4 based tests .. python: fix Python 3.4 based tests Pip released 19.0 recently and tests based on

[kudu-CR] [spark] Add some logging to trace KuduContext operations

2019-01-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12252 ) Change subject: [spark] Add some logging to trace KuduContext operations .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [spark] Add metrics to kudu-spark

2019-01-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12251 ) Change subject: [spark] Add metrics to kudu-spark .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] De-flake sentry tests

2019-01-22 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11961 to look at the new patch set (#6). Change subject: De-flake sentry tests .. De-flake

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 6: (13 comments)

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 11: (3 comments)

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread Adar Dembo (Code Review)
Hello Mike Percy, helifu, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12254 to review the following change. Change subject: KUDU-2665: deflake block_manager-stress-test .. KUDU-2665:

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11751 to look at the new patch set (#11). Change subject: KUDU-2543 pt 1: basic checks for authz tokens

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12122 to look at the new patch set (#6). Change subject: KUDU-2543 pt 2: pass around default authz tokens

[kudu-CR] [spark] Add metrics to kudu-spark

2019-01-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12251 ) Change subject: [spark] Add metrics to kudu-spark .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [spark] Add metrics to kudu-spark

2019-01-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12251 ) Change subject: [spark] Add metrics to kudu-spark .. Patch Set 1: (1 comment)

[kudu-CR] [spark] Add metrics to kudu-spark

2019-01-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12251 Change subject: [spark] Add metrics to kudu-spark .. [spark] Add metrics to kudu-spark This adds some basic accumulator metrics to

[kudu-CR] [spark] Add some logging to trace KuduContext operations

2019-01-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12252 Change subject: [spark] Add some logging to trace KuduContext operations .. [spark] Add some logging to trace KuduContext operations

[kudu-CR] De-flake sentry tests

2019-01-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 ) Change subject: De-flake sentry tests .. Patch Set 5: (2 comments)

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2019-01-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 11: (5 comments)

[kudu-CR] De-flake sentry tests

2019-01-22 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11961 to look at the new patch set (#5). Change subject: De-flake sentry tests .. De-flake

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2019-01-22 Thread Hao Hao (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11956 to look at the new patch set (#11). Change subject: [sentry] add mini Sentry to the external mini cluster

[kudu-CR] [docker] Add an initial docker build

2019-01-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 ) Change subject: [docker] Add an initial docker build .. Patch Set 2: (7 comments)