[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

2019-06-19 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13676 to review the following change. Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) .. KUDU-2869.

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-19 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13649 to look at the new patch set (#3). Change subject: [tools] Add get/set extra-configs for CLI tools ..

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-19 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13649 ) Change subject: [tools] Add get/set extra-configs for CLI tools .. Patch Set 3: (5 comments) Thanks for comments. I added some tests and cha

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (15 comments) sorry for the late update. http://gerrit.c

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#10). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#11). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

2019-06-19 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13676 ) Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR](branch-1.10.x) KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

2019-06-19 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13677 Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) .. KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) For wh

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13678 Change subject: [sentry] add require_db_privileges flag for ListTables .. [sentry] add require_db_privileges flag for ListTables This pat

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 11: (1 comment) Haven't looked in depth, but I left fee

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13649 ) Change subject: [tools] Add get/set extra-configs for CLI tools .. Patch Set 3: (1 comment) Thanks for making the change! One more thin

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13676 ) Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) .. KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Hello Mike Percy, Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13681 to review the following change. Change subject: KUDU-2870: use coarse-grained authz for Checksum ..

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13681 to look at the new patch set (#2). Change subject: KUDU-2870: use coarse-grained authz for Checksum

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13681 to look at the new patch set (#3). Change subject: KUDU-2870: use coarse-grained authz for Checksum .

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: use coarse-grained authz for Checksum .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13681/

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: use coarse-grained authz for Checksum .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/136

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13681 to look at the new patch set (#4). Change subject: KUDU-2870: use coarse-grained authz for Checksum .

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: use coarse-grained authz for Checksum .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13681

[kudu-CR] KUDU-2870: use coarse-grained authz for Checksum

2019-06-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: use coarse-grained authz for Checksum .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/136

[kudu-CR] KUDU-2870: allow super-user to skip authz checks in Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13681 to look at the new patch set (#5). Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum .

[kudu-CR] KUDU-2870: allow super-user to skip authz checks in Checksum

2019-06-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:80

[kudu-CR] KUDU-2870: allow super-user to skip authz checks in Checksum

2019-06-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum .. Patch Set 5: Code-Review+2 (3 comments) http://gerrit

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-19 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13649 to look at the new patch set (#4). Change subject: [tools] Add get/set extra-configs for CLI tools ..

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-19 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13649 ) Change subject: [tools] Add get/set extra-configs for CLI tools .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13649/3/src/

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13678 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. [sentry] add require_db_privileges flag for ListTables Thi

[kudu-CR] KUDU-2870: allow super-user to skip authz checks in Checksum

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13678 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [sentry] add require_db_privileges flag for ListTables .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13678 To unsubscribe

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13678 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-19 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13649 to look at the new patch set (#5). Change subject: [tools] Add get/set extra-configs for CLI tools ..

[kudu-CR] KUDU-2871 (part 1): disable TLS 1.3.

2019-06-19 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13683 to review the following change. Change subject: KUDU-2871 (part 1): disable TLS 1.3. .. KUDU-2871 (part 1): disable