[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 3: Code-Review+1 (1 comment) Would be good for someone else to

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 16: (15 comments)

[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Priyanka Chheda, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13820 to look at the new patch set (#3). Change subject: [docs] update the upgrade documentation

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 7: (2 comments)

[kudu-CR](branch-1.10.x) [docs] Update the site build to use the release directory

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13840 ) Change subject: [docs] Update the site build to use the release directory .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.10.x) Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13839 ) Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#7). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13832

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 3: (1 comment)

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread ZhangYao (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13832 to look at the new patch set (#3). Change subject: Separate benchmark to single test .. Separate

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 3: Code-Review+2 Test failure looks

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. KUDU-2855 Lazy-create DeltaMemStore on first update This

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 16: (1 comment)

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-07-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 3: (6 comments)

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-07-10 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, XiaokaiWang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13659 to look at the new patch set (#3). Change subject: [maintenance] Add extra config for maintenance manager task

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13821 to look at the new patch set (#4). Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13833 ) Change subject: KUDU-2881 Support create/drop range partition by command line .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13833 ) Change subject: KUDU-2881 Support create/drop range partition by command line .. Patch Set 1: (17 comments) Thanks for the

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 2: (1 comment) > (1 comment) > > How slow are these tests in DEBUG mode?

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread ZhangYao (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13832 to look at the new patch set (#2). Change subject: Separate benchmark to single test .. Separate

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 16: (2 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#16). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)

2019-07-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13841 ) Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two) .. [doxygen] fix KuduScanTokenBuilder::SetDiffScan

[kudu-CR] [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13841 ) Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two) .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)

2019-07-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13841 Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two) .. [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take

[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13837 ) Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Patch Set 2: (1 comment)

[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 2: (1 comment)

[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 2: (9 comments)

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. Patch Set 3: (3 comments)

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13835 ) Change subject: [docs] Update the site build to use the release directory .. [docs] Update the site build to use the release

[kudu-CR](branch-1.10.x) Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13839 Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Fix KuduScanTokenBuilder::SetDiffScan docs It looks like Doxygen can’t use

[kudu-CR](branch-1.10.x) [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13840 Change subject: [docs] Update the site build to use the release directory .. [docs] Update the site build to use the release directory

[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13837 ) Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Fix KuduScanTokenBuilder::SetDiffScan docs It looks like Doxygen

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13835 ) Change subject: [docs] Update the site build to use the release directory .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [docs] Update the site build to use the release directory .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13835 To

[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13837 ) Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.10.x) Remove experimental tags from NVM block cache gflags

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13838 Change subject: Remove experimental tags from NVM block cache gflags .. Remove experimental tags from NVM block cache gflags The block

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13835 ) Change subject: [docs] Update the site build to use the release directory .. Patch Set 1: (1 comment)

[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13837 Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Fix KuduScanTokenBuilder::SetDiffScan docs It looks like Doxygen can’t use

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13835 to look at the new patch set (#3). Change subject: [docs] Update the site build to use the release directory

[kudu-CR](branch-1.10.x) [web] add HMS docs to the side menu

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13836 ) Change subject: [web] add HMS docs to the side menu .. [web] add HMS docs to the side menu Change-Id:

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13835 ) Change subject: [docs] Update the site build to use the release directory .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR](branch-1.10.x) [docs] Make the quickstart link more obvious

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13834 ) Change subject: [docs] Make the quickstart link more obvious .. [docs] Make the quickstart link more obvious Adjusts the

[kudu-CR](branch-1.10.x) [web] add HMS docs to the side menu

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13836 ) Change subject: [web] add HMS docs to the side menu .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13835 ) Change subject: [docs] Update the site build to use the release directory .. Patch Set 2: (3 comments)

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13835 to look at the new patch set (#2). Change subject: [docs] Update the site build to use the release directory

[kudu-CR] [web] add HMS docs to the side menu

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13831 ) Change subject: [web] add HMS docs to the side menu .. [web] add HMS docs to the side menu Change-Id:

[kudu-CR](branch-1.10.x) [web] add HMS docs to the side menu

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13836 Change subject: [web] add HMS docs to the side menu .. [web] add HMS docs to the side menu Change-Id:

[kudu-CR] [web] add HMS docs to the side menu

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13831 ) Change subject: [web] add HMS docs to the side menu .. Patch Set 1: > Patch Set 1: Code-Review+2 > > I am a +2 on this. A side thought

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13835 ) Change subject: [docs] Update the site build to use the release directory .. Patch Set 1: (3 comments)

[kudu-CR](branch-1.10.x) [docs] Make the quickstart link more obvious

2019-07-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13834 ) Change subject: [docs] Make the quickstart link more obvious .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Update the site build to use the release directory

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13835 Change subject: [docs] Update the site build to use the release directory .. [docs] Update the site build to use the release directory

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#6). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#5). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 4: (2 comments)

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-07-10 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. Patch Set 3: (3 comments)

[kudu-CR] [web] add HMS docs to the side menu

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13831 ) Change subject: [web] add HMS docs to the side menu .. Patch Set 1: Code-Review+2 I am a +2 on this. A side thought is that we may want

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#4). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR](branch-1.10.x) [docs] Make the quickstart link more obvious

2019-07-10 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13834 Change subject: [docs] Make the quickstart link more obvious .. [docs] Make the quickstart link more obvious Adjusts the sidebar to make

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 2: (2 comments) Yingchun has also

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#3). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 15: (2 comments)

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 2: > I'm curious about how to

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 2: > (14 comments) Thanks for

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-10 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#2). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 1: (1 comment) How slow are these tests in DEBUG mode?

[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 2: (11 comments)

[kudu-CR] KUDU-2722 (table level): Support table extraConfig 'write enabled' conf

2019-07-10 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support table extraConfig 'write_enabled' conf .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2881 Support create/drop range partition by command line

2019-07-10 Thread honeyhexin (Code Review)
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13833 Change subject: KUDU-2881 Support create/drop range partition by command line .. KUDU-2881 Support create/drop range partition by command

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13821 to look at the new patch set (#3). Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update

[kudu-CR] KUDU-2855 Lazy-create DeltaMemStore on first update

2019-07-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 ) Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update .. Patch Set 2: (8 comments)

[kudu-CR] Separate benchmark to single test

2019-07-10 Thread ZhangYao (Code Review)
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13832 Change subject: Separate benchmark to single test .. Separate benchmark to single test Separate the total benchmark to single test with

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 15: (12 comments) > (12 comments) > > Just passing

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#15). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-10 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: Here is the

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-10 Thread ZhangYao (Code Review)
Hello Kudu Jenkins, Yao Xu, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13721 to look at the new patch set (#2). Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Priyanka Chheda, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13820 to look at the new patch set (#2). Change subject: [docs] update the upgrade documentation

[kudu-CR] [docs] update the upgrade documentation

2019-07-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 1: (7 comments) Here is a link to display the rendered form:

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 5: (37 comments) I didn't review metrics-test.cc yet.

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-10 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#20). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2722 (table level): Support table extraConfig 'write enabled' conf

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support table extraConfig 'write_enabled' conf .. Patch Set 1: I'm curious about how to implement