[kudu-CR] [mini-cluster] built-in NTP client configuration mode

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15238 ) Change subject: [mini-cluster] built-in NTP client configuration mode .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [tests] add time anomalies test

2020-02-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15239 to look at the new patch set (#2). Change subject: [tests] add time anomalies test .

[kudu-CR] [tests] add time anomalies test

2020-02-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15239 ) Change subject: [tests] add time anomalies test .. Patch Set 1: > Looks like the new test failed though. Yup, for some reason chronyc

[kudu-CR] [mini-cluster] built-in NTP client configuration mode

2020-02-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15238 to look at the new patch set (#2). Change subject: [mini-cluster] built-in NTP client configuration mode ...

[kudu-CR] [mini-cluster] built-in NTP client configuration mode

2020-02-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15238 ) Change subject: [mini-cluster] built-in NTP client configuration mode .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tests] add time anomalies test

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15239 ) Change subject: [tests] add time anomalies test .. Patch Set 1: Code-Review+2 Looks like the new test failed though. -- To view, visit

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 4: (18 comments) Addressed partial comments and push

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new patch set (#4) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. [cpp] KUDU-2971: pr

[kudu-CR] [mini-cluster] built-in NTP client configuration mode

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15238 ) Change subject: [mini-cluster] built-in NTP client configuration mode .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [mini-cluster] built-in NTP client configuration mode

2020-02-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15238 Change subject: [mini-cluster] built-in NTP client configuration mode .. [mini-cluster] built-in NTP client configuration mode This pat

[kudu-CR] [tests] add time anomalies test

2020-02-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15239 Change subject: [tests] add time anomalies test .. [tests] add time anomalies test This patch adds a new test to exercise the behavior

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4522 ) Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE .. [python] KUDU-1563. Add support for INSERT_IGNORE Implements

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4523 ) Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE .. [java] KUDU-1563. Add support for INSERT_IGNORE Implements jav

[kudu-CR] KUDU-1563. Add an INSERT IGNORE operation

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add an INSERT_IGNORE operation .. KUDU-1563. Add an INSERT_IGNORE operation This patch adds an `INSERT

[kudu-CR] KUDU-1563. Add an INSERT IGNORE operation

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add an INSERT_IGNORE operation .. Patch Set 24: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 ) Change subject: [java] KUDU-2972: add Kudu Ranger plugin .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/15074/4/java/k

[kudu-CR] KUDU-1563. Add an INSERT IGNORE operation

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#24) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add an INSERT_IGNORE operation .. KUDU-1563. Add an INSERT_IGNO

[kudu-CR] KUDU-1563. Add an INSERT IGNORE operation

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add an INSERT_IGNORE operation .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/4491/20//COM

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 ) Change subject: [java] KUDU-2972: add Kudu Ranger plugin .. Patch Set 6: > I see, that is a good idea. Thanks for bringing it up! In the

[kudu-CR] KUDU-1563. Add an INSERT IGNORE operation

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add an INSERT_IGNORE operation .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/4491/20//COMM

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 ) Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE .. Patch Set 26: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4522 ) Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 ) Change subject: [java] KUDU-2972: add Kudu Ranger plugin .. Patch Set 6: > Patch Set 6: > > > > How do you feel about predicating this chang

[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats

2020-02-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 ) Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats .. Patch Set 5: Thank you for the review! Some extra info: I

[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats

2020-02-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15224 ) Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats .. [test] fix flake in TsTabletManagerITest::TestTable

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 ) Change subject: [java] KUDU-2972: add Kudu Ranger plugin .. Patch Set 6: > > How do you feel about predicating this change on MiniRanger

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 ) Change subject: [java] KUDU-2972: add Kudu Ranger plugin .. Patch Set 6: > Patch Set 4: > > (17 comments) > > How do you feel about predicat

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-02-18 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14177 to look at the new patch set (#15). Change subject: KUDU-2780: create thread for auto-rebalancing

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-02-18 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 14: (18 comments) Still need to look into implementing a c

[kudu-CR] [cpp] KUDU-2971: protobuf-based wrapper for subprocesses

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 ) Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats

2020-02-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 ) Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 ) Change subject: [java] KUDU-2972: add Kudu Ranger plugin .. Patch Set 5: (24 comments) http://gerrit.cloudera.org:8080/#/c/15074/4/java/kud

[kudu-CR] [java] KUDU-2972: add Kudu Ranger plugin

2020-02-18 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15074 to look at the new patch set (#6). Change subject: [java] KUDU-2972: add Kudu Ranger plugin ...=rE...

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4523 ) Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE .. Patch Set 25: (3 comments) http://gerrit.cloudera.org:8080/#/c/4523/2

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#21) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4522 ) Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE .. [python] KUDU-1563. A

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#26) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4523 ) Change subject: [java] KUDU-1563. Add support for INSERT_IGNORE .. [java] KUDU-1563. Add s

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4522 ) Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/4522

[kudu-CR] KUDU-1563. Add an INSERT IGNORE operation

2020-02-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#23) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4491 ) Change subject: KUDU-1563. Add an INSERT_IGNORE operation .. KUDU-1563. Add an INSERT_IGNO