[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 ) Change subject: [tserver] KUDU-2612: participant op RPC endpoint .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 ) Change subject: [tserver] KUDU-2612: participant op RPC endpoint .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 ) Change subject: [tserver] KUDU-2612: participant op RPC endpoint .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/16814

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16814 to look at the new patch set (#4). Change subject: [tserver] KUDU-2612: participant op RPC endpoint

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. [txn] update not-a-leader retry logic in TxnSystemC

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16815 To uns

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 5: Verified+1 I'll take care of the issue report

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 ) Change subject: [tserver] KUDU-2612: participant op RPC endpoint .. Patch Set 3: Code-Review+2 (4 comments) http://gerrit.cloudera.or

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for C++ client

2020-12-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 ) Change subject: KUDU-2612 keep-alive txn heartbeating for C++ client .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16779

[kudu-CR] txn participant: return TXN ILLEGAL STATE code on illegal state errors

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16831 ) Change subject: txn_participant: return TXN_ILLEGAL_STATE code on illegal state errors .. Patch Set 2: Code-Review+2 -- To view, vis

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16814 to look at the new patch set (#3). Change subject: [tserver] KUDU-2612: participant op RPC endpoint

[kudu-CR] txn participant: return TXN ILLEGAL STATE code on illegal state errors

2020-12-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16831 to look at the new patch set (#2). Change subject: txn_participant: return TXN_ILLEGAL_STATE code on illegal state errors ..

[kudu-CR] txn participant: return TXN ILLEGAL STATE code on illegal state errors

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16831 ) Change subject: txn_participant: return TXN_ILLEGAL_STATE code on illegal state errors .. Patch Set 1: It seems IWYU isn't yet happy,

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] txn participant: return TXN ILLEGAL STATE code on illegal state errors

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16831 ) Change subject: txn_participant: return TXN_ILLEGAL_STATE code on illegal state errors .. Patch Set 1: Code-Review+2 -- To view, vis

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16815 to look at the new patch set (#5). Change subject: [txn] update not-a-leader retry logic in TxnSystemClient ..

[kudu-CR] [master][consensus] Procedure for copying system catalog

2020-12-07 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16830 to look at the new patch set (#2). Change subject: [master][consensus] Procedure for copying system catalog .. [mas

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16815 to look at the new patch set (#4). Change subject: [txn] update not-a-leader retry logic in TxnSystemClient ..

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16815 to look at the new patch set (#3). Change subject: [txn] update not-a-leader retry logic in TxnSystemClient ..

[kudu-CR] txn participant: return TXN ILLEGAL STATE code on illegal state errors

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16831 Change subject: txn_participant: return TXN_ILLEGAL_STATE code on illegal state errors .. txn_participant: return TXN_ILLEGAL_STATE code

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 ) Change subject: Replace boost::iequals with our own implementation .. Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 ) Change subject: Replace boost::iequals with our own implementation .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/168

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16826 to look at the new patch set (#5). Change subject: Replace boost::iequals with our own implementation .

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16826 to look at the new patch set (#4). Change subject: Replace boost::iequals with our own implementation .

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR](gh-pages) Publish docs changes from master

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16828 ) Change subject: Publish docs changes from master .. Patch Set 1: I will make some more docs changes and update this patch -- To view,

[kudu-CR](gh-pages) Publish docs changes from master

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16828 ) Change subject: Publish docs changes from master .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16828/1/releases/1.13.

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 ) Change subject: [tserver] KUDU-2612: participant op RPC endpoint .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/16814

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

2020-12-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16814 to look at the new patch set (#2). Change subject: [tserver] KUDU-2612: participant op RPC endpoint

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

2020-12-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 ) Change subject: [txn] update not-a-leader retry logic in TxnSystemClient .. Patch Set 2: (1 comment) Overall looks good to me. http://gerr

[kudu-CR] [master][consensus] Procedure for copying system catalog

2020-12-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16830 Change subject: [master][consensus] Procedure for copying system catalog .. [master][consensus] Procedure for copying system catalog T

[kudu-CR] tablet: allow interleaving of row liveness between compaction input rows

2020-12-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16752 ) Change subject: tablet: allow interleaving of row liveness between compaction input rows .. Patch Set 2: (3 comments) http://gerrit.cloude

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 ) Change subject: Replace boost::iequals with our own implementation .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 ) Change subject: Replace boost::iequals with our own implementation .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/168

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16826 to look at the new patch set (#3). Change subject: Replace boost::iequals with our own implementation .

[kudu-CR](gh-pages) Publish docs changes from master

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16828 ) Change subject: Publish docs changes from master .. Patch Set 1: Code-Review+1 (1 comment) I looked through the metrics pages in chrome

[kudu-CR](gh-pages) Publish docs changes from master

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16828 Change subject: Publish docs changes from master .. Publish docs changes from master This patch publishes a bunch of recent docs changes

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 ) Change subject: Replace boost::iequals with our own implementation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 ) Change subject: Replace boost::iequals with our own implementation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [docs] Copy 1.12.0 release notes to prior release notes

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16827 ) Change subject: [docs] Copy 1.12.0 release notes to prior release notes .. [docs] Copy 1.12.0 release notes to prior release note

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16826 to look at the new patch set (#2). Change subject: Replace boost::iequals with our own implementation .. Replace bo

[kudu-CR] [docs] Copy 1.12.0 release notes to prior release notes

2020-12-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16827 ) Change subject: [docs] Copy 1.12.0 release notes to prior release notes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] [docs] Copy 1.12.0 release notes to prior release notes

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16827 Change subject: [docs] Copy 1.12.0 release notes to prior release notes .. [docs] Copy 1.12.0 release notes to prior release notes It loo

[kudu-CR] Replace boost::iequals with our own implementation

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16826 Change subject: Replace boost::iequals with our own implementation .. Replace boost::iequals with our own implementation This patch repla

[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16824 ) Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0" .. Revert "[thirdparty] Upgrade glog to 0.4.0" This reverts commit 2

[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"

2020-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16824 ) Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0" .. Patch Set 1: Code-Review+2 It seems we had all the necessary functional

[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"

2020-12-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16824 ) Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16824 ) Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0" .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16824 To unsubscribe, visit

[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"

2020-12-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16824 Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0" .. Revert "[thirdparty] Upgrade glog to 0.4.0" This reverts commit 2943aa701e