[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17037 ) Change subject: KUDU-2612 tablet servers automatically register txn participants .. Patch Set 5: (1 comment) http://gerrit.cloudera.o

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-16 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17037 to look at the new patch set (#6). Change subject: KUDU-2612 tablet servers automatically register txn participants .

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17037 ) Change subject: KUDU-2612 tablet servers automatically register txn participants .. Patch Set 2: (19 comments) http://gerrit.cloudera

[kudu-CR] python: pin pytest-runner to <5.3.0

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17074 ) Change subject: python: pin pytest-runner to <5.3.0 .. Patch Set 3: Code-Review+2 > Change has been successfully cherry-picked as > f

[kudu-CR] python: pin pytest-runner to <5.3.0

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17074 ) Change subject: python: pin pytest-runner to <5.3.0 .. python: pin pytest-runner to <5.3.0 Per https://github.com/pytest-dev/pyt

[kudu-CR] python: pin pytest-runner to <5.3.0

2021-02-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17074 ) Change subject: python: pin pytest-runner to <5.3.0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/170

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17073 ) Change subject: KUDU-2612: make BeginCommit return OK if already committed .. KUDU-2612: make BeginCommit return OK if already co

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17073 ) Change subject: KUDU-2612: make BeginCommit return OK if already committed .. Patch Set 2: Verified+1 Build failure is unrelated; a patc

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: make BeginCommit return OK if already committed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17073 To uns

[kudu-CR] python: pin pytest-runner to <5.3.0

2021-02-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17074 to look at the new patch set (#2). Change subject: python: pin pytest-runner to <5.3.0 .. python: pin pytest-runner

[kudu-CR] python: pin pytest-runner to <5.3.0

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17074 Change subject: python: pin pytest-runner to <5.3.0 .. python: pin pytest-runner to <5.3.0 Per https://github.com/pytest-dev/pytest-runne

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17073 ) Change subject: KUDU-2612: make BeginCommit return OK if already committed .. Patch Set 2: Code-Review+2 -- To view, visit http://ger

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 ) Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 ) Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17056/5/sr

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17073 ) Change subject: KUDU-2612: make BeginCommit return OK if already committed .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17073 to look at the new patch set (#2). Change subject: KUDU-2612: make BeginCommit return OK if already committed .

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17073 ) Change subject: KUDU-2612: make BeginCommit return OK if already committed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17037 ) Change subject: KUDU-2612 tablet servers automatically register txn participants .. Patch Set 5: (2 comments) Not a full review, just m

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17073 Change subject: KUDU-2612: make BeginCommit return OK if already committed .. KUDU-2612: make BeginCommit return OK if already committed

[kudu-CR] [test] Start using GTEST SKIP where applicable

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17063 ) Change subject: [test] Start using GTEST_SKIP where applicable .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17063

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 ) Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17056 ) Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. Patch Set 5: Verified+1 Unrelated test failure in RELEASE build ShouldG

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has removed a vote on this change. Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17056 To unsubscribe, vis

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17056 to look at the new patch set (#5). Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. [thirdparty] Upgra

[kudu-CR] [thirdparty] Upgrade gmock/gtest to 1.10.0

2021-02-16 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17056 to look at the new patch set (#4). Change subject: [thirdparty] Upgrade gmock/gtest to 1.10.0 .. [thirdparty] Upgra

[kudu-CR] [test] Start using GTEST SKIP where applicable

2021-02-16 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17063 to look at the new patch set (#2). Change subject: [test] Start using GTEST_SKIP where applicable .. [tes

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-16 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17037 to look at the new patch set (#5). Change subject: KUDU-2612 tablet servers automatically register txn participants .

[kudu-CR] [tests] small cleanup on TxnCommitITest

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17070 ) Change subject: [tests] small cleanup on TxnCommitITest .. [tests] small cleanup on TxnCommitITest * removed unused variable i

[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 ) Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls .. Patch Set 1: > Thanks! I'll update the logic so BeginCommit c

[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17069 ) Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls .. [test] fix flake in TestConcurrentRepeatedCommitCalls

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-16 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17037 to look at the new patch set (#4). Change subject: KUDU-2612 tablet servers automatically register txn participants .

[kudu-CR] [tests] small cleanup on TxnCommitITest

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17070 ) Change subject: [tests] small cleanup on TxnCommitITest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls

2021-02-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 ) Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls .. Patch Set 1: Code-Review+2 Thanks! I'll update the logic so Beg

[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17069 To unsubs

[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls

2021-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 ) Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls .. Patch Set 1: Verified+1 unrelated test failures in * Rebala