[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yuqi Du (Code Review)
Hello Tidy Bot, Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19794 to look at the new patch set (#14). Change subject: [cpp-client] KUDU-3455 Red

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 13: (

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 14: Co

[kudu-CR] KUDU-3371 [fs] make LogBlockContainer a base class

2023-06-26 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 ) Change subject: KUDU-3371 [fs] make LogBlockContainer a base class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 1

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 1

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Removed Verified-1 by Kudu Jenkins (120) -- To view, vi

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-06-26 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 14: Co

[kudu-CR] [multi-tenancy] add a server key upgrade tool

2023-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20103 ) Change subject: [multi-tenancy] add a server key upgrade tool .. [multi-tenancy] add a server key upgrade tool For the purpose

[kudu-CR] unset * proxy env variables for Python3 tests

2023-06-26 Thread Marton Greber (Code Review)
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20119 Change subject: unset *_proxy env variables for Python3 tests .. unset *_proxy env variables for Python3 tests Commit 459207ff5c103e7d4

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Attila Bukor (Code Review)
Hello Marton Greber, Tidy Bot, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20050 to look at the new patch set (#10). Change subject: KUDU-3448 Add support for encrypting existing keys ..

[kudu-CR] unset * proxy env variables for Python3 tests

2023-06-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20119 ) Change subject: unset *_proxy env variables for Python3 tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-3459 Download superblock piece by piece

2023-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 ) Change subject: KUDU-3459 Download superblock piece by piece .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/19620/2

[kudu-CR] unset * proxy env variables for Python3 tests

2023-06-26 Thread Zoltan Chovan (Code Review)
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/20119 ) Change subject: unset *_proxy env variables for Python3 tests .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] unset * proxy env variables for Python3 tests

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20119 ) Change subject: unset *_proxy env variables for Python3 tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] unset * proxy env variables for Python3 tests

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20119 ) Change subject: unset *_proxy env variables for Python3 tests .. unset *_proxy env variables for Python3 tests Commit 459207ff

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Attila Bukor (Code Review)
Hello Marton Greber, Tidy Bot, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20050 to look at the new patch set (#11). Change subject: KUDU-3448 Add support for encrypting existing keys ..

[kudu-CR] [client] KUDU-1945 Add UPSERT support

2023-06-26 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client] KUDU-1945 Add UPSERT support .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/20083/13/s

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 10: (4 comments) overall looks good to me, just a few

[kudu-CR] [client] KUDU-1945 Add UPSERT support

2023-06-26 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client] KUDU-1945 Add UPSERT support .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Attila Bukor (Code Review)
Hello Marton Greber, Tidy Bot, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20050 to look at the new patch set (#12). Change subject: KUDU-3448 Add support for encrypting existing keys ..

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. Patch Set 12: Verified+1 unrelated test failures in Java test:

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3448 Add support for encrypting existing keys .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20050 To unsubscri

[kudu-CR] KUDU-3448 Add support for encrypting existing keys

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20050 ) Change subject: KUDU-3448 Add support for encrypting existing keys .. KUDU-3448 Add support for encrypting existing keys On an

[kudu-CR] [client] KUDU-1945 Add UPSERT support

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client] KUDU-1945 Add UPSERT support .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 11: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 11: The only question is what behavio

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Abhishek Chennaka (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20084 to look at the new patch set (#12). Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns ..

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 11: Updated the commit message wi

[kudu-CR] [client] KUDU-1945 Add UPSERT support

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20083 ) Change subject: [client] KUDU-1945 Add UPSERT support .. [client] KUDU-1945 Add UPSERT support This patch adds UPSERT support

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 12: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. Patch Set 12: > Updated the commit message with

[kudu-CR] KUDU-3476: Make replica placement range and table aware

2023-06-26 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 ) Change subject: KUDU-3476: Make replica placement range and table aware .. Patch Set 9: (8 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] KUDU-3476: Make replica placement range and table aware

2023-06-26 Thread Mahesh Reddy (Code Review)
Hello Marton Greber, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Ádám Bakai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19931 to look at the new patch set (#9). Change subject: KUDU-3476: Make replica placement range a

[kudu-CR] KUDU-1945 Backup/restore for tables with auto incrementing columns

2023-06-26 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20084 ) Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns .. KUDU-1945 Backup/restore for tables

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: Code-Review+2 Thanks a lot for the fix

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: -Code-Review I see Yifan Zhang raised

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-06-26 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: (1 comment) > Patch Set 16: > > This patc