[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Yifan Zhang, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20600 to look at the new patch set (#24). Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .

[kudu-CR] [util] add a warning into 'heap sample every n bytes' flag description.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#9). Change subject: [util] add a warning into 'heap_sample_every_n_bytes' flag description.

[kudu-CR] [util] add a warning into 'heap sample every n bytes' flag description.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#11). Change subject: [util] add a warning into 'heap_sample_every_n_bytes' flag description. ...

[kudu-CR] [util] add a warning into 'heap sample every n bytes' flag description.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#10). Change subject: [util] add a warning into 'heap_sample_every_n_bytes' flag description. ...

[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Yifan Zhang, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20600 to look at the new patch set (#25). Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#12). Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. ...

[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Yifan Zhang, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20600 to look at the new patch set (#26). Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#13). Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. ...

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-18 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#12). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-18 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 11: (2 comments) > Patch Set 11: >

[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.

2023-12-18 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .. Patch Set 26: Code-Review+2 -- To view, visit h

[kudu-CR] KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-18 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 2: Code-Review-1 (1 comment) h

[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana

2023-12-18 Thread Marton Greber (Code Review)
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20814 Change subject: Add blog post about Prometheus/Grafana .. Add blog post about Prometheus/Grafana While the review is ongoing I'm hostin

[kudu-CR] KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-18 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 2: (1 comment) http://gerri

[kudu-CR] KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-18 Thread Ashwani Raina (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Ádám Bakai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20792 to look at the new patch set (#3). Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. ..

[kudu-CR] [rpc] modernize code a bit

2023-12-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20815 Change subject: [rpc] modernize code a bit .. [rpc] modernize code a bit Since I'm updating the code in src/kudurpc/connection.{h,cc} a

[kudu-CR] [util] move TCP socket stats into the Socket class

2023-12-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20772 to look at the new patch set (#3). Change subject: [util] move TCP socket stats into the Socket class ...

[kudu-CR] [rpc] modernize code a bit

2023-12-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20815 to look at the new patch set (#2). Change subject: [rpc] modernize code a bit .. [rpc] modernize

[kudu-CR] [util] move TCP socket stats into the Socket class

2023-12-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20772 to look at the new patch set (#5). Change subject: [util] move TCP socket stats into the Socket class ...

[kudu-CR] [rpc] modernize code a bit

2023-12-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20815 to look at the new patch set (#3). Change subject: [rpc] modernize code a bit .. [rpc] modernize

[kudu-CR] [rpc] modernize code a bit

2023-12-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20815 ) Change subject: [rpc] modernize code a bit .. Patch Set 3: Verified+1 unrelated failure in Java test -- To view, visit http://gerrit

[kudu-CR] [rpc] modernize code a bit

2023-12-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] modernize code a bit .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20815 To unsubscribe, visit http://gerrit.

[kudu-CR] [util] move TCP socket stats into the Socket class

2023-12-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20772 ) Change subject: [util] move TCP socket stats into the Socket class .. Patch Set 5: Verified+1 unrelated tests failure in EncryptionEn

[kudu-CR] [util] move TCP socket stats into the Socket class

2023-12-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [util] move TCP socket stats into the Socket class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20772 To unsubscri