[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Alexey Serbin (Code Review)
Hello Marton Greber, Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21007 to review the following change. Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21006 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21006 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 ) Change subject: [catalog_manager] Tighten leader UUID fallback .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21006 To

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21006 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Verified+1 unrelated test failures -- To view,

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21006 Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I took a

[kudu-CR] [log block manager-test] Improve random selection

2024-02-06 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 9: Code-Review+1 LGTM, lets get a green build and I'll

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. KUDU-3549 fix WriteAsPrometheus() for

[kudu-CR] [log block manager-test] Improve random selection

2024-02-06 Thread Code Review
Hello Mahesh Reddy, Tidy Bot, Zoltan Martonka, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20899 to look at the new patch set (#9). Change subject: [log_block_manager-test] Improve random selection

[kudu-CR] [log block manager] Write lock for deletion

2024-02-06 Thread Code Review
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20901 to look at the new patch set (#12). Change subject: [log_block_manager] Write lock for deletion

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-06 Thread Code Review
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21004 Change subject: [catalog_manager] Tighten leader UUID fallback .. [catalog_manager] Tighten leader UUID fallback It is safe to assume

[kudu-CR] KUDU-613: Scan Resistant Caching

2024-02-06 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 8: (2 comments) +1 on what Alexey was proposing, spliting up the

[kudu-CR] [rpc] validate security-related parameters earlier

2024-02-06 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20961 ) Change subject: [rpc] validate security-related parameters earlier .. Patch Set 1: Would it makes sense to add a basic test, to

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Code-Review+2 Did verify that the

[kudu-CR] [WIP][catalog manager] Skip eviction during bootstrapping

2024-02-06 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20958 ) Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping .. Patch Set 6: My root cause analysis was incorrect, I will

[kudu-CR] [WIP][catalog manager] Skip eviction during bootstrapping

2024-02-06 Thread Code Review
Ádám Bakai has abandoned this change. ( http://gerrit.cloudera.org:8080/20958 ) Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/20958 To