[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5305 Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. WIP KUDU-1127 Don't hang scanner threads waiting

[kudu-CR] [clock] minor clean-up on the Clock class

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [clock] minor clean-up on the Clock class .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5303/1/src/kudu/server/clock.h File

[kudu-CR] [ts tablet manager] simplified WaitForAllBootstrapsToFinish

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [ts_tablet_manager] simplified WaitForAllBootstrapsToFinish .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5301 To

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java client] Allow to pass extra flags to tservers/masters .. Patch Set 1: (2 comments)

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: [java client] Allow to pass extra flags to tservers/masters .. [java client] Allow to pass extra flags to tservers/masters This path adds a couple of

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#15). Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes

[kudu-CR] WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5300 Change subject: WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. WIP: KUDU-798 (part 4) Add a

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5299 Change subject: [java client] Allow to pass extra flags to tservers/masters .. [java client] Allow to pass extra flags to

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#13). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#12). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5294 to look at the new patch set (#3). Change subject: KUDU-798 (part 3) Make replica transactions start/abort on the consensus thread

[kudu-CR] WIP: Make sure replica transactions start/abort on the consensus thread

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Make sure replica transactions start/abort on the consensus thread .. WIP: Make sure replica transactions start/abort on the consensus thread In order

[kudu-CR] WIP: Make sure replica transactions start/abort on the consensus thread

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5294 Change subject: WIP: Make sure replica transactions start/abort on the consensus thread .. WIP: Make sure replica transactions

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#11). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#10). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations .. KUDU-1770 [c++ client] propagate timestamp for write operations Updated the

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#9). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] KUDU-1770 [i-tests] test for timestamp propagation with write ops

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1770 [i-tests] test for timestamp propagation with write ops .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5268

[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5269 To

[kudu-CR] KUDU-1770 [i-tests] test for timestamp propagation with write ops

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1770 [i-tests] test for timestamp propagation with write ops .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5268

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1770 [c++ client] propagate timestamp for write operations

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1770 [c++ client] propagate timestamp for write operations .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5269 To

[kudu-CR] KUDU-420 [i-tests] scan token timestamp propagation test

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-420 [i-tests] scan token timestamp propagation test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5219 To

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#8). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] [c++ client] timestamp propagation via scan tokens

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5220 To unsubscribe,

[kudu-CR] [i-tests] scan token timestamp propagation test

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [i-tests] scan token timestamp propagation test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5219 To unsubscribe,

[kudu-CR] [c++ client] propagate timestamp for write operations

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] propagate timestamp for write operations .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5269 To

[kudu-CR] [i-tests] test for timestamp propagation with write ops

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [i-tests] test for timestamp propagation with write ops .. Patch Set 1: (1 comment)

[kudu-CR] [i-tests] test for timestamp propagation with write ops

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [i-tests] test for timestamp propagation with write ops .. Patch Set 1: Mike: We've been pushing the fix and the test separately for this stuff. I think

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to tablet_history_gc-itest This adds Reinserts as a new operation to

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Don't output unobservable rows from the MemRowset .. Don't output unobservable rows from the MemRowset In some rare cases we might have a row

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-itest This adds a new operation to fuzz-itest: snapshot scans at a timestamp.

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. KUDU-237 (part 2) - Add support for REINSERT in delta files This patch goes the

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#7). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#6). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 17: Code-Review+1 (5 comments) just a rebase, keeping todd's +1

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 24: Code-Review+2 just a rebase keeping todd's +2 -- To view, visit

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#16). Change subject: Don't output unobservable rows from the MemRowset

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#5). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#23). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#15). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Support safe time advancement on replicas in the absense of writes .. Patch Set 3: (4 comments)

[kudu-CR] WIP: Support safe time advancement on replicas in the absense of writes

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#4). Change subject: WIP: Support safe time advancement on replicas in the absense of writes

[kudu-CR] [i-tests] scan token timestamp propagation test

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [i-tests] scan token timestamp propagation test .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#22). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 12: (1 comment)

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#14). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 20: (5 comments)

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#21). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#14). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 12: (15 comments) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#20). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 19: (10 comments)

[kudu-CR] [i-tests] scan token timestamp propagation test

2016-11-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [i-tests] scan token timestamp propagation test .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#13). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#12). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] [c++ client] timestamp propagation via scan tokens

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens .. Patch Set 2: Code-Review+2 Would like your thoughts on my q, but I don't think that should be an

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc .. Patch Set 10: (7 comments)

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#11). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] [java] KUDU-1679 Propagate timestamps for scans

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] KUDU-1679 Propagate timestamps for scans .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5248 To unsubscribe,

[kudu-CR] KUDU-798 (part 1) Unify leader/follower mvcc behavior

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5055/11/src/kudu/tablet/tablet.h

[kudu-CR] KUDU-798 (part 1) Unify leader/follower mvcc behavior

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#12). Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior ..

[kudu-CR] KUDU-798 (part 1) Unify leader/follower mvcc behavior

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/5055/9/src/kudu/tablet/tablet.h

[kudu-CR] KUDU-798 (part 1) Unify leader/follower mvcc behavior

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#11). Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior ..

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#13). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to

[kudu-CR] Fix bitshuffle arch-wrapper code to build on OSX

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Fix bitshuffle arch-wrapper code to build on OSX .. Fix bitshuffle arch-wrapper code to build on OSX OSX doesn't have objcopy, so we don't have

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe,

[kudu-CR] [java] KUDU-1679 Propagate timestamps for scans

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] KUDU-1679 Propagate timestamps for scans .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5248 To unsubscribe,

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc File

[kudu-CR] Fix bitshuffle arch-wrapper code to build on OSX

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix bitshuffle arch-wrapper code to build on OSX .. Patch Set 1: Code-Review+2 Verified+1 Tested this fix on mac osx (will still wait for jenkins to

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 12: btw fuzz-itest does a really good job at finding these corner cases. having gc there

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#12). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 11: regarding the case you suggested, yeah, v1 would be chosen to be the most recent one

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/11/src/kudu/tablet/compaction.cc

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/11/src/kudu/tablet/compaction.cc

[kudu-CR] [NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager .. Patch Set 2: nah, this is broken without the rest. will push soon. -- To view,

[kudu-CR] [NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#2). Change subject: [NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager

[kudu-CR] [i-tests] scan token timestamp propagation test

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [i-tests] scan token timestamp propagation test .. Patch Set 1: (7 comments)

[kudu-CR] [java] KUDU-1679 Propagate timestamps for scans

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] KUDU-1679 Propagate timestamps for scans .. Patch Set 1: (1 comment)

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 7: (2 comments)

[kudu-CR] [java] KUDU-1679 Propagate timestamps for scans

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] KUDU-1679 Propagate timestamps for scans .. Patch Set 1: (4 comments) add a test?

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#10). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#11). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Remove/downgrade a few very verbose useless log statements .. Remove/downgrade a few very verbose useless log statements When running tests that

[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5215 to look at the new patch set (#2). Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5226 to look at the new patch set (#4). Change subject: Remove/downgrade a few very verbose useless log statements ..

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches .. Reduce the number of batches in FuzzTest::TestFuzzHugeBatches While running

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5226 to look at the new patch set (#3). Change subject: Remove/downgrade a few very verbose useless log statements ..

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-28 Thread David Ribeiro Alves (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5223 to look at the new patch set (#3). Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

[kudu-CR] c++11'ize CompactionInput descedants with 'override'

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: c++11'ize CompactionInput descedants with 'override' .. c++11'ize CompactionInput descedants with 'override' Change-Id:

[kudu-CR] Change TabletHistoryGCITest back to manual flushes

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Change TabletHistoryGCITest back to manual flushes .. Change TabletHistoryGCITest back to manual flushes Mike found a potential problem with

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches .. Patch Set 2: (1 comment)

[kudu-CR] Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md .. Finish incomplete sentence in

[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test

2016-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Allow to skip the scan part of full_stack-insert-scan-test .. Allow to skip the scan part of full_stack-insert-scan-test This test is good to

[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test

2016-11-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5233 to look at the new patch set (#2). Change subject: Allow to skip the scan part of full_stack-insert-scan-test ..

[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test

2016-11-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to skip the scan part of full_stack-insert-scan-test .. Patch Set 2: (2 comments)

[kudu-CR] Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md

2016-11-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md .. Patch Set 2: (1 comment)

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove/downgrade a few very verbose useless log statements .. Patch Set 2: are these useful in your opinion? i know they can be reduced that way but why

<    7   8   9   10   11   12   13   14   15   16   >