[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5223 to look at the new patch set (#2). Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches ..

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches .. Patch Set 1: What I mention in the commit message is that I measured this in asan. my

[kudu-CR] KUDU-798 (part 3) Remove the clock from MvccManager

2016-11-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 3) Remove the clock from MvccManager .. Patch Set 1: hum turns out this is a bad idea without the rest of the safe time advancement stuff.

[kudu-CR] KUDU-798 (part 3) Remove the clock from MvccManager

2016-11-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5240 Change subject: KUDU-798 (part 3) Remove the clock from MvccManager .. KUDU-798 (part 3) Remove the clock from MvccManager All

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-27 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#9). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-26 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#8). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-26 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#7). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc .. Patch Set 5: (25 comments) http://gerrit.cloudera.org:8080/#/c/5057/5//COMMIT_MSG

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5056 To unsubscribe, visit

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

2016-11-26 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#6). Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 1) Unify leader/follower mvcc behavior

2016-11-26 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#8). Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior ..

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .. Patch Set 3: (2 comments) thanks for the input all. I've swapped this for a

[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#7). Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior ..

[kudu-CR] [WIP] Design doc for repeatable reads

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5229 Change subject: [WIP] Design doc for repeatable reads .. [WIP] Design doc for repeatable reads This is not really a design doc,

[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/5055/6//COMMIT_MSG Commit

[kudu-CR] Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5228 Change subject: Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md .. Finish incomplete sentence in

[kudu-CR] c++11'ize CompactionInput descedants with 'override'

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5227 Change subject: c++11'ize CompactionInput descedants with 'override' .. c++11'ize CompactionInput descedants with 'override'

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5226 Change subject: Remove/downgrade a few very verbose useless log statements .. Remove/downgrade a few very verbose useless log

[kudu-CR] Change TabletHistoryGCITest back to manual flushes

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5224 Change subject: Change TabletHistoryGCITest back to manual flushes .. Change TabletHistoryGCITest back to manual flushes Mike

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add Reinserts to tablet_history_gc-itest .. Patch Set 10: (16 comments) http://gerrit.cloudera.org:8080/#/c/4997/10//COMMIT_MSG Commit Message: Line 17:

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4997 to look at the new patch set (#11). Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 10: (10 comments) http://gerrit.cloudera.org:8080/#/c/4996/10//COMMIT_MSG Commit Message: PS10, Line 12:

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#11). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5223 Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches .. Reduce the number of batches in

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#17). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 16: (7 comments)

[kudu-CR] [c++ client] timestamp propagation via scan tokens

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens .. Patch Set 1: I meant making sure that we're not breaking anything with this change stand-alone. We

[kudu-CR] [c++ client] timestamp propagation via scan tokens

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens .. Patch Set 1: did you test that these tokens are cross-client compatible? -- To view, visit

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 6: (1 comment)

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe,

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#16). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#15). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 14: (5 comments)

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 14: (5 comments)

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#14). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5215 Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString .. Make DebugDumpCompactionInput use

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 13: (29 comments)

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#13). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] [c++] Reuse snapshot scan timestamp across tablets

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [c++] Reuse snapshot scan timestamp across tablets .. [c++] Reuse snapshot scan timestamp across tablets KUDU-1189 On reads at a snapshot that

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1189 integration test for reusing snap timestamp .. KUDU-1189 integration test for reusing snap timestamp Added a test for reusing snapshot

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 5: (3 comments)

[kudu-CR] [c++] Reuse snapshot scan timestamp across tablets

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++] Reuse snapshot scan timestamp across tablets .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5143 To unsubscribe,

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 integration test for reusing snap timestamp .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5163 To

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 2: (4 comments) can you please address the tidy bot nits? I know most

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 integration test for reusing snap timestamp .. Patch Set 4: Does this need to be rebased on top of the patch that unbroke the build? -- To

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5143/5//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5143/5//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 integration test for reusing snap timestamp .. Patch Set 3: (1 comment)

[kudu-CR] [scan] test for reusing snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [scan] test for reusing snapshot timestamp when not set .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 1: I'm not sure what kind of test you're planning but in the past, for these types of

[kudu-CR] [scan] test for reusing snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [scan] test for reusing snapshot timestamp when not set .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5163/2//COMMIT_MSG Commit

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 5: (2 comments) any way we can add simple unit test for this?

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Check that the set raw snapshot timestamp is > 0 .. Check that the set raw snapshot timestamp is > 0 Commit 06bb52d changed the default (invalid)

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: not sure, nothing changed in the java client, but having the c++ not allow scans at 0

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message:

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Don't do UNDO garbage collection until after the REDO->UNDO

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Make

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 13: Verified+1 unrelated flake

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4928 to look at the new patch set (#12). Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 10: (2 comments)

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 11: Code-Review+2 again, keeping the

[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5055/6//COMMIT_MSG Commit

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: fuzz-itest used to create snapshots at timestamp 0, which previously were silently

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#9). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/6//COMMIT_MSG Commit Message:

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#8). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4993 to look at the new patch set (#7). Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 16: (4 comments)

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#17). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5155 Change subject: Check that the set raw snapshot timestamp is > 0 .. Check that the set raw snapshot timestamp is > 0 Commit

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4997 to look at the new patch set (#10). Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/4996/8//COMMIT_MSG Commit Message: Line 23: WIPish:

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 6: Verified+1 unrelated flake DebugUtilTest.TestSignalStackTrace -- To view, visit

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .. Patch Set 3: (1 comment)

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#9). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-itest This adds a new operation to fuzz-itest: snapshot scans at timestamp. When generating

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#6). Change subject: Don't output unobservable rows from the MemRowset .. Don't

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 10: Code-Review+2 just a rebase

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#16). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4928 to look at the new patch set (#10). Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4993 to look at the new patch set (#6). Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 15: (6 comments)

[kudu-CR] KUDU-1189 if not set, use timestamp from first server

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 if not set, use timestamp from first server .. Patch Set 3: (33 comments) http://gerrit.cloudera.org:8080/#/c/5143/3//COMMIT_MSG Commit

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1679 Propagate timestamps for scans .. KUDU-1679 Propagate timestamps for scans Added the 'propagated_timestamp' field into the

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5099 To unsubscribe, visit

[kudu-CR] [integration tests] added scan consistency test

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [integration tests] added scan consistency test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5084 To unsubscribe,

[kudu-CR] [integration tests] added scan consistency test

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [integration tests] added scan consistency test .. Patch Set 4: (1 comment)

[kudu-CR] WIP: KUDU-1189 if not set, use timestamp from first server

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1189 if not set, use timestamp from first server .. Patch Set 1: (3 comments)

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Patch Set 5: Code-Review+2 lgtm, since the tidy bot is nt your fault I'm merging this. -- To view,

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. [Timestamp] use 'operator<' instead of ComesBefore Added more syntactic sugar, now for the

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Patch Set 3: (4 comments) lgtm, but please remove the CompactionInputRow stuff

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 5: Could you put this patch after the consistency itest patch in the git history and enable that

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5099/4/src/kudu/client/scan_configuration.h File

[kudu-CR] [integration tests] added scan consistency test

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [integration tests] added scan consistency test .. Patch Set 2: (8 comments)

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Fix list rendering of the last weekly update post .. Fix list rendering of the last weekly update post The sublist after "Noteworthy

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix list rendering of the last weekly update post .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5131 To unsubscribe, visit

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Fix list rendering of the last weekly update post .. Fix list rendering of the last weekly update post The sublist after "Noteworthy features/improvements"

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5131 Change subject: Fix list rendering of the last weekly update post .. Fix list rendering of the last weekly update post The

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 1: (1 comment) would it be possible to split this patch into several

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/5099/4/python/kudu/tests/test_scanner.py File

<    8   9   10   11   12   13   14   15   16   17   >