[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-12 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#10). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/1709

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/17097

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-12 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#9). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612: acquire and release partition lock

2021-03-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17159 ) Change subject: KUDU-2612: acquire and release partition lock .. Patch Set 4: (11 comments) Addressed partial comments, will try to address

[kudu-CR] KUDU-2612: acquire and release partition lock

2021-03-12 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17159 to look at the new patch set (#4). Change subject: KUDU-2612: acquire and release partition lock .

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#8). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#7). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/17097

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/17097/

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/17097/

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/17097

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-11 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#6). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612: acquire and release partition lock

2021-03-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17159 ) Change subject: KUDU-2612: acquire and release partition lock .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17159/1/src/k

[kudu-CR] KUDU-2612: acquire and release partition lock

2021-03-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17159 ) Change subject: KUDU-2612: acquire and release partition lock .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/17159/1//COM

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17097

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-03-10 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#5). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612: acquire and release partition lock

2021-03-10 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17159 to look at the new patch set (#3). Change subject: KUDU-2612: acquire and release partition lock .

[kudu-CR] (wip) KUDU-2612: acquire and release PartitionLock

2021-03-09 Thread Hao Hao (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17159 to look at the new patch set (#2). Change subject: (wip) KUDU-2612: acquire and release PartitionLock ...

[kudu-CR] (wip) KUDU-2612: acquire and release PartitionLock

2021-03-08 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17159 Change subject: (wip) KUDU-2612: acquire and release PartitionLock .. (wip) KUDU-2612: acquire and release PartitionLock This patch introduce

[kudu-CR] [java] KUDU-3213: try at different server on TABLET NOT RUNNING

2021-03-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17124 ) Change subject: [java] KUDU-3213: try at different server on TABLET_NOT_RUNNING .. Patch Set 4: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [client-test] more robust TestRetrieveAuthzTokenInParallel

2021-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17128 ) Change subject: [client-test] more robust TestRetrieveAuthzTokenInParallel .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [java] KUDU-3213: try at different server on TABLET NOT RUNNING

2021-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17124 ) Change subject: [java] KUDU-3213: try at different server on TABLET_NOT_RUNNING .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.clo

[kudu-CR] k8s: minor updates to the StatefulSet

2021-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17098 ) Change subject: k8s: minor updates to the StatefulSet .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17098

[kudu-CR] test: add more natural test for KUDU-2233

2021-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17114 ) Change subject: test: add more natural test for KUDU-2233 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/171

[kudu-CR] KUDU-2612: don't return NOT FOUND when BEGIN TXN has not yet run

2021-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17127 ) Change subject: KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[kudu-CR] KUDU-2612: allow aborting after beginning to commit

2021-02-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17022 ) Change subject: KUDU-2612: allow aborting after beginning to commit .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17022/

[kudu-CR] tablet: allow interleaving of row liveness between compaction input rows

2021-02-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16752 ) Change subject: tablet: allow interleaving of row liveness between compaction input rows .. Patch Set 8: Code-Review+2 (1 comment) http://

[kudu-CR] test: add more natural test for KUDU-2233

2021-02-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17114 ) Change subject: test: add more natural test for KUDU-2233 .. Patch Set 2: Code-Review+1 (1 comment) LGTM, thanks a lot for providing this p

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-02-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 ) Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. Patch Set 2: (23 comments) http://gerrit.cloudera.org:8080/#/c/1709

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-02-23 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#3). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17037 ) Change subject: KUDU-2612 tablet servers automatically register txn participants .. Patch Set 9: Code-Review+1 (1 comment) Not sure if the

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-02-20 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17097 to look at the new patch set (#2). Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock ..

[kudu-CR] KUDU-2612: add PartitionLock and ScopedPartitionLock

2021-02-20 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17097 Change subject: KUDU-2612: add PartitionLock and ScopedPartitionLock .. KUDU-2612: add PartitionLock and ScopedPartitionLock This patch intro

[kudu-CR] KUDU-2612 tablet servers automatically register txn participants

2021-02-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17037 ) Change subject: KUDU-2612 tablet servers automatically register txn participants .. Patch Set 6: (7 comments) Just a first pass through. h

[kudu-CR] KUDU-2612: make BeginCommit return OK if already committed

2021-02-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17073 ) Change subject: KUDU-2612: make BeginCommit return OK if already committed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17017 ) Change subject: KUDU-2612: add background task to abort transaction participants .. Patch Set 8: Code-Review+2 (2 comments) http://gerrit.c

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17017 ) Change subject: KUDU-2612: add background task to abort transaction participants .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:80

[kudu-CR] [util] remove AutoReleasePool and cleanup related code

2021-02-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 ) Change subject: [util] remove AutoReleasePool and cleanup related code .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR] [master] turn off client location assignment by default

2021-02-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 3: Code-Review+1 Looks good to me, but I am not sure if

[kudu-CR] [master] turn off client location assignment by default

2021-02-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/170

[kudu-CR] [util] remove AutoReleasePool and cleanup related code

2021-02-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 ) Change subject: [util] remove AutoReleasePool and cleanup related code .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org

[kudu-CR] [master] turn off client location assignment by default

2021-02-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/170

[kudu-CR] [master] turn off client location assignment by default

2021-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/170

[kudu-CR] txn commit-itest: reduce runtime of TestCommitWhileDeletingTxnStatusManager

2021-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17033 ) Change subject: txn_commit-itest: reduce runtime of TestCommitWhileDeletingTxnStatusManager .. Patch Set 1: Code-Review+2 -- To view, visi

[kudu-CR] rpc: reduce logging when server is shutting down

2021-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17032 ) Change subject: rpc: reduce logging when server is shutting down .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] txn commit-itest: deflake TestCommitTasksReloadOnLeadershipChange

2021-02-05 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17031 ) Change subject: txn_commit-itest: deflake TestCommitTasksReloadOnLeadershipChange .. txn_commit-itest: deflake TestCommitTasksReload

[kudu-CR] txn commit-itest: deflake TestCommitTasksReloadOnLeadershipChange

2021-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17031 ) Change subject: txn_commit-itest: deflake TestCommitTasksReloadOnLeadershipChange .. Patch Set 1: Code-Review+2 -- To view, visit http://g

[kudu-CR] KUDU-2612: background task to commit transaction

2021-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 ) Change subject: KUDU-2612: background task to commit transaction .. Patch Set 16: Code-Review+2 (3 comments) Looks good to me. I didn't get

[kudu-CR] KUDU-2612: background task to commit transaction

2021-02-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 ) Change subject: KUDU-2612: background task to commit transaction .. Patch Set 14: (9 comments) http://gerrit.cloudera.org:8080/#/c/16952/14

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17021 ) Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances .. Patch Set 4: > Patch Set 3: Code-Review+2

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-03 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17021 ) Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances .. Patch Set 3: Verified+1 Unrelated flaky f

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-03 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-03 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17021 ) Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances .. Patch Set 3: (2 comments) http://gerrit.

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-03 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17021 to look at the new patch set (#3). Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances ..

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-03 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17021 to look at the new patch set (#2). Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances ..

[kudu-CR] [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

2021-02-03 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17021 Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances .. [test] enable TxnStatusManagerITest.TxnKeep

[kudu-CR] KUDU-2612: follow up of commit c033487

2021-02-02 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17013 ) Change subject: KUDU-2612: follow up of commit c033487 .. KUDU-2612: follow up of commit c033487 This patch address leftover comment

[kudu-CR] KUDU-2612: follow up of commit c033487

2021-02-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17013 ) Change subject: KUDU-2612: follow up of commit c033487 .. Patch Set 3: Code-Review+2 Patch Set 2: Code-Review+2 > > Yes, sure: please feel f

[kudu-CR] KUDU-2612: follow up of commit c033487

2021-02-02 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17013 to look at the new patch set (#3). Change subject: KUDU-2612: follow up of commit c033487 .. KUDU-26

[kudu-CR] KUDU-2612: follow up of commit c033487

2021-02-01 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17013 to look at the new patch set (#2). Change subject: KUDU-2612: follow up of commit c033487 .. KUDU-26

[kudu-CR] KUDU-2612: follow up of commit c033487

2021-02-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17013 ) Change subject: KUDU-2612: follow up of commit c033487 .. Patch Set 1: (1 comment) > Patch Set 1: Code-Review+1 > > (1 comment) > > Thank y

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-02-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 16: (3 comments) http://gerrit.cloud

[kudu-CR] KUDU-2612: follow up of commit c033487

2021-02-01 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17013 Change subject: KUDU-2612: follow up of commit c033487 .. KUDU-2612: follow up of commit c033487 This patch address leftover comments for com

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. KUDU-2612: restrict TxnStatusManager cal

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 15: (1 comment) http://gerrit.cloude

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 15: (1 comment) http://gerrit.cloude

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 15: Verified+1 Unrelated org.apache.k

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 15: (2 comments) http://gerrit.cloud

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#15). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 14: (4 comments) http://gerrit.cloud

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-30 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#14). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 13: Verified+1 Unrelated flaky test E

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-28 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#13). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 12: (10 comments) http://gerrit.clou

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-28 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#12). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR](gh-pages) Fix 1.14.0 blog post

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17007 ) Change subject: Fix 1.14.0 blog post .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17007 To unsubscribe,

[kudu-CR](gh-pages) Update website for 1.14.0 release

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16990 ) Change subject: Update website for 1.14.0 release .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16990 To

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 ) Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 ) Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/16974/4/s

[kudu-CR](gh-pages) Update website for 1.14.0 release

2021-01-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16990 ) Change subject: Update website for 1.14.0 release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16990 To

[kudu-CR] KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory

2021-01-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16991 ) Change subject: KUDU-3237 fix MaintenanceManagerTest.TestCompletedOpsHistory .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloude

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 ) Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[kudu-CR] KUDU-2612: add a TxnSystemClient to the tservers

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 ) Change subject: KUDU-2612: add a TxnSystemClient to the tservers .. Patch Set 4: (7 comments) Overall looks good to me, just some nits. Tha

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for Java client

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 ) Change subject: KUDU-2612 keep-alive txn heartbeating for Java client .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org

[kudu-CR] KUDU-3239: [build] Disable errorprone on Java 11

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16983 ) Change subject: KUDU-3239: [build] Disable errorprone on Java 11 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-2612 Java client transaction implementation

2021-01-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 ) Change subject: KUDU-2612 Java client transaction implementation .. Patch Set 8: Code-Review+1 (2 comments) Overall looks good to me, thank

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 11: Verified+1 TSAN build failure doe

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-19 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#11). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] wip KUDU-2612: background task to commit transaction

2021-01-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 ) Change subject: wip KUDU-2612: background task to commit transaction .. Patch Set 1: (3 comments) Just a quick walk through, haven't looked

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 9: (7 comments) > Patch Set 9: > > (

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#10). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 8: (3 comments) http://gerrit.cloude

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#9). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 8: (1 comment) http://gerrit.clouder

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

  1   2   3   4   5   6   7   8   9   10   >