[kudu-CR] WIP KUDU-2612 keep-alive txn heartbeating for C++ client

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 ) Change subject: WIP KUDU-2612 keep-alive txn heartbeating for C++ client .. Patch Set 2: I like that the heartbeating is abstracted fr

[kudu-CR] [docker] Update the Impala quickstart image to 3.4

2020-05-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15842 ) Change subject: [docker] Update the Impala quickstart image to 3.4 .. Patch Set 1: Code-Review+1 LGTM. I just looked at the build step

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 2: (1 comment) It looks like the other patch has an older version

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, zhaoren...@hotmail.com, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15557 to look at the new patch set (#3). Change subject: gutil: bump up linux-syscall-support.h ...

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15557/1//COMM

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, zhaoren...@hotmail.com, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15557 to look at the new patch set (#2). Change subject: gutil: bump up linux-syscall-support.h ...

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15557 ) Change subject: gutil: bump up linux-syscall-support.h .. Patch Set 1: Please ignore for now, I'm going to look at the failures -- T

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15557 Change subject: gutil: bump up linux-syscall-support.h .. gutil: bump up linux-syscall-support.h Bump up linux-syscall-support.h to new

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. KUDU-3050: recover from corrupt kerberos ccache This handle

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-11 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15394 to look at the new patch set (#6). Change subject: KUDU-3050: recover from corrupt kerberos ccache

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: (8 comments) Thanks for your help with the memory lea

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15394 to look at the new patch set (#5). Change subject: KUDU-3050: recover from corrupt kerberos ccache

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: Might be https://krbdev.mit.edu/rt/Ticket/Display.html

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: After installing libkrb5-dbg i get Direct leak of 24 b

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: I'm still hitting a LSAN error that I need to debug. I

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15394

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: (10 comments) Thanks for the feedback, I reworked a l

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15394 to look at the new patch set (#4). Change subject: KUDU-3050: recover from corrupt kerberos ccache ...

[kudu-CR] WIP - KUDU-3050: recover from corrupt kerberos ccache

2020-03-09 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15394 to look at the new patch set (#3). Change subject: WIP - KUDU-3050: recover from corrupt kerberos ccache .

[kudu-CR] WIP - KUDU-3050: recover from corrupt kerberos ccache

2020-03-09 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15394 to look at the new patch set (#2). Change subject: WIP - KUDU-3050: recover from corrupt kerberos ccache .

[kudu-CR] WIP - KUDU-3050: recover from corrupt kerberos ccache

2020-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15394 Change subject: WIP - KUDU-3050: recover from corrupt kerberos ccache .. WIP - KUDU-3050: recover from corrupt kerberos ccache Also add

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15197 ) Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded .. KUDU-2996: trace when rpc_duration_too_long_ms excee

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15197 to look at the new patch set (#4). Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded ..

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15197 ) Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15197 ) Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15197 ) Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded .. Patch Set 1: (1 comment) Also fixed the IWYU error http:/

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15197 to look at the new patch set (#3). Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded ..

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15197 to look at the new patch set (#2). Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded ..

[kudu-CR] KUDU-2996: trace when rpc duration too long ms exceeded

2020-02-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15197 Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded .. KUDU-2996: trace when rpc_duration_too_long_ms exceeded Chan

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14745/5/sr

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14745/2/src

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14745/2/src

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14745/1//CO

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14745/1//CO

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 10: Are you ok with me submitting? -- To view, visit http://gerr

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/12657/9/src/k

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#10). Change subject: KUDU-2721: support ranges in CPU lists ..

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#9). Change subject: KUDU-2721: support ranges in CPU lists ...

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/12657/8/src/k

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#8). Change subject: KUDU-2721: support ranges in CPU lists ..

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#7). Change subject: KUDU-2721: support ranges in CPU lists ..

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/12657/6/src/k

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-04 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#6). Change subject: KUDU-2721: support ranges in CPU lists .. KUDU-2721: s

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-04 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#5). Change subject: KUDU-2721: support ranges in CPU lists .. KUDU-2721: s

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 5: Attempted to fix IWYU errors -- To view, visit http://gerrit.

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-04 Thread Tim Armstrong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12657 to look at the new patch set (#4). Change subject: KUDU-2721: support ranges in CPU lists .. KUDU-2721: s

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 3: LMK if the hand-rolled parsing code is acceptable. I have mixed

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. KUDU-2721: support ranges in CPU lists Generalise the logic to handle comma-se

[kudu-CR] Support CXXFLAGS

2019-01-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 ) Change subject: Support CXXFLAGS .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt File CMakeLi

[kudu-CR] Support CXXFLAGS

2019-01-07 Thread Tim Armstrong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12162 to look at the new patch set (#3). Change subject: Support CXXFLAGS .. Support CXXFLAGS I ran into a c

[kudu-CR] Support CXXFLAGS

2019-01-04 Thread Tim Armstrong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12162 to look at the new patch set (#2). Change subject: Support CXXFLAGS .. Support CXXFLAGS I ran into a c

[kudu-CR] Support CXXFLAGS

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 ) Change subject: Support CXXFLAGS .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12162/1//COMMIT_MSG Commit Message:

[kudu-CR] Support CXXFLAGS

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12162 Change subject: Support CXXFLAGS .. Support CXXFLAGS I ran into a case when building Kudu in native-toolchain where I want to build Kud