[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-06-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 ) Change subject: KUDU-1457 p1: krpc supports for IPv6 .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-1457 p2: webserver supports for IPv6

2020-06-07 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16048 Change subject: KUDU-1457 p2: webserver supports for IPv6 .. KUDU-1457 p2: webserver supports for IPv6 The squeasel's PR is here:

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-06-05 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15996 to look at the new patch set (#3). Change subject: KUDU-1457 p1: krpc supports for IPv6

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-06-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 ) Change subject: KUDU-1457 p1: krpc supports for IPv6 .. Patch Set 2: I did some tests on a VM box with 1 master + 3 tservers.

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-06-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 ) Change subject: KUDU-1457 p1: krpc supports for IPv6 .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-05-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 ) Change subject: KUDU-1457 p1: krpc supports for IPv6 .. Patch Set 2: > Build Started http://jenkins.kudu.apache.org/job/kudu-gerrit/21755/

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-05-29 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15996 to look at the new patch set (#2). Change subject: KUDU-1457 p1: krpc supports for IPv6 .. KUDU-1457 p1: krpc

[kudu-CR] KUDU-1457: support for IPv6

2020-05-28 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15996 Change subject: KUDU-1457: support for IPv6 .. KUDU-1457: support for IPv6 This patch is intended to support IPv6 by expanding Sockaddr, but

[kudu-CR] KUDU-3007 (2/3): Add atomicops-internals-arm64.h into tree to support atomicops on aarch64

2020-05-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15875 ) Change subject: KUDU-3007 (2/3): Add atomicops-internals-arm64.h into tree to support atomicops on aarch64 .. Patch Set 2: Code-Review+1 >

[kudu-CR] KUDU-3007 (2/3): Add atomicops-internals-arm64.h into tree to support atomicops on aarch64

2020-05-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15875 ) Change subject: KUDU-3007 (2/3): Add atomicops-internals-arm64.h into tree to support atomicops on aarch64 .. Patch Set 2: LGTM :) -- To

[kudu-CR] KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64

2020-05-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15874 ) Change subject: KUDU-3007 (1/3): Import sse2neon.h into tree to Adapt SSE intrinsics on aarch64 .. Patch Set 2: Code-Review+1 LGTM :) --

[kudu-CR] KUDU-3007 (2/3): Add atomicops-internals-arm64.h into tree to support atomicops on aarch64

2020-05-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15875 ) Change subject: KUDU-3007 (2/3): Add atomicops-internals-arm64.h into tree to support atomicops on aarch64 .. Patch Set 1: I find an

[kudu-CR] KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform

2020-05-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform .. Patch Set 19: (3 comments)

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-05-06 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 18: > Could you separate all third-party files imported

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-13 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 13: Code-Review+2 > Leaving open in

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 13: > > In general, the bloom filter

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-06 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 12: (3 comments) Good job, Bankim!

[kudu-CR] KUDU-2986 p3: hide the values while there is old version

2020-02-02 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15071 to look at the new patch set (#3). Change subject: KUDU-2986 p3: hide the values while there is old version

[kudu-CR] KUDU-2986 p3: hide the values while there is old version

2020-02-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/15071 ) Change subject: KUDU-2986 p3: hide the values while there is old version .. Patch Set 2: (17 comments)

[kudu-CR] KUDU-2986 p3: hide the values while there is old version

2020-01-20 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15071 to look at the new patch set (#2). Change subject: KUDU-2986 p3: hide the values while there is old version ..

[kudu-CR] KUDU-2986 p3: hide the values while there is old version

2020-01-20 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15071 Change subject: KUDU-2986 p3: hide the values while there is old version .. KUDU-2986 p3: hide the values while there is old version The old

[kudu-CR] [util] Import Impala's block based BloomFilter

2019-12-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: [util] Import Impala's block based BloomFilter .. Patch Set 9: (4 comments)

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-12-03 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#10). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-12-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 9: (3 comments)

[kudu-CR] tools: support for changing column comment

2019-12-01 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14814 to look at the new patch set (#3). Change subject: tools: support for changing column comment ..

[kudu-CR] tools: support for changing column comment

2019-12-01 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14814 ) Change subject: tools: support for changing column comment .. Patch Set 2: (1 comment)

[kudu-CR] tools: support for changing column comment

2019-12-01 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14814 to look at the new patch set (#2). Change subject: tools: support for changing column comment .. tools: support

[kudu-CR] tool: support for changing column comment

2019-12-01 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14814 Change subject: tool: support for changing column comment .. tool: support for changing column comment Change-Id:

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-12-01 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#9). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-28 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 8: > Build Failed > >

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-28 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#8). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-28 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 7: > Build Failed > >

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-28 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#7). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-28 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 6: (3 comments) Thanks :)

[kudu-CR] tserver: expose the number of round trips for a scanner

2019-11-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 ) Change subject: tserver: expose the number of round trips for a scanner .. Patch Set 3: > Sorry, forgot to mention in my first review, but

[kudu-CR] tserver: expose the number of round trips for a scanner

2019-11-27 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14803 to look at the new patch set (#3). Change subject: tserver: expose the number of round trips for a scanner

[kudu-CR] tserver: expose the number of round trips for a scanner

2019-11-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 ) Change subject: tserver: expose the number of round trips for a scanner .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-26 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#6). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] tserver: expose the number of round trips for a scanner

2019-11-26 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14803 to look at the new patch set (#2). Change subject: tserver: expose the number of round trips for a scanner ..

[kudu-CR] tserver: expose the number of round trips for a scanner

2019-11-26 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14803 Change subject: tserver: expose the number of round trips for a scanner .. tserver: expose the number of round trips for a scanner Change-Id:

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-18 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#5). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2919 p1: trash is supported while dropping tables

2019-11-18 Thread helifu (Code Review)
Hello Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14566 to look at the new patch set (#4). Change subject: KUDU-2919 p1: trash is supported while dropping tables

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

2019-11-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14566 ) Change subject: KUDU-1929 p1: trash is supported while dropping tables .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-18 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#4). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-17 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#3). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14630/4//COMMIT_MSG

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-01 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-01 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#2). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: hide the live row count of table metrics

2019-11-01 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: hide the live row count of table metrics .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2986 p2: hide the live row count of table metrics

2019-10-31 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14601 Change subject: KUDU-2986 p2: hide the live row count of table metrics .. KUDU-2986 p2: hide the live row count of table metrics It's easier

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

2019-10-30 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14566 to look at the new patch set (#3). Change subject: KUDU-1929 p1: trash is supported while dropping tables ..

[kudu-CR] KUDU-2986 p1: adjust the kudu CLI output from 0 to N/A

2019-10-30 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14567 to look at the new patch set (#3). Change subject: KUDU-2986 p1: adjust the kudu CLI output from 0 to N/A

[kudu-CR] KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A

2019-10-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14567 ) Change subject: KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A .. Patch Set 2: (9 comments)

[kudu-CR] KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A

2019-10-29 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14567 to look at the new patch set (#2). Change subject: KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A

[kudu-CR] KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A

2019-10-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14567 ) Change subject: KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A .. Patch Set 1: (1 comment) Do we need to update the

[kudu-CR] KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A

2019-10-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14567 Change subject: KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A .. KUDU-2986 p1: adjust the output of "table statistics"

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

2019-10-29 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14566 to look at the new patch set (#2). Change subject: KUDU-1929 p1: trash is supported while dropping tables ..

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

2019-10-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14566 Change subject: KUDU-1929 p1: trash is supported while dropping tables .. KUDU-1929 p1: trash is supported while dropping tables 1) Add a new

[kudu-CR] [metrics] Hide metric live row count when tablet not support

2019-10-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14507 ) Change subject: [metrics] Hide metric live_row_count when tablet not support .. Patch Set 12: > (1 comment) ^_^ -- To view, visit

[kudu-CR] [metrics] Hide metric live row count when tablet not support

2019-10-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14507 ) Change subject: [metrics] Hide metric live_row_count when tablet not support .. Patch Set 12: (1 comment)

[kudu-CR] [metrics] Hide metric live row count when tablet not support

2019-10-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14507 ) Change subject: [metrics] Hide metric live_row_count when tablet not support .. Patch Set 12: (1 comment)

[kudu-CR] [metrics] Hide metric live row count when tablet not support

2019-10-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14507 ) Change subject: [metrics] Hide metric live_row_count when tablet not support .. Patch Set 12: (1 comment)

[kudu-CR] [metrics] Hide metric live row count when tablet not support

2019-10-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14507 ) Change subject: [metrics] Hide metric live_row_count when tablet not support .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-26 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14302 to look at the new patch set (#6). Change subject: KUDU-2943: fix the WAL/cmeta term disagreement

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-26 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14302 to look at the new patch set (#5). Change subject: KUDU-2943: fix the WAL/cmeta term disagreement

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-26 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14302 to look at the new patch set (#4). Change subject: KUDU-2943: fix the WAL/cmeta term disagreement

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14302 ) Change subject: KUDU-2943: fix the WAL/cmeta term disagreement .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14302 ) Change subject: KUDU-2943: fix the WAL/cmeta term disagreement .. Patch Set 3: > (1 comment) > > Doesn't this regress KUDU-2335? This

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-25 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14302 to look at the new patch set (#3). Change subject: KUDU-2943: fix the WAL/cmeta term disagreement ..

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14302 ) Change subject: KUDU-2943: fix the WAL/cmeta term disagreement .. Patch Set 2: (1 comment) Thanks, Alexey :)

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-25 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14302 to look at the new patch set (#2). Change subject: KUDU-2943: fix the WAL/cmeta term disagreement .. KUDU-2943:

[kudu-CR] KUDU-2943: fix the WAL/cmeta term disagreement

2019-09-25 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14302 Change subject: KUDU-2943: fix the WAL/cmeta term disagreement .. KUDU-2943: fix the WAL/cmeta term disagreement If we step down a leader

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#5). Change subject: [tserver] include ip:port in the tserver name

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 4: (1 comment)

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#4). Change subject: [tserver] include ip:port in the tserver name

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 4: (3 comments)

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-17 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#3). Change subject: [tserver] include ip:port in the tserver name

[kudu-CR] KUDU-2949: fix tablet stats race while ProcessTabletReport

2019-09-17 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14245 Change subject: KUDU-2949: fix tablet stats race while ProcessTabletReport .. KUDU-2949: fix tablet stats race while ProcessTabletReport

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-16 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 ) Change subject: [tserver] include ip:port in the tserver name .. Patch Set 2: > (1 comment) > > The TSAN failure is interesting. It's not

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-16 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14232 to look at the new patch set (#2). Change subject: [tserver] include ip:port in the tserver name .. [tserver]

[kudu-CR] [tserver] include ip:port in the tserver name

2019-09-16 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14232 Change subject: [tserver] include ip:port in the tserver name .. [tserver] include ip:port in the tserver name Change-Id:

[kudu-CR] [www] support column sorting on /tables page

2019-09-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14187 ) Change subject: [www] support column sorting on /tables page .. Patch Set 3: (1 comment)

[kudu-CR] [www] support column sorting on /tables page

2019-09-08 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14187 to look at the new patch set (#3). Change subject: [www] support column sorting on /tables page

[kudu-CR] [www] support column sorting on /tables page

2019-09-08 Thread helifu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14187 to look at the new patch set (#2). Change subject: [www] support column sorting on /tables page

[kudu-CR] [www] support column sorting on /tables page

2019-09-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14187 ) Change subject: [www] support column sorting on /tables page .. Patch Set 1: (6 comments)

[kudu-CR] [www] support column sorting on /tables page

2019-09-06 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14187 Change subject: [www] support column sorting on /tables page .. [www] support column sorting on /tables page Sort the columns of "Table

[kudu-CR] KUDU-2854 short circuit predicates on dictionary-coded columns

2019-09-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13987 ) Change subject: KUDU-2854 short circuit predicates on dictionary-coded columns .. Patch Set 4: This morning on slack, Todd suggested me to

[kudu-CR] KUDU-2854 short circuit predicates on dictionary-coded columns

2019-08-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13987 to look at the new patch set (#4). Change subject: KUDU-2854 short circuit predicates on dictionary-coded columns

[kudu-CR] KUDU-2854 short circuit predicates on dictionary-coded columns

2019-08-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13987 to look at the new patch set (#3). Change subject: KUDU-2854 short circuit predicates on dictionary-coded columns

[kudu-CR] KUDU-2854 short circuit predicates on dictionary-coded columns

2019-08-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13987 ) Change subject: KUDU-2854 short circuit predicates on dictionary-coded columns .. Patch Set 2: Sorry for the late update. > In his commit

[kudu-CR] KUDU-2854 short circuit predicates on dictionary-coded columns

2019-08-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13987 to look at the new patch set (#2). Change subject: KUDU-2854 short circuit predicates on dictionary-coded columns

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 4: (2 comments)

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 2: Code-Review+1 (1 comment) There is a gap between

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-08-12 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#34). Change subject: KUDU-2797 p2: the master aggregates tablet statistics

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-08-12 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797 p2: the master aggregates tablet statistics .. Patch Set 33: (1 comment) ^_^

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-08-11 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#33). Change subject: KUDU-2797 p2: the master aggregates tablet statistics

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-08-11 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#32). Change subject: KUDU-2797 p2: the master aggregates tablet statistics

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-08-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797 p2: the master aggregates tablet statistics .. Patch Set 31: (3 comments)

  1   2   3   4   >