helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 )
Change subject: [metrics] Add metric severity level ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14630/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14630/4//COMMIT_MSG@26 PS4, Line 26: Additionally a configuration flag, `metrics_default_level`, was added with : a default value of `debug` to include all metrics by default but allow users : to configure the default to drastically reduce the metrics ouput. Instead of adding a new gflag to the kudu server to determine the metrics to return, how about adding a new filter from the Web URL? I mean we can config the severity level for the metrics, but it is better to let the client decide which level of metrics they need. -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2019 02:38:31 +0000 Gerrit-HasComments: Yes
