[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 12: Code-Review+2 Propagating +2 from Todd's review to this version (comment updates). -- To view,

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [security] do actual token signing/verification .. [security] do actual token signing/verification Replaced temporary stub sign/verify calls with calls

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#12). Change subject: [security] do actual token signing/verification .. [security] do

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/5812/11/src/kudu/security/token_signing_key.h

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 11: Code-Review+2 (3 comments) Just a couple nits, feel free to commit after fixing. http://gerrit.c

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 11: I think I blew away the workspace that was causing that error (it bit me on a couple builds too)

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 11: Verified+1 Unrelated breakage: 19:15:06 CMake Error at CMakeLists.txt:917 (find_package): 19:15

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#11). Change subject: [security] do actual token signing/verification .. [security] d

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#10). Change subject: [security] do actual token signing/verification .. [security] d

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc Fi

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc File

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#7). Change subject: [security] do actual token signing/verification .. [security] do

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc F

[kudu-CR] [security] do actual token signing/verification

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc File

[kudu-CR] [security] do actual token signing/verification

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5812/6/src/kudu/security/token_signing_key.cc Fil

[kudu-CR] [security] do actual token signing/verification

2017-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#5). Change subject: [security] do actual token signing/verification .. [security] do actual token signing/verification Replaced temporary stub sign/verify calls with calls of actual c

[kudu-CR] [security] do actual token signing/verification

2017-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 4: Verified+1 unrelated breakage: boost_datetime issues -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [security] do actual token signing/verification

2017-01-28 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#3). Change subject: [security] do actual token signing/verification .. [security] do

[kudu-CR] [security] do actual token signing/verification

2017-01-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc Fi

[kudu-CR] [security] do actual token signing/verification

2017-01-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc File

[kudu-CR] [security] do actual token signing/verification

2017-01-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#2). Change subject: [security] do actual token signing/verification .. [security] do