Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/131
Merging to master.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r245124550
--- Diff: server/src/main/scala/org/apache/livy/server/LivyServer.scala ---
@@ -355,6 +355,21 @@ class LivyServer extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r245096875
--- Diff: server/src/main/scala/org/apache/livy/server/LivyServer.scala ---
@@ -355,6 +355,21 @@ class LivyServer extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r244836308
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyThriftServer.scala
---
@@ -138,6 +139,16 @@ class LivyThriftServer
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/133
You still have not filed a bug to explain the problem. See
http://livy.incubator.apache.org/community/.
Jacoco is a little bit flaky. Close the PR and re-open it to re-run the
tests.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243101650
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -195,6 +211,28 @@ def processBypassJob(self, serialized_job):
def addFile(self
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243101498
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -49,6 +49,22 @@
TOP_FRAME_REGEX = re.compile(r'\s*File "".*in ')
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243101945
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -49,6 +49,22 @@
TOP_FRAME_REGEX = re.compile(r'\s*File "".*in ')
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243100790
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -195,6 +211,28 @@ def processBypassJob(self, serialized_job):
def addFile(self
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243101834
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -555,6 +593,7 @@ def main():
sys.stderr = UnicodeDecodingStringIO
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243101587
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -195,6 +211,28 @@ def processBypassJob(self, serialized_job):
def addFile(self
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/119#discussion_r243100751
--- Diff: repl/src/main/resources/fake_shell.py ---
@@ -195,6 +211,28 @@ def processBypassJob(self, serialized_job):
def addFile(self
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/101
Looks fine. The difference between RPC_SERVER_ADDRESS and LAUNCHER_ADDRESS
is not 100% clear to me (it's been a while) but this doesn't seem to make it
worse.
Merging to master.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/133#discussion_r243090357
--- Diff: rsc/src/main/java/org/apache/livy/rsc/RSCConf.java ---
@@ -44,6 +44,7 @@
CLIENT_SHUTDOWN_TIMEOUT("client.shutdown-timeout&q
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/133#discussion_r243090804
--- Diff: repl/src/main/scala/org/apache/livy/repl/Session.scala ---
@@ -356,4 +373,96 @@ class Session(
private def statementIdToJobGroup
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/133#discussion_r243089562
--- Diff: rsc/src/main/java/org/apache/livy/rsc/RSCConf.java ---
@@ -71,6 +72,9 @@
SASL_MECHANISMS("rpc.sasl.mechanisms", &
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/133#discussion_r243088871
--- Diff: repl/src/main/scala/org/apache/livy/repl/Session.scala ---
@@ -70,11 +68,17 @@ class Session(
// Number of statements kept
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/133#discussion_r243091133
--- Diff: repl/src/main/scala/org/apache/livy/repl/Session.scala ---
@@ -356,4 +373,96 @@ class Session(
private def statementIdToJobGroup
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/133#discussion_r243090632
--- Diff: repl/src/main/scala/org/apache/livy/repl/Session.scala ---
@@ -356,4 +373,96 @@ class Session(
private def statementIdToJobGroup
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r243083151
--- Diff:
integration-test/src/thriftserver/main/scala/org/apache/livy/test/framework/ThriftJdbcClient.scala
---
@@ -0,0 +1,51
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r243081744
--- Diff:
integration-test/src/thriftserver/main/scala/org/apache/livy/test/framework/ThriftJdbcClient.scala
---
@@ -0,0 +1,51
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r243084756
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyThriftServer.scala
---
@@ -138,6 +139,16 @@ class LivyThriftServer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/48#discussion_r242757718
--- Diff:
server/src/main/scala/org/apache/livy/server/interactive/InteractiveSession.scala
---
@@ -451,6 +403,64 @@ class InteractiveSession
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/48#discussion_r242757993
--- Diff:
server/src/main/scala/org/apache/livy/sessions/SessionManager.scala ---
@@ -92,13 +94,27 @@ class SessionManager[S <: Session
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/48#discussion_r242757751
--- Diff:
server/src/main/scala/org/apache/livy/server/interactive/InteractiveSession.scala
---
@@ -451,6 +403,64 @@ class InteractiveSession
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/48#discussion_r242758336
--- Diff: server/src/main/scala/org/apache/livy/server/SessionServlet.scala
---
@@ -214,16 +214,23 @@ abstract class SessionServlet[S <: Session
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/131#discussion_r242756706
--- Diff:
thriftserver/integration-test/src/test/scala/org/apache/livy/test/JdbcIT.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/132
Merging to master.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/128
Merging to master.
I can see this not handling 100% of cases (e.g. people setting their own
job group in their jobs), but at least it's a best effort.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/128#discussion_r238459612
--- Diff: rsc/src/test/java/org/apache/livy/rsc/TestSparkClient.java ---
@@ -490,20 +487,72 @@ public void call(LivyClient client) throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/128#discussion_r238384607
--- Diff:
rsc/src/main/java/org/apache/livy/rsc/driver/BypassJobWrapper.java ---
@@ -38,28 +38,50 @@ public BypassJobWrapper(RSCDriver driver, String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/128#discussion_r238386377
--- Diff: rsc/src/test/java/org/apache/livy/rsc/TestSparkClient.java ---
@@ -490,20 +487,72 @@ public void call(LivyClient client) throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/128#discussion_r238386275
--- Diff: rsc/src/test/java/org/apache/livy/rsc/TestSparkClient.java ---
@@ -490,20 +487,72 @@ public void call(LivyClient client) throws Exception
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237315238
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyThriftServer.scala
---
@@ -114,24 +98,56 @@ object LivyThriftServer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237319002
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetTableTypesOperation.scala
---
@@ -0,0 +1,63
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237318955
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetCatalogsOperation.scala
---
@@ -0,0 +1,62
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237318294
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/PlainSaslServer.scala
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237313919
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyCLIService.scala
---
@@ -22,60 +22,57 @@ import java.util
import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237317373
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthFactory.scala
---
@@ -0,0 +1,197 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237316485
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthBridgeServer.scala
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/117#discussion_r237318814
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftHttpServlet.scala
---
@@ -0,0 +1,500 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/128#discussion_r237282583
--- Diff: rsc/src/main/java/org/apache/livy/rsc/driver/JobWrapper.java ---
@@ -39,20 +39,27 @@
private final RSCDriver driver
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/130
Merging to master.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
Another unrelated failure. The intersection of the last test runs did pass
all the combinations, though.
---
GitHub user vanzin reopened a pull request:
https://github.com/apache/incubator-livy/pull/118
[LIVY-503] Separate thrift server session code in separate module.
This change creates a new module ("livy-thriftserver-session") with
the code related to the Thr
Github user vanzin closed the pull request at:
https://github.com/apache/incubator-livy/pull/118
---
GitHub user vanzin reopened a pull request:
https://github.com/apache/incubator-livy/pull/118
[LIVY-503] Separate thrift server session code in separate module.
This change creates a new module ("livy-thriftserver-session") with
the code related to the Thr
Github user vanzin closed the pull request at:
https://github.com/apache/incubator-livy/pull/118
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
Yep, same NPE with master. So not a problem with this patch.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
test failure is unrelated
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
Getting this:
```
Exception in thread "Livy-Thriftserver" java.lang.NoSuchFieldError:
cliService
at
org.apache.livy.thriftserver.LivyThriftS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/118#discussion_r236741064
--- Diff:
thriftserver/session/src/main/java/org/apache/livy/thriftserver/session/ThriftSessionState.java
---
@@ -0,0 +1,126
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
Integration tests run in YARN; that is basically the same thing as running
a "real cluster". But, sure, if you insist, I'll run it on a "real cluster".
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
No but that's what integration tests do, isn't it?
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/128#discussion_r236355512
--- Diff: rsc/src/main/java/org/apache/livy/rsc/driver/JobWrapper.java ---
@@ -39,20 +39,27 @@
private final RSCDriver driver
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/129
Took a look at the surrounding code and this seems fine. I was worried that
`createSession` might be blocking, but it's not.
Merging to master.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/118
ping for a review, otherwise I'll merge this tomorrow-ish.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/121
Merging to master.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/121
Hmm... it might be good to open a Spark bug. Should be easy to create a
repro - basically what you have in the shell session you tried above, but in a
small scala class. (Start session - use
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/121#discussion_r231342733
--- Diff: rsc/src/test/java/org/apache/livy/rsc/TestSparkClient.java ---
@@ -271,7 +275,7 @@ public void call(LivyClient client) throws Exception
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/127
Merging to master. I'll fix the title during merge.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/127
Could you put the bug in the PR title like generally done in other PRs? You
could also make the title shorter by saying "body for error messages" instead
of listing all erro
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/114
Merging to master.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r228309580
--- Diff:
server/src/main/resources/org/apache/livy/server/ui/static/js/all-sessions.js
---
@@ -26,7 +26,7 @@ function loadSessionsTable(sessions
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/124
Livy doesn't ship with Spark, so in the end this doesn't make a whole lot
of difference. But sure, let's test against the latest one at least.
Merging to master.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r227125314
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftJsonServlet.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/122
It is (https://git1-us-west.apache.org/repos/asf?p=incubator-livy.git).
Probably just a sync problem in the ASF infra.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r225716038
--- Diff:
thriftserver/server/src/main/resources/org/apache/livy/server/ui/static/js/thrift-sessions.js
---
@@ -0,0 +1,50
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r225715892
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftJsonServlet.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r225715972
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftJsonServlet.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/122
Merging to master.
---
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/123
Merging.
---
72 matches
Mail list logo
