Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated July 29, 2015, 7:16 a.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated July 29, 2015, 7:18 a.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

2015-07-29 Thread haosdent huang
> On July 28, 2015, 5:58 a.m., Adam B wrote: > > Did you test this with java enabled as well? What about without > > `--with-protobuf=`? All four combinations still need to compile & pass the > > unit tests. > > haosdent huang wrote: > I only run it with --disable-java and --with_protobuf,

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:43 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:44 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36870: Added -> operator for Future.

2015-07-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36870/#review93406 --- Ship it! Ship It! - Michael Park On July 28, 2015, 12:56 a.m., B

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:49 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-29 Thread haosdent huang
> On July 27, 2015, 5:58 p.m., Marco Massenzio wrote: > > thanks for doing this! > > (this may also fix a long-standing issue of mine: > > https://issues.apache.org/jira/browse/MESOS-2337 - could you please take a > > look?) > > > > Only a few minor nits about formatting and stuff, then I thin

Re: Review Request 32961: Allow framework re-registeration to update master http fields.

2015-07-29 Thread Joris Van Remoortere
> On July 27, 2015, 11:38 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 1850 > > > > > > Anand discovered that we shouldn't be calling this in the > > FrameworkErrorMessage case below, where we drop the mes

Re: Review Request 36899: Updated MesosZooKeeperTest to avoid side effects.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36899/#review93420 --- src/tests/mesos.hpp (line 294)

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-07-29 Thread Alexander Rukletsov
> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-07-29 Thread Alexander Rukletsov
> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-07-29 Thread Alexander Rukletsov
> On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1325-1332 > > > > > > Why do we need to recover resources for unreserve? > > Michael Park wrote: > If reserved resources ar

Review Request 36909: Add shutdownNetwork in MesosZooKeeperTest.TearDownTestCase.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- Review request for mesos. Repository: mesos Description --- Add shutdown

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93430 --- src/tests/fetcher_cache_tests.cpp (line 1460)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 1:52 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated July 29, 2015, 11:54 a.m.) Review request for mesos, Alexander Ruklets

Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-07-29 Thread Chris Heller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/ --- Review request for mesos. Repository: mesos Description --- [MESOS-3170]

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93432 --- Please make sure you use hard tabs within our build environment (.am

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Till Toenshoff
> On July 29, 2015, 12:21 p.m., Till Toenshoff wrote: > > src/Makefile.am, line 261 > > > > > > This line looks too long. Seems we actually tolerate this - feel free to drop this issue. - Till --

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93438 --- Ship it! Ship It! - Joerg Schad On July 29, 2015, 11:52 a.m., Ja

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
> On July 29, 2015, 12:21 p.m., Till Toenshoff wrote: > > src/Makefile.am, line 261 > > > > > > This line looks too long. > > Till Toenshoff wrote: > Seems we actually tolerate this - feel free to drop this issu

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 2:59 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review93441 --- include/mesos/mesos.proto (line 399)

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/ --- (Updated July 29, 2015, 1:11 p.m.) Review request for mesos, Bernd Mathiske and

Review Request 36911: Removed unnecessary using directive.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36911/ --- Review request for mesos, Marco Massenzio and Till Toenshoff. Repository: mesos

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93443 --- docs/fetcher-cache-internals.md (line 107)

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-07-29 Thread Chris Heller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/ --- (Updated July 29, 2015, 1:41 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93444 --- Ship it! Ship It! - Bernd Mathiske On July 29, 2015, 6:11 a.m.,

Re: Review Request 36909: Add shutdownNetwork in MesosZooKeeperTest.TearDownTestCase.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:50 p.m.) Review request for mesos. Repository: meso

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:53 p.m.) Review request for mesos. Summary (updated

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:53 p.m.) Review request for mesos. Bugs: MESOS-3168

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93447 --- src/tests/fetcher_cache_tests.cpp (line 1474)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 3:59 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > > > > > const Path& Path::basename() is not marked const (which it probably should), hence we have to itera

Review Request 36912: Fixed Mesos version in getting started docs.

2015-07-29 Thread Ryuichi Okumura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36912/ --- Review request for mesos. Bugs: MESOS-3172 https://issues.apache.org/jira/b

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93445 --- include/mesos/master/quota.hpp (lines 19 - 20)

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > > > > > const Path& > > Jan Schlicht wrote: > Path::basename() is not marked const (which it probably sh

Review Request 36914: Marked Path::basename, Path::dirname const.

2015-07-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36914/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3173 https://issue

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated July 29, 2015, 3:04 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review93456 --- src/master/http.cpp (line 524)

Re: Review Request 36914: Marked Path::basename, Path::dirname const.

2015-07-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36914/#review93461 --- Ship it! Ship It! - Till Toenshoff On July 29, 2015, 2:45 p.m.,

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

2015-07-29 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review93457 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 238) <

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-07-29 Thread Michael Park
> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-07-29 Thread Alexander Rukletsov
> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 29, 2015, 6:34 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
> On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 1474 > > > > > > const Path& > > Jan Schlicht wrote: > Path::basename() is not marked const (which it probably sh

Review Request 36916: Doxygenified a comment in the allocator.proto.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36916/ --- Review request for mesos, Joerg Schad and Till Toenshoff. Repository: mesos D

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93472 --- Patch looks great! Reviews applied: [36909] All tests passed. - M

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated July 29, 2015, 4:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36916: Doxygenified a comment in the allocator.proto.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36916/#review93473 --- Ship it! Ship It! - Joerg Schad On July 29, 2015, 4:58 p.m., Ale

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated July 29, 2015, 5:07 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/ --- (Updated July 29, 2015, 5:08 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 36912: Fixed Mesos version in getting started docs.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36912/#review93474 --- Ship it! Ship It! - haosdent huang On July 29, 2015, 2:11 p.m.,

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-29 Thread Marco Massenzio
> On July 29, 2015, 1:01 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, line 399 > > > > > > `ip` and `port` are required, while `address` is optional. Is it > > intentional / doesn't it introduce a

Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/ --- (Updated July 29, 2015, 5:40 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

2015-07-29 Thread haosdent huang
> On July 28, 2015, 7:46 a.m., Alexander Rojas wrote: > > Thank you for your review. I updated the code, could you reivew it again? - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93482 --- Ship it! Aah. Good catch. Thank you! - Vinod Kone On July 29, 20

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review93481 --- include/mesos/mesos.proto (line 1213)

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
> On July 29, 2015, 5:43 p.m., Vinod Kone wrote: > > Aah. Good catch. Thank you! You are welcome. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93482 ---

Re: Review Request 36816: Support HTTP checks in Mesos health check program

2015-07-29 Thread haosdent huang
> On July 28, 2015, 8:05 a.m., Adam B wrote: > > src/health-check/main.cpp, line 243 > > > > > > Maybe we should add `http.protocol()` in case the user wants https? Or > > `http.ssl` like BenH suggested. Would we ev

Re: Review Request 36816: Support HTTP checks in Mesos health check program

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated July 29, 2015, 6:08 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93496 --- Patch looks great! Reviews applied: [36908] All tests passed. - M

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

2015-07-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93499 --- Looks like this needs a rebase? Wasn't able to get it applied withou

Re: Review Request 36916: Doxygenified a comment in the allocator.proto.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36916/#review93500 --- Patch looks great! Reviews applied: [36916] All tests passed. - M

Review Request 36919: Pulled out call validation.

2015-07-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36919/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos De

Re: Review Request 36919: Pulled out call validation.

2015-07-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36919/ --- (Updated July 29, 2015, 7:43 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 36900: Publish MasterInfo to ZK in JSON format

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36900/#review93374 --- src/master/contender.cpp (line 239)

Re: Review Request 36919: Pulled out call validation.

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36919/#review93504 --- Ship it! nice cleanup! src/master/master.cpp (lines 1697 - 1698)

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/#review93505 --- Ship it! src/tests/master_tests.cpp (line 2170)

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

2015-07-29 Thread Anand Mazumdar
> On July 29, 2015, 7:12 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2128-2159 > > > > > > Any reason you're skipping validation (authorization) of the framework? > > Looks like we should pull out the

Re: Review Request 36900: Publish MasterInfo to ZK in JSON format

2015-07-29 Thread Marco Massenzio
> On July 29, 2015, 7:44 p.m., Vinod Kone wrote: > > Thanks, I have the impression you were looking at an earlier revision, but no matter - the one I'll be uploading in a second will reflect your comments. - Marco --- This is an automa

Review Request 36920: Fixed TearDown order in ZK test.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36920/ --- Review request for mesos, haosdent huang and Vinod Kone. Bugs: MESOS-3168 h

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93509 --- src/tests/mesos.hpp (line 317)

Re: Review Request 36920: Fixed TearDown order in ZK test.

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36920/#review93510 --- Ship it! - Vinod Kone On July 29, 2015, 8:39 p.m., Alexander Rukl

Re: Review Request 36900: Publish MasterInfo to ZK in JSON format

2015-07-29 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36900/ --- (Updated July 29, 2015, 8:42 p.m.) Review request for mesos, Anand Mazumdar, Is

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated July 29, 2015, 8:48 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Marco Massenzio
> On July 29, 2015, 8 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 2170 > > > > > > new line. would you like me to push another revision or will you do this yourself when committing? I'm easy eithe

Re: Review Request 36912: Fixed Mesos version in getting started docs.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36912/#review93513 --- Patch looks great! Reviews applied: [36912] All tests passed. - M

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Marco Massenzio
> On July 29, 2015, 8 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 2170 > > > > > > new line. > > Marco Massenzio wrote: > would you like me to push another revision or will you do this yourself

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/ --- (Updated July 29, 2015, 8:54 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/#review93515 --- forgot to rebase? - Vinod Kone On July 29, 2015, 8:54 p.m., Marco

Re: Review Request 36900: Publish MasterInfo to ZK in JSON format

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36900/#review93516 --- rebase please. - Vinod Kone On July 29, 2015, 8:42 p.m., Marco Ma

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Marco Massenzio
> On July 29, 2015, 8:55 p.m., Vinod Kone wrote: > > forgot to rebase? dang! one sec... - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/#review93515

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-29 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/ --- (Updated July 29, 2015, 9:05 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 36900: Publish MasterInfo to ZK in JSON format

2015-07-29 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36900/ --- (Updated July 29, 2015, 9:07 p.m.) Review request for mesos, Anand Mazumdar, Is

Re: Review Request 36625: Windows: Split up platform specific functions into separate headers.

2015-07-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36625/ --- (Updated July 29, 2015, 3:01 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/#review93520 --- Patch looks great! Reviews applied: [36821] All tests passed. - M

Re: Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.

2015-07-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36822/#review93522 --- Ship it! Ship It! - Benjamin Hindman On July 27, 2015, 8:18 p.m.

Re: Review Request 36920: Fixed TearDown order in ZK test.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36920/#review93525 --- Bad patch! Reviews applied: [36920] Failed command: ./support/appl

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-29 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 29, 2015, 4:11 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-29 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 29, 2015, 4:14 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36625: Windows: Split up platform specific functions into separate headers.

2015-07-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36625/ --- (Updated July 29, 2015, 4:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp)

2015-07-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36783/ --- (Updated July 29, 2015, 4:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36864: Style change: Space after the "..." in variadic templates.

2015-07-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36864/ --- (Updated July 29, 2015, 4:51 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36865: Style change: Space after the "..." in variadic templates.

2015-07-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36865/ --- (Updated July 29, 2015, 4:51 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 36927: Pulled apart authorization and authentication validation for frameworks in the master.

2015-07-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36927/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 36827: Removed and guarded pthread specifics for libevent-openssl.

2015-07-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36827/#review93529 --- Ship it! Ship It! - Benjamin Hindman On July 27, 2015, 9:14 p.m.

Re: Review Request 36823: Used std::thread instead of pthread for cgroups tests.

2015-07-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36823/#review93527 --- Ship it! src/tests/containerizer/cgroups_tests.cpp (line 814)

  1   2   >