Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/#review96308 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:48 p.m., Jos

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96309 --- src/master/maintenance.cpp (line 121)

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/#review96313 --- src/master/maintenance.cpp (line 153)

Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/#review96315 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 7:09 p.m., Jos

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/#review96316 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m., Jor

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/#review96317 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m., Jor

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review96323 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:12 a.m., Jor

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96331 --- 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp (lines

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 --- 3rdparty/libprocess/include/process/pid.hpp (lines 154 - 155)

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

> On Aug. 25, 2015, 2:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 > > > > > > Given that there's no specified iteration order of a multihashmap, I > >

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96333 --- This is slightly out of date now with the modularized authorizer. Co

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 3:15 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 25, 2015, 3:16 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 25, 2015, 2:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 > > > > > > I think this might be the right solution for the scope of the changes > > we're trying t

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96336 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All test

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 24, 2015, 5:57 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 939 > > > > > > Can you please elaborate more for why "in maintaince purpose, this > > field is always empty"? Why cannot an ope

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 25, 2015, 8:24 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

> On Aug. 24, 2015, 11:04 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 111 > > > > > > Can you please show a case why end user want to hold more agents on a > > single machine? This may cause resour

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

> On Aug. 25, 2015, 12:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 > > > > > > Given that there's no specified iteration order of a multihashmap, I > >

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 25, 2015, 12:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 > > > > > > I think this might be the right solution for the scope of the changes > > we're trying

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 6:02 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96348 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 4:02 p.m., Ja

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 25, 2015, 9:10 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

> On Aug. 25, 2015, 1:36 a.m., Guangya Liu wrote: > > src/master/maintenance.cpp, line 121 > > > > > > What does strict means here? I see it was not used This is explained in the previous review: https://reviews.ap

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

> On Aug. 25, 2015, 2:11 a.m., Guangya Liu wrote: > > src/master/maintenance.cpp, line 153 > > > > > > Not quite under what does the paramter "strict" means here? Seems it > > was not used. See my comment: https://

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

> On Aug. 25, 2015, 12:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 > > > > > > Given that there's no specified iteration order of a multihashmap, I > >

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96354 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 1:15 p.m., Ja

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96355 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 1:16 p.m., Ja

Re: Review Request 36404: Added support for peek() to process::io

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96342 --- 3rdparty/libprocess/include/process/io.hpp (line 145)

Re: Review Request 36404: Added support for peek() to process::io

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96356 --- 3rdparty/libprocess/src/io.cpp (lines 36 - 37)

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 25, 2015, 4:40 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96359 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:33 p.m., Jos

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 25, 2015, 10:03 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/ --- (Updated Aug. 25, 2015, 10:03 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/ --- (Updated Aug. 25, 2015, 10:03 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96360 --- src/docker/docker.hpp (line 44)

Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/ --- (Updated Aug. 25, 2015, 10:07 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 25, 2015, 5:05 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 102 > > > > > > Also does this mean if a user put in tcp:/// we're just padding > > unix:///? > > I think it's safe to assume we

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/#review96365 --- After the TimeSpec change: src/tests/master_maintenance_tests.cpp

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96366 --- include/mesos/mesos.proto (line 914)

Review Request 37747: Introduced bind-mount based provisioner Backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/ --- Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone. Bugs

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96368 --- src/master/maintenance.cpp (line 121)

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96369 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 5:03 p.m., Jos

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review96370 --- After the TimeSpec change: src/master/master.cpp (lines 4139 - 414

Re: Review Request 37582: Maintenance Primitives: Add test for the hierarchical DRF allocator sending inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37582/ --- (Updated Aug. 25, 2015, 10:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review96375 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Jor

Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37281/#review96381 --- I think that this can be abandoned, as https://reviews.apache.org/r

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96382 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Jor

Re: Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96372 --- Ship it! src/slave/containerizer/provisioners/appc/paths.hpp (line

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review96386 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Jor

Re: Review Request 37722: Added definitions of container rootfs directories.

> On Aug. 24, 2015, 5:20 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/appc/paths.hpp, line 55 > > > > > > Suggestion: It might make sense to nest one more directory "rootfs" so > > you can add m

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

> On Aug. 25, 2015, 2:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 > > > > > > Given that there's no specified iteration order of a multihashmap, I > >

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/#review96392 --- Patch looks great! Reviews applied: [37722, 37747] All tests passe

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review96393 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Jor

Re: Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- (Updated Aug. 25, 2015, 11:41 a.m.) Review request for mesos, Lily Chen, Chi Zh

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 25, 2015, 6:47 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 6:48 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 25, 2015, 6:48 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 25, 2015, 6:49 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 25, 2015, 6:49 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 25, 2015, 6:50 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 6:51 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37582: Maintenance Primitives: Add test for the hierarchical DRF allocator sending inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37582/#review96397 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 5:39 p.m., Jos

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/#review96398 --- Patch looks great! Reviews applied: [37722, 37747] All tests passe

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96400 --- Bad patch! Reviews applied: [37196, 37197] Failed command: ./suppo

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37747/#review96384 --- src/slave/containerizer/provisioners/backend.cpp (lines 34 - 36)

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 25, 2015, 5:05 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 102 > > > > > > Also does this mean if a user put in tcp:/// we're just padding > > unix:///? > > I think it's safe to assume we

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 25, 2015, 7:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 7:45 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1879-1886 > > > > > > Per the design doc, we don't need a new message. You should be able to > > augment the existing UpdateFramewo

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: > > This review is a bit hard to follow because it's doing multiple things. I > > would recommend you to split this into multiple reviews > > > > #1) Expose framework user in state.json > > #2) Update framework user on re-registration (need a te

Re: Review Request 37726: Added support for preparing images specified in volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/#review96403 --- Ship it! src/slave/containerizer/isolators/filesystem/linux.cpp (l

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96407 --- Bad patch! Reviews applied: [37500] Failed command: ./support/appl

Re: Review Request 36870: Added -> operator for Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36870/#review96409 --- Ship it! Adjusted the operater spacing to match updated style. - J

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96408 --- Content-wise, LGTM. Style-wise, there's a bit of jaggedness in your

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96412 --- Bad patch! Reviews applied: [37500] Failed command: ./support/appl

Re: Review Request 36868: Added -> operators for Option, Try, Result.

> On July 29, 2015, 4:42 a.m., Michael Park wrote: > > Why wasn't [r36869](https://reviews.apache.org/r/36869) just included in > > this patch? Ah, it's because this patch is `stout` whereas [r36869](https://reviews.apache.org/r/36869/) is `libprocess`. - Michael --

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:19 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:25 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 4:56 p.m., Vinod Kone wrote: > > This review is a bit hard to follow because it's doing multiple things. I > > would recommend you to split this into multiple reviews > > > > #1) Expose framework user in state.json > > #2) Update framework user on re-registration (need a tes

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 25, 2015, 8:57 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 8:58 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 25, 2015, 8:59 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 25, 2015, 9 p.m.) Review request for mesos and Timothy Chen. Ch

Re: Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 25, 2015, 9:01 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 25, 2015, 9:02 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 9:03 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96422 --- Patch looks great! Reviews applied: [37500] All tests passed. - M

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 25, 2015, 9:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96414 --- src/docker/docker.cpp (line 104)

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96424 --- src/docker/docker.cpp (line 104)

Re: Review Request 36869: Added try_tests.cpp to libprocess makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36869/#review96430 --- Ship it! Ship It! - Joris Van Remoortere On July 28, 2015, 12:56

Re: Review Request 36868: Added -> operators for Option, Try, Result.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36868/#review96429 --- Ship it! Adjust the operator spacing. Keeping the current style for

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96126 --- include/mesos/mesos.proto (line 123)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 21, 2015, 6:35 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 917-920 > > > > > > I think the name `Unavailability` is too specific to maintenance, how > > about something more gener

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 25, 2015, 9:55 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 847-850 > > > > > > As per my comment for `InverseOffers`, let's clarify the contract and > > guarantees here. Or, as I

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96421 --- src/Makefile.am (line 477)

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96433 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37200, 37

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 104 > > > > > > prefixit sounds wierd, how about prefixSocket? Will change > On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote: > >

Re: Review Request 36908: Added QuotaInfo Protobuf.

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote: > > include/mesos/master/quota.proto, line 19 > > > > > > Yes, does v1 API will be supportted for quota? Adding new protobufs should be backwards-compatible, so I sup

  1   2   >