Re: Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38334/#review98994 --- Ship it! Ship It! - Adam B On Sept. 13, 2015, 6:45 a.m., Qian Zh

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 15, 2015, 4:54 a.m., Marco Massenzio wrote: > > LGTM > > Can you please add a test with a few vars defined in Env and then in Cmd > > Line too, and verify that it "works as intended"? > > > > Thanks for bearing with me and changing your code. > > I think it looks clean and nice now :

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98983 --- LGTM Can you please add a test with a few vars defined in Env and th

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review98924 --- my main question is regarding division of responsibilities between t

Re: Review Request 38172: Stout: Simplified hashset implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38172/#review98974 --- Just a drive by on comment wrapping changes. 3rdparty/libprocess/3

Re: Review Request 38386: Fix 'operator=' spacing in the registry_client.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38386/#review98973 --- Ship it! Ship It! - Joseph Wu On Sept. 14, 2015, 5:14 p.m., Guan

Re: Review Request 38348: Correct typo in http.cpp

> On Sept. 14, 2015, 10:27 a.m., Joseph Wu wrote: > > That's not a typo; "iff" is short for "if and only if". > > Guangya Liu wrote: > Thanks Joseph for pointing this oout. It is difficult for non native > english speakers understand this, what about updating "iff" to "if and only > if"?

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98965 --- src/slave/containerizer/provisioners/docker/paths.cpp (line 35)

Review Request 38386: Fix 'operator=' spacing in the registry_client.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38386/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Timothy Chen. Re

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

> On Sept. 14, 2015, 4:51 p.m., Qian Zhang wrote: > > src/tests/master_maintenance_tests.cpp, line 418 > > > > > > I checked v1/mesos.proto, and found regular offer also has > > unavailability: > > ``` > > o

Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37969/ --- (Updated Sept. 14, 2015, 5:10 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38376: Fix 'operator=' spacing in the V1 Scheduler interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38376/#review98969 --- Ship it! Ship It! - Anand Mazumdar On Sept. 14, 2015, 10:49 p.m.

Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

> On Sept. 14, 2015, 11:38 p.m., Cong Wang wrote: > > src/slave/containerizer/isolators/cgroups/perf_event.cpp, line 413 > > > > > > s/sampling will be halted// ? Great catch, thank you! - Ben --

Re: Review Request 38380: Minor cleanups in the perf event isolator.

> On Sept. 14, 2015, 11:48 p.m., Cong Wang wrote: > > src/slave/containerizer/isolators/cgroups/perf_event.cpp, line 374 > > > > > > I don't think cgroup can be destroyed while perf running, kernel should > > return

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review98964 --- src/tests/master_maintenance_tests.cpp (line 405)

Re: Review Request 38376: Fix 'operator=' spacing in the V1 Scheduler interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38376/#review98963 --- Ship it! Ship It! - Guangya Liu On 九月 14, 2015, 10:49 p.m., Jose

Re: Review Request 38380: Minor cleanups in the perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38380/#review98962 --- src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 374)

Re: Review Request 38377: Removed 'using namespace process' in perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38377/#review98960 --- Ship it! Ship It! - Guangya Liu On 九月 14, 2015, 10:57 p.m., Ben

Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38382/#review98959 --- src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 411)

Re: Review Request 38374: Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38374/#review98958 --- Ship it! Ship It! - Timothy Chen On Sept. 14, 2015, 10:30 p.m.,

Re: Review Request 38381: Removed hard-coded reap interval from perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38381/#review98957 --- Ship it! Ship It! - Guangya Liu On 九月 14, 2015, 10:57 p.m., Ben

Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38382/#review98956 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we in

Re: Review Request 38348: Correct typo in http.cpp

> On 九月 14, 2015, 5:27 p.m., Joseph Wu wrote: > > That's not a typo; "iff" is short for "if and only if". Thanks Joseph for pointing this oout. It is difficult for non native english speakers understand this, what about updating "iff" to "if and only if"? - Guangya -

Re: Review Request 38381: Removed hard-coded reap interval from perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38381/#review98952 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38380: Minor cleanups in the perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38380/#review98951 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/#review98949 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/#review98950 --- 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 31)

Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

> On Sept. 14, 2015, 11:21 p.m., Cong Wang wrote: > > Not sure how much value this patch has, because upper layer always calls it > > with non-empty cgroups. Also, you probably want to check for events.empty() > > too while you are on it. This was done for https://reviews.apache.org/r/38380/,

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/#review98947 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 11:08 p.m., Ben Ma

Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/#review98945 --- Not sure how much value this patch has, because upper layer always c

Re: Review Request 38377: Removed 'using namespace process' in perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38377/#review98946 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38375: Fixed process::collect and process::await to do discard propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38375/#review98944 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98943 --- Patch looks great! Reviews applied: [37168] All tests passed. - M

Re: Review Request 38374: Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38374/#review98942 --- Ship it! We should probably have a test case (or some checks in exi

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/ --- (Updated Sept. 14, 2015, 11:08 p.m.) Review request for mesos and Jie Yu. Cha

Re: Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/#review98938 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (lines 83

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

> On Sept. 14, 2015, 11:02 p.m., Cong Wang wrote: > > src/tests/containerizer/perf_tests.cpp, line 53 > > > > > > You are changing the semantic, the original test case is to verify a > > list of events which contains

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/#review98939 --- src/tests/containerizer/perf_tests.cpp (line 51)

Review Request 38381: Removed hard-coded reap interval from perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38381/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3423 https://issues.apache

Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- H

Review Request 38377: Removed 'using namespace process' in perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38377/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- S

Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- S

Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38382/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3423 https://issues.apache

Review Request 38375: Fixed process::collect and process::await to do discard propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38375/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3426 https://issues.apache

Review Request 38380: Minor cleanups in the perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38380/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- T

Review Request 38376: Fix 'operator=' spacing in the V1 Scheduler interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38376/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 38365: Updated Isolator::prepare to return list of required namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38365/#review98937 --- Ship it! include/mesos/slave/isolator.proto (line 75)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98936 --- src/slave/slave.cpp (line 2760)

Re: Review Request 38363: Refactored container Launcher to accept namespaces dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38363/#review98934 --- src/tests/containerizer/isolator_tests.cpp (line 202)

Review Request 38374: Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38374/ --- Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Ya

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38333/ --- (Updated Sept. 14, 2015, 10:29 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98926 --- include/mesos/mesos.proto (line 1163)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98932 --- include/mesos/mesos.proto (lines 1163 - 1164)

Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38368/#review98928 --- src/examples/test_hook_module.cpp (line 197)

Re: Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/ --- (Updated Sept. 14, 2015, 5:54 p.m.) Review request for mesos, Connor Doyle, Jie

Re: Review Request 38366: Added helper to model Labels message for state.json.

> On Sept. 14, 2015, 5:40 p.m., Niklas Nielsen wrote: > > High level comment; would it be worth change JSON::Protobuf() to support > > Labels instead? Probably not. We are trying a shortcut when modelling Labels for state.json. Thus, I wouldn't want to change JSON::Protobuf which is supposed t

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98923 --- +1 on Tim's comment. I think you can just generalize the text to '3r

Re: Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/#review98921 --- Can you expand on the change (before and after) effect in the RR des

Re: Review Request 38366: Added helper to model Labels message for state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38366/#review98922 --- High level comment; would it be worth change JSON::Protobuf() to sup

Re: Review Request 37585: Maintenance primitives: Add a user doc.

> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, lines 68-72 > > > > > > Did not we describe this already? True. The intention was to reword the documentation in the protobufs. But

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 14, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 14, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98917 --- src/docker/executor.cpp (line 162)

Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38368/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Review Request 38366: Added helper to model Labels message for state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38366/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Repository:

Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/ --- Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy Chen

Review Request 38365: Updated Isolator::prepare to return list of required namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38365/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/ --- Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.

Review Request 38363: Refactored container Launcher to accept namespaces dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38363/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 277 > > > > > > Why are we parsing the error JSON to extract the error string from JSON

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 14, 2015, 1:37 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98879 --- Per Connors comment, we need a test to exercise the new code inclu

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/ --- (Updated Sept. 14, 2015, 8:08 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98910 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 57

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review97421 --- For some reason this did not get posted when it should have. 3rdpa

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:22 p.m., Alex Clemmer wrote: > > I think that `-DGTEST_USE_OWN_TR1_TUPLE` is actually unnecessary now that > > you've upgraded to GMock 1.7 (in commie > > a8970ce78f1abbee3dd4de282d54ced38d0e5fa1). Let me just double-check my > > understanding here just to make sure we'r

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98906 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 89

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:22 p.m., Alex Clemmer wrote: > > I think that `-DGTEST_USE_OWN_TR1_TUPLE` is actually unnecessary now that > > you've upgraded to GMock 1.7 (in commie > > a8970ce78f1abbee3dd4de282d54ced38d0e5fa1). Let me just double-check my > > understanding here just to make sure we'r

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:25 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166 > > > > > > So, what's the rationale for using `${CMAKE_CXX_FLAGS}` here? It seems > > to me that we only

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

> On Sept. 14, 2015, 6 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/appc/provisioner.cpp, lines 368-369 > > > > > > Oh... > > > > I thought `root` was being copied but I guess the compi

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98901 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 266 > > > > > > Not yours , but can we just do OK().status ? > > Jojy Varghese wrote: >

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 266 > > > > > > Not yours , but can we just do OK().status ? never understood the reaso

Re: Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38306/#review98893 --- Ship it! 3rdparty/libprocess/include/process/ssl/gtest.hpp (lines

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review98892 --- Patch looks great! Reviews applied: [37505] All tests passed. - M

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98876 --- LGTM. Just a minor query around why do we want to parse the error re

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98886 --- src/hook/manager.cpp (line 261)

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98880 --- include/mesos/mesos.proto (line 820)

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98884 --- src/examples/test_hook_module.cpp (line 208)

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38333/#review98863 --- Ship it! src/slave/containerizer/isolators/filesystem/linux.cpp (l

Re: Review Request 38343: mesos: Fixed punctuation in log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38343/#review98878 --- Ship it! Ship It! - Niklas Nielsen On Sept. 13, 2015, 10:09 p.m.

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- (Updated Sept. 14, 2015, 10:41 a.m.) Review request for mesos and Niklas Nielse

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review98875 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 112

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 14, 2015, 10:39 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38279: [MESOS-3366] Allow resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 14, 2015, 10:38 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98872 --- Ship it! Ship It! - Jojy Varghese On Sept. 11, 2015, 7:34 p.m.,

Re: Review Request 38348: Correct typo in http.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38348/#review98870 --- That's not a typo; "iff" is short for "if and only if". - Joseph Wu

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, lines 1622-1624 > > > > > > Why don't we want to send lost slave messages? > > Benjamin Hindman wrote: > Sorry, I meant: why don'

  1   2   >