Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102021 --- Patch looks great! Reviews applied: [39152] All tests passed. -

Re: Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102026 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 38943: Fixed misleading information in the Mesos framework writing guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38943/#review102031 --- Ship it! Minor nits/tweaks, but I'll fix those myself before I com

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102036 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102039 --- Ship it! Ship It! - Guangya Liu On 十月 8, 2015, 6:28 p.m., Artem

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review102040 --- docs/attributes-resources.md (line 174)

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102043 --- Ship it! Ship It! - Till Toenshoff On Oct. 8, 2015, 1 a.m., Isa

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Oct. 9, 2015, 12:53 p.m.) Review request for mesos, Adam B, Benjamin H

Review Request 39172: Add Blue Yonder to the powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39172/ --- Review request for mesos and Dave Lester. Repository: mesos Description -

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 9, 2015, 2:25 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 8, 2015, 9:07 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp, line 54 > > > > > > We have to support CentOS 5 which has glibc 2.5 FWICT. I widdened the requirem

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Oct. 9, 2015, 2:24 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39172: Add Blue Yonder to the powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39172/#review102061 --- Patch looks great! Reviews applied: [39172] All tests passed. -

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 9, 2015, 4:13 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review102070 --- Ship it! Ship It! - Qian Zhang On Oct. 3, 2015, 4:11 a.m., Alex

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 9, 2015, 9:35 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 174 > > > > > > Do you mind to update three to five here? Nice catch! - Greg --

Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu

Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu

Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- (Updated Oct. 9, 2015, 6:30 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 39184: RegistryClient refactor: reordered ctor parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39184/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/ --- (Updated Oct. 9, 2015, 6:30 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 9, 2015, 6:30 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39155/ --- (Updated Oct. 9, 2015, 6:32 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 38443: Added layerid information to ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Oct. 9, 2015, 6:34 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39184: RegistryClient refactor: reordered ctor parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39184/ --- (Updated Oct. 9, 2015, 6:35 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 9, 2015, 6:36 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39156/ --- (Updated Oct. 9, 2015, 6:37 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 9, 2015, 6:37 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102094 --- LGTM! - Cody Maloney On Oct. 9, 2015, 12:57 a.m., Greg Mann wrot

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/#review102099 --- 3rdparty/libprocess/include/process/future.hpp (line 39)

Review Request 39186: added a FileDescriptor to manage the life cycle of fds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39186/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3520 https://issues.ap

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102098 --- Ship it! Ship It! - Kapil Arya On Oct. 8, 2015, 8:57 p.m., Greg

Review Request 39187: added FileDescriptor tests in libprocess Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39187/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3520 https://issues.ap

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- (Updated Oct. 9, 2015, 7 p.m.) Review request for mesos, Artem Harutyunyan, Jor

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 9, 2015, 2:06 a.m., Kapil Arya wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1109-1115 > > > > > > I am slightly confused here. If one or more `Isolator::prepare` calls > > returned a

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review102102 --- Patch looks great! Reviews applied: [39102] All tests passed. -

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102103 --- Ship it! Ship It! src/tests/containerizer/provisioner_docker_tes

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 9, 2015, 7:49 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102105 --- LGTM, Just some minor comments/concerns about including `headers` t

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- (Updated Oct. 9, 2015, 8:33 p.m.) Review request for mesos and Kapil Arya. Ch

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102108 --- Ship it! LGTM src/tests/containerizer/mesos_containerizer_tests.

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 9, 2015, 2:39 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102116 --- Ship it! Thanks! I'll fix the indent and commit this. Also, you d

Re: Review Request 39187: added FileDescriptor tests in libprocess Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39187/#review102120 --- Patch looks great! Reviews applied: [39186, 39187] All tests pass

Review Request 39192: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39192/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3519 https://issues.ap

Review Request 39193: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3519 https://issues.ap

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102118 --- Mainly style nits otherwise looks pretty good. src/slave/containe

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 3:24 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/#review102122 --- Bad patch! Reviews applied: [39019, 39076, 39091, 39092, 39093, 39

Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- Review request for mesos and Adam B. Bugs: MESOS-3694 https://issues.apache

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review102126 --- support/website/files/run_site.sh (line 10)

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102111 --- Overall looks good, some of the comments I made can be addressed in

Re: Review Request 39192: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39192/#review102127 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (lin

Re: Review Request 39193: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/#review102128 --- src/linux/cgroups.cpp (line 925)

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 4:08 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102110 --- Looking good, but I haven't made it to the tests yet (coming soon),

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review102133 --- support/website/README.md (line 36)

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102135 --- Patch looks great! Reviews applied: [39152] All tests passed. -

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 4:39 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102136 --- Ship it! Ship It! - Anand Mazumdar On Oct. 9, 2015, 11:39 p.m.,

Review Request 39196: Puller tests: removed extraneous sandbox directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39196/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 39197: Provider tests: minor style fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39197/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/#review102138 --- Ship it! Looks good (identical to the original open.hpp, except fo

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/#review102140 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp

Re: Review Request 39193: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/#review102141 --- Patch looks great! Reviews applied: [39192, 39193] All tests pass

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/#review102142 --- Ship it! Ship It! - Joseph Wu On Oct. 9, 2015, 12:49 p.m., Alex

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 10, 2015, 12:43 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 9, 2015, 11:14 p.m., Adam B wrote: > > include/mesos/resources.hpp, lines 83-98 > > > > > > Do these all need to be public? Indeed they do not. In addition to making these private, I rearranged the member

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 9, 2015, 4:14 p.m., Adam B wrote: > > src/common/resources.cpp, lines 368-384 > > > > > > This smells like a hack to workaround a bug in picojson. Can you link > > to something that indicates this as best

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review102146 --- Patch looks great! Reviews applied: [39194] All tests passed. -

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

> On Oct. 7, 2015, 5:05 p.m., Joseph Wu wrote: > > CMakeLists.txt, line 97 > > > > > > This only runs the libprocess tests. Did you mean to do this? Oh, man, somehow they must have gotten obliterated when I was movi

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102148 --- Patch looks great! Reviews applied: [38901, 38919] All tests pass

Re: Review Request 39197: Provider tests: minor style fixes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39197/#review102149 --- Patch looks great! Reviews applied: [39196, 39197] All tests pass

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/ --- (Updated Oct. 10, 2015, 4:25 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/ --- (Updated Oct. 10, 2015, 4:27 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39096/ --- (Updated Oct. 10, 2015, 4:27 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102151 --- Patch looks great! Reviews applied: [39018] All tests passed. -

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- (Updated Oct. 10, 2015, 4:28 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/ --- (Updated Oct. 10, 2015, 4:28 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- (Updated Oct. 10, 2015, 4:29 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

> On Oct. 9, 2015, 7:02 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 39 > > > > > > FYI: `future.hpp` actually requires `check.hpp`, but this requirement > > was actually hidden

Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu

Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

> On Oct. 9, 2015, 3:52 p.m., Jonathon Rossi wrote: > > support/website/files/run_site.sh, line 10 > > > > > > With the changes we made you shouldn't pull from subversion anymore, > > the site files are in /site. Dav

Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review102154 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092, 3

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 10, 2015, 5:58 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/#review102157 --- Ah. Sorry about the reviewbot problem. I thought the dependency cha