Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107047 --- src/master/quota_handler.cpp (line 224)

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107042 --- Thanks for working on this. This functionality has been missing

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107041 --- src/master/quota_handler.cpp (line 224)

Re: Review Request 38233: os: add swap information to memory().

> On Nov. 17, 2015, 7:20 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, lines 708-759 > > > > > > do these calculations work irrespective of whether swap is enabled or >

Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs:

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39591/ --- (Updated Nov. 18, 2015, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39592/ --- (Updated Nov. 18, 2015, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 39590: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- (Updated Nov. 18, 2015, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review107061 --- support/hooks/post-rewrite (line 33)

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > > > > > Why not add a 0x prefix if it's not present so you can use numify? > >

Re: Review Request 38233: os: add swap information to memory().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38233/#review107062 --- Ship it! Ship It! - Vinod Kone On Sept. 10, 2015, 5:57 p.m.,

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

> On Nov. 11, 2015, 9:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4244-4247 > > > > > > why do it here instead of in recoverFramework() #4363? that feels more > > consistent with #1345. > > James

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- (Updated Nov. 18, 2015, 6:49 p.m.) Review request for mesos, Kapil Arya and

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review107070 --- src/slave/slave.cpp (line 4321)

Re: Review Request 40305: Added URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/#review107073 --- Ship it! include/mesos/uri/fetcher.hpp (line 49)

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Nov. 18, 2015, 7:20 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40403: Added streaming and construction methods for URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/#review107074 --- Ship it! src/uri/schemes/http.hpp (line 38)

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107076 --- Ship it! LGTM! Just some minor newline nits.

Re: Review Request 40418: Added curl based URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40418/ --- (Updated Nov. 18, 2015, 8:56 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review106999 --- Do we also need to add this support in v1/mesos.proto? - Qian

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 18, 2015, 11:28 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40244/ --- (Updated Nov. 18, 2015, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40246: Removed unused "using" statement from test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40246/ --- (Updated Nov. 18, 2015, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40245: Fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40245/ --- (Updated Nov. 18, 2015, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/ --- (Updated Nov. 18, 2015, 11:28 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40243/ --- (Updated Nov. 18, 2015, 11:28 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107000 --- 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 233 > > > > > > You didn't start this, but any `struct` token here is unnecessary noise > >

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- (Updated Nov. 18, 2015, 11:09 a.m.) Review request for mesos, Benjamin

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107013 --- Patch looks great! Reviews applied: [40435] Passed command:

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107022 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

> On Nov. 18, 2015, 12:02 a.m., Michael Park wrote: > > include/mesos/mesos.proto, line 583 > > > > > > How about `The role that this resource is reserved for.`? In the sense > > that it's not the role that

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

> On Nov. 18, 2015, midnight, Michael Park wrote: > > docs/home.md, line 40 > > > > > > `s/for use by a role/for a role/`? `to be used by a role`? Personally, I think "for use by a role" is the clearest way to

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107004 --- Patch looks great! Reviews applied: [40435] Passed command:

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 18, 2015, 11:43 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40244/#review106992 --- src/master/http.cpp (line 2096)

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review106998 --- Patch looks great! Reviews applied: [40431] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review106993 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 18, 2015, 10:15 a.m.) Review request for mesos, Adam B, Benjamin

Review Request 40435: Fixed pointer alignment error in IP::create().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.

Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- Review request for mesos, Adam B and Qian Zhang. Bugs: MESOS-3944

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107001 --- src/slave/slave.cpp (lines 4419 - 4427)

Review Request 40434: Fixed a problem when an HTTP response cannot be delivered and a promise was broken.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40434/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 40434: Fixed a problem when an HTTP response cannot be delivered and a promise was broken.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40434/#review107002 --- Ship it! It would have been great to clarify in the description

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/#review107028 --- I dont feel that we are really matching the intension of the

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Nov. 18, 2015, 3:51 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39892: Added ExternalResourceInfo to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39892/ --- (Updated Nov. 18, 2015, 2:58 p.m.) Review request for mesos and Joerg Schad.

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review107003 --- Ship it! Was great sitting down and going over all of this stuff

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/#review107092 --- docs/persistent-volume.md (line 235)

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 19, 2015, 12:39 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40459/#review107119 --- docs/configuration.md (lines 37 - 54)

Re: Review Request 40246: Removed unused "using" statement from test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40246/#review107120 --- Ship it! Ship It! - Guangya Liu On 十一月 18, 2015, 11:27 a.m.,

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40340/#review107112 --- Good stuff! Sorry for the delay in reviewing this: only got

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Nov. 19, 2015, 12:47 a.m.) Review request for mesos. Bugs:

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Nov. 19, 2015, 12:48 a.m.) Review request for mesos. Bugs:

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/#review107117 --- docs/reservation.md (line 242)

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40340/#review107116 --- support/mesos-style.py (line 104)

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Nov. 19, 2015, 12:48 a.m.) Review request for mesos. Bugs:

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

> On 十一月 17, 2015, 3:12 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, lines 216-228 > > > > > > Can you please explain more why using mesos containerizer can also run > > a docker container? Thanks! > > Jojy

Re: Review Request 38234: Check if swap is enabled before running memory pressure related tests.

> On Nov. 17, 2015, 7:27 p.m., Vinod Kone wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 560-568 > > > > > > instead of asserting, it would be better if we can disable the test > > automatically if we

Re: Review Request 40305: Added URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/ --- (Updated Nov. 18, 2015, 11:25 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40403: Added streaming and construction methods for URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/ --- (Updated Nov. 18, 2015, 11:25 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40418: Added curl based URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40418/ --- (Updated Nov. 18, 2015, 11:25 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107104 --- src/cli/execute.cpp (line 237)

Review Request 40268: [WIP] Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40453/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Review Request 40454: Add calls to parent teardown methods in child teardown methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40454/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40243/#review107098 --- Ship it! Ship It! - Greg Mann On Nov. 18, 2015, 11:28 a.m.,

Re: Review Request 40246: Removed unused "using" statement from test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40246/#review107099 --- Ship it! Ship It! - Greg Mann On Nov. 18, 2015, 11:27 a.m.,

Re: Review Request 40285: Changed untar process to pipe STDERR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review107106 --- Ship it! Ship It! - Timothy Chen On Nov. 17, 2015, 6:57 a.m.,

Re: Review Request 40253: Added URI protobuf definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/ --- (Updated Nov. 18, 2015, 11:26 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40418: Added curl based URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40418/ --- (Updated Nov. 18, 2015, 11:10 p.m.) Review request for mesos, Ben Mahler and

Review Request 40463: Moved HDFS wrapper implementation to a cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40463/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs:

Review Request 40461: Changed HDFS wrapper from a struct to a class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40461/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs:

Review Request 40462: Fixed the license header in hdfs.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40462/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107122 --- src/sched/sched.cpp (line 1072)

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107101 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107121 --- docs/persistent-volume.md (line 258)

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote: > > src/sched/sched.cpp, line 1073 > > > > > > s/VLOG(1)/LOG(WARNING) The logging level here is consistent with lostSlave above: ``` if (from !=

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

> On 十一月 19, 2015, 2:57 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 37-54 > > > > > > I think that the master/main.cpp should also be updated for those > > flages. > > Anindya Sinha wrote: > It is

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 19, 2015, 6:46 a.m.) Review request for mesos, Adam B and Qian

Review Request 40469: Update Allocator interface to support dynamic roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- Review request for mesos. Repository: mesos Description --- Update

Re: Review Request 40469: Update Allocator interface to support dynamic roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Nov. 19, 2015, 6:48 a.m.) Review request for mesos, Adam B and Qian

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Nov. 18, 2015, 9:50 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- (Updated Nov. 18, 2015, 9:56 p.m.) Review request for mesos, Kapil Arya and

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review107087 --- Patch looks great! Reviews applied: [40177] Passed command: