Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review110111 --- Ship it! Ship It! src/slave/containerizer/docker.cpp (line 835)

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/ --- (Updated Dec. 13, 2015, 5:35 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Dec. 12, 2015, 6:12 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 41212: Adjust timeout value in HealthCheckTest.CheckCommandTimeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41212/ --- (Updated Dec. 12, 2015, 8:11 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38172: Stout: Simplified hashset implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38172/#review110080 --- 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp

Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/ --- Review request for mesos, Ben Mahler and Timothy Chen. Bugs: MESOS-4141

Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/ --- Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian

Re: Review Request 40966: Corrected termination of Docker containers.

> On Dec. 12, 2015, 8:36 a.m., haosdent huang wrote: > > Ship It! Thank you very much. I verify this in Ubuntu 14.04 with your test command. Before apply your patch could reproduce problem, after apply this patch could pass. - haosdent

Re: Review Request 38171: Stout: Refactored set to use initializer list for variadic constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38171/#review110079 --- I would actually prefer we get rid of this class entirely. 1. I

Re: Review Request 38173: Stout: Simplified hashmap implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38173/#review110081 --- 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp

Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41302/ --- Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian

Re: Review Request 40966: Corrected termination of Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40966/#review110076 --- Ship it! Ship It! - haosdent huang On Dec. 11, 2015, 11:15

Re: Review Request 35711: Disallow special characters in role name.

> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote: > > include/mesos/roles.hpp, line 51 > > > > > > Should this be a member function? i.e., not static. When I write this, I refer to the static validate method in

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Dec. 12, 2015, 2:29 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 41248: Enabled master get USAGE_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41248/ --- (Updated 十二月 12, 2015, 4:43 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41246/ --- (Updated 十二月 12, 2015, 4:43 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41254: Enable master get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/ --- (Updated 十二月 12, 2015, 4:43 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 41314: Fixed hang introduced in committed version of HTTP AuthenticatorRouter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41314/ --- Review request for mesos, Ben Mahler, Michael Park, and Till Toenshoff.

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Dec. 12, 2015, 2:33 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 35711: Disallow special characters in role name.

> On Nov. 9, 2015, 11:26 p.m., Greg Mann wrote: > > src/master/master.cpp, line 568 > > > > > > Should we add a comment here saying that the validation of roles occurs > > in flags.cpp? I put off the check to

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

> On Dec. 12, 2015, 3:47 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 1380-1382 > > > > > > I'm not sure if this is necessary. > > > > To be as backwards compatible as possible, the

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41250/ --- (Updated 十二月 12, 2015, 4:43 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Dec. 12, 2015, 11:19 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 36816: Support HTTP checks in Mesos health check program

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Dec. 12, 2015, 4:08 p.m.) Review request for mesos, Adam B, Michael

Re: Review Request 36816: Support HTTP checks in Mesos health check program

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Dec. 12, 2015, 4:08 p.m.) Review request for mesos, Adam B, Michael

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39622/#review110100 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 11, 2015,

Re: Review Request 41314: Fixed hang introduced in committed version of HTTP AuthenticatorRouter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41314/#review110094 --- Can you try to explain why we need a sequence per receiver instead

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Oct. 6, 2015, 5:12 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 87 > > > > > > Seems like this will give a negative array access if you set

Re: Review Request 39288: Quota: Added authentication of quota requests.

Actually we do: https://github.com/apache/mesos/blob/master/src/master/quota_handler.cpp#L391 On Fri, Dec 11, 2015 at 12:23 AM, Alexander Rukletsov wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39288/ >

Re: Review Request 41223: Cleaned up creation of HTTP auth headers in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41223/#review110099 --- Ship it! src/tests/mesos.hpp (lines 539 - 542)

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review110101 --- Let's get some Windows team reviews on this. let's try and use

Re: Review Request 41318: Fixed a connection leak in ProcessTest.Http1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41318/#review110106 --- Ship it! Thanks for fixing this Ben!

Re: Review Request 41320: Clarified Subprocess PIPE usage in Subprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41320/#review110107 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 12, 2015,

Review Request 41318: Fixed a connection leak in ProcessTest.Http1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41318/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Review Request 41320: Clarified Subprocess PIPE usage in Subprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41320/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Dec. 12, 2015, 11:08 p.m.) Review request for mesos, Artem

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

> On Dec. 10, 2015, 2:48 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 21 > > > > > > Maybe we can drop the `Try` specific part of this comment. This

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Dec. 12, 2015, 11:50 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

> On Dec. 10, 2015, 2:48 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, lines 27-29 > > > > > > Let's move this into `` Per discussion we actually move the error type

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/#review110103 --- Patch looks great! Reviews applied: [41275, 41277, 41280, 41281,