Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review117668 --- src/slave/constants.cpp (line 55)

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117646 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117665 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 2:34 a.m., A

Re: Review Request 43131: Modified existing usage of Slave constructor.

> On Feb. 3, 2016, 7:51 p.m., Vinod Kone wrote: > > src/slave/main.cpp, line 211 > > > > > > this is backwards incompatible. this will need to go through a > > deprecation cycle with a warning to the dev/user list.

Re: Review Request 43131: Modified existing usage of Slave constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 7:56 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 42181: Added a process ID argument to Slave constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42181/#review117661 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 2:31 a.m., A

Re: Review Request 42185: Added an example executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/#review117662 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 2:34 a.m., A

Re: Review Request 43131: Modified existing usage of Slave constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/#review117660 --- src/slave/main.cpp (line 211)

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117658 --- Bad patch! Reviews applied: [43093] Failed command: ./support/ap

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1] >

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117655 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 3, 2016, 8:58 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 326 > > > > > > If we could add some assert code about ip value in `TEST_F(DockerTest, > > ROOT_DOCKER_interface)` would make this

Re: Review Request 42755: Added documentation for labeled reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review117652 --- Patch looks great! Reviews applied: [42750, 42751, 42752, 42753,

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 3, 2016, 8:47 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 304 > > > > > > According > > https://docs.docker.com/engine/reference/api/docker_remote_api/ Seems this > > would have problem in

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 3, 2016, 7:04 p.m.) Review request for mesos and Kapil Arya. Ch

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43072/#review117650 --- Ship it! Ship It! - Vinod Kone On Feb. 1, 2016, 11:36 p.m.,

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/#review117644 --- src/linux/cgroups.hpp (lines 656 - 657)

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review117641 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117632 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line

Re: Review Request 42755: Added documentation for labeled reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/ --- (Updated Feb. 3, 2016, 5:51 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42754: Added support for labels to resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Feb. 3, 2016, 5:51 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42751: Tweaked some resource test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Feb. 3, 2016, 5:51 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42752: Fixed some typos in test case comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42752/ --- (Updated Feb. 3, 2016, 5:50 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42751: Tweaked some resource test cases.

> On Feb. 3, 2016, 5:34 p.m., Joerg Schad wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > I must say this pattern (distance(begin,end)) just to get the item > > count looks unintuitive here. > > I

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/#review117638 --- Ship it! Ship It! - Joerg Schad On Jan. 25, 2016, 11 p.m., N

Re: Review Request 42752: Fixed some typos in test case comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42752/#review117637 --- Fix it, then Ship it! src/tests/containerizer/port_mapping_tes

Re: Review Request 42751: Tweaked some resource test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117635 --- Fix it, then Ship it! src/tests/resources_tests.cpp (line 327)

Re: Review Request 42586: Defined the NetClsHandleManager class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117633 --- Looks good. Some minor comments modulo Jie's earlier comments. s

Re: Review Request 42586: Defined the NetClsHandleManager class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117629 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42750/#review117626 --- Ship it! Ship It! - Joerg Schad On Jan. 25, 2016, 10:49 p.m.

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review117161 --- src/tests/slave_recovery_tests.cpp (line 404)

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review117620 --- Patch looks great! Reviews applied: [42633, 42636, 42657, 42658,

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review117616 --- src/master/allocator/mesos/hierarchical.cpp (line 514)

Review Request 43138: Updated a comment for oversubscribed resources for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117609 --- Patch looks great! Reviews applied: [43032] Passed command: expo

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117608 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (line 53

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 3, 2016, 11:33 a.m.) Review request for mesos and Guangya Liu.

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117605 --- Patch looks great! Reviews applied: [43136] Passed command: expo

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117602 --- src/docker/docker.cpp (line 326)

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117600 --- src/docker/docker.cpp (line 316)

Re: Review Request 43134: Added output operator for unversioned executor protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43134/#review117598 --- Patch looks great! Reviews applied: [43134] Passed command: expo

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117597 --- src/docker/docker.cpp (line 304)

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117595 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (li

Review Request 43136: Support libprocess build run in aarch64 cpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs:

Review Request 43135: Support libprocess build run in aarch64 cpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43135/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review117593 --- Ship it! Ship It! - Bernd Mathiske On Jan. 28, 2016, 4:45 p.

<    1   2