Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124111 --- Fix it, then Ship it! src/authentication/http/basic_authentica

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/ --- (Updated March 19, 2016, 2:29 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 44912: Used the same fixture for all related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/#review123882 --- Ship it! Ship It! - Yong Tang On March 16, 2016, 3:47 p.m.,

Re: Review Request 44767: Added authentication information to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44767/ --- (Updated March 17, 2016, 11:57 a.m.) Review request for mesos, Adam B and Greg

Review Request 44900: Update containerizer construction in slave_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44900/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44897: Update containerizer construction in hook_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44897/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/ --- (Updated March 17, 2016, 7:34 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 17, 2016, 1:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 88 > > > > > > Should this be a `Result` instead of an `Option` ? Since either the > > co

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 6:52 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123975 --- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/

Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828 https:/

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 17, 2016, 4:44 p.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/ --- (Updated March 17, 2016, 6:41 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review124137 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Review Request 44964: Removed unused header includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44964/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- T

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 17, 2016, 10:43 p.m.) Review request for mesos, Jie Yu and Jiang

Review Request 44904: Update containerizer construction in mesos_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44904/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated March 16, 2016, 11:21 a.m.) Review request for mesos and Till Toenshof

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review124403 --- Patch looks great! Reviews applied: [44836] Passed command: expo

Re: Review Request 44421: Added support for "overlay" keyword.

> On 三月 18, 2016, 8:59 a.m., Jay Guo wrote: > > Is this chunk of code testable? Yes, it was already coveredy by src/tests/environment.cpp - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review123995 --- Patch looks great! Reviews applied: [42386] Passed command: expo

Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828 https:/

Re: Review Request 44846: Deprecated the plain text credential format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124051 --- Fix it, then Ship it! Could you please check that all the markd

Re: Review Request 44852: Documented existing allocator metrics.

> On March 17, 2016, 6:28 p.m., Ben Mahler wrote: > > docs/monitoring.md, line 863 > > > > > > s/hierarchical// for now since we named it "hierarchical" a bit > > prematurely Done. > On March 17, 2016, 6:28 p.m.,

Re: Review Request 44554: Added agent HTTP authentication to the docs.

> On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/authentication.md, line 45 > > > > > > Does it make to create a 'Master and Slave Options' section similar to > > configuration.md. > > Otherwise we en

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124252 --- support/hooks/pre-commit (line 38)

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/ --- (Updated March 17, 2016, 1:47 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 18, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44978/#review124264 --- 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp

Review Request 45073: Restructured authentication.md to group common flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45073/ --- Review request for mesos, Adam B and Greg Mann. Repository: mesos Description

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review123903 --- src/examples/dynamic_reservation_framework.cpp (line 32)

Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOs-4828 https:/

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44978/ --- (Updated March 18, 2016, 12:12 a.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the lo

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

> On March 18, 2016, 8:36 p.m., Ben Mahler wrote: > > s/executor library/executor driver/ - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/#review124276 ---

Review Request 44997: Fixed how we detect C++11 compiler support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44997/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963 https:/

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124401 --- src/slave/flags.cpp (line 681)

Review Request 44944: Handled chunked responses in docker URI fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/ --- Review request for mesos, Gilbert Song, Jojy Varghese, James Peach, and Timothy

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 17, 2016, 10:43 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated March 17, 2016, 9:33 p.m.) Review request for mesos and Michael Park.

Review Request 44894: Remove `Fetcher` in `MesosContainerizer::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44894/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 17, 2016, 2:27 a.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 119 > > > > > > Could you clarify for me how the slave gets into the RESERVED state the > > first time? It s

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 18, 2016, 3:47 a.m.) Review request for mesos, Jie Yu and Jiang

Review Request 45008: Moved command scheduler to use the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/ --- Review request for mesos, Guangya Liu and Vinod Kone. Bugs: MESOS-3559 http

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 17, 2016, 6:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 1 a.m.) Review request for mesos, Adam B and Joerg Sch

Review Request 44993: Updated `TestContainerizer` to support default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 17, 2016, 10:43 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

> On March 15, 2016, 8:11 p.m., Ben Mahler wrote: > > src/executor/executor.cpp, line 703 > > > > > > I'm thinking now that we should trust the value in the environment if > > it's set, rather than overwriting, sinc

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review124281 --- 3rdparty/libprocess/include/process/collect.hpp (line 260)

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 18, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 17, 2016, 6:53 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44998: Fixed m4 macro to enable strict C++11 conformance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44998/#review124133 --- Ship it! Ship It! - Joris Van Remoortere On March 17, 2016,

Review Request 44898: Update containerizer construction in health_check_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44898/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44554: Added agent HTTP authentication to the docs.

> On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/authentication.md, line 45 > > > > > > Does it make to create a 'Master and Slave Options' section similar to > > configuration.md. > > Otherwise we en

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 18, 2016, 2:31 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review124061 --- Thanks Benjamin! The main higher level suggestion here is to add t

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 11, 2016, 6:45 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > > `MesosConta

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling Star

Re: Review Request 44896: Update containerizer construction in disk_quota_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44896/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124129 --- Fix it, then Ship it! This is just a flyby review. Was looking

Review Request 44905: Update containerizer construction in isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44905/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44828/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44911/#review123889 --- Patch looks great! Reviews applied: [44911] Passed command: expo

Re: Review Request 44903: Update containerizer construction in port_mapping_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44903/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review124398 --- docs/authentication.md (line 45)

Review Request 44084: Windows: Forked os::rename().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124399 --- Patch looks great! Reviews applied: [44985, 45000] Passed comman

Re: Review Request 45040: Added a test for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45040/ --- (Updated March 19, 2016, 10:40 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 18, 2016, 1:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody c

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124384 --- Ship it! Ship It! - Adam B On March 18, 2016, 10:28 a.m., Gr

Re: Review Request 44652: Omitted names of unused parameters in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44652/ --- (Updated March 19, 2016, 10:31 a.m.) Review request for mesos, Ben Mahler and J

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124397 --- src/tests/slave_tests.cpp (line 1504)

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/ --- (Updated March 19, 2016, 10:26 a.m.) Review request for mesos and Jie Yu. Bug

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

> On March 19, 2016, 7:08 a.m., haosdent huang wrote: > > In fact zipfile containg duplicates is valid zip. There is a problem with extracting files, becouse `unzip` will prompt user how to deal with it. Forcing overwrite makes unzip works like `tar` and `gunzip`. When zip file is invalid or

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124395 --- src/tests/resource_offers_tests.cpp (line 77)

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124393 --- src/launcher/fetcher.cpp (lines 255 - 256)

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review124394 --- Ship it! Ship It! - Joerg Schad On March 17, 2016, 7:42 p.m.

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124392 --- src/slave/flags.cpp (line 685)

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review124388 --- Ship it! Ship It! - Adam B On March 17, 2016, 12:42 p.m., Gr

Re: Review Request 44901: Update containerizer construction in filesystem_isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44901/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44651: Cleaned up formatting in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/#review124270 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:27 p.m.

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 17, 2016, 1:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 240-244 > > > > > > I think this comment is for static IP addresses. You should be > >

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review124274 --- Looks like the recent test refactor (mine) created more work for y

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124391 --- Ship it! - Joerg Schad On March 18, 2016, 6:13 p.m., Greg Man

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 16, 2016, 8:57 p.m.) Review request for mesos, Avinash sridharan

Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4070 https://issues.apache

Review Request 45001: Replaced const ref to temporary in tests for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45001/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos Descripti

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124385 --- Fix it, then Ship it! Unnecessary summaries, but shippable once

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124350 --- src/master/http.cpp (line 958)

Review Request 45036: Added authentication information to agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45036/ --- Review request for mesos, Adam B and greg-cooke greg-cooke. Repository: mesos

Review Request 45037: Regenerated agent endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45037/ --- Review request for mesos, Adam B and Greg Mann. Repository: mesos Description

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/ --- (Updated March 17, 2016, 5:32 p.m.) Review request for mesos, Adam B and Greg M

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124390 --- src/tests/resource_offers_tests.cpp (lines 84 - 85)

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 17, 2016, 1:39 a.m.) Review request for mesos, Greg Mann, Shuai Lin

Review Request 45007: Fixed `using` declaration order in `mesos-execute`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45007/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3559 https://issues.ap

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 2:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling Star

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124387 --- Fix it, then Ship it! One last question src/tests/mesos.cpp (

Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOs-4828 https:/

<    1   2   3   4   >