Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, please take a look. > Besides, d

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/ --- (Updated 四月 1, 2016, 6:23 a.m.) Review request for mesos and Vinod Kone. Chan

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

> On March 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, please take a look. > Besides

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/#review126552 --- Patch looks great! Reviews applied: [45083, 45084, 45350, 45085,

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. Vinod?thanks for the review. I just resubmit the patch to rebase to the latest code, please take a look. Besides, do I need to submit another patch fo

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/ --- (Updated 四月 1, 2016, 5:57 a.m.) Review request for mesos and Vinod Kone. Chan

Review Request 45360: WIP: Added dvd client for mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:19 a.m.) Review request for mesos, haosdent huang and Co

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:17 a.m.) Review request for mesos, haosdent huang and Co

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:08 a.m.) Review request for mesos, haosdent huang and Co

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 1, 2016, 5:07 a.m.) Review request for mesos, haosdent huang and Co

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review126538 --- Patch looks great! Reviews applied: [45572] Passed command: expo

Re: Review Request 43284: Wait for perf statistics processes exit.

> On Feb. 8, 2016, 10:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > > > > > I think you should discard the future and let it do the correct thin

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126530 --- Patch looks great! Reviews applied: [45571] Passed command: expo

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 462-467 > > > > > > Is it possible that agent crashes when checkpointing the output of CNI > >

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424 > > > > > > I do not think we need this. If agent crashes after removing the > > interf

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated April 1, 2016, 3:06 a.m.) Review request for mesos, Ian Downes, Jan Sc

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated April 1, 2016, 3:05 a.m.) Review request for mesos, Ian Downes, Jan Sc

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

> On April 1, 2016, 2:53 a.m., fan du wrote: > > src/linux/perf.cpp, line 354 > > > > > > Why did you implement the idea I worked out at > > https://issues.apache.org/jira/browse/MESOS-4705 by updating your orignal

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On April 1, 2016, 9:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 380-390 > > > > > > It's also possible that `_cleanup` remove the interface directory and > > then

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126511 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/#review126516 --- src/linux/perf.cpp

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated April 1, 2016, 2:34 a.m.) Review request for mesos, Ben Mahler, Alex C

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/#review126510 --- Patch looks great! Reviews applied: [44378, 45371] Passed comman

Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5047 https://issues.apache

Review Request 45573: Add PerfEventHandleManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5047 https://issues.apache

Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5047 https://issues.apache

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated April 1, 2016, 2:09 a.m.) Review request for mesos, Ian Downes, Jan Sc

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45473/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45353/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45351/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45085: Add cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45083: Added a any mechanism for futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu. Chang

Review Request 45572: Add labels to ExecutorInfo and deprecate source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5029 https://issues.ap

Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-4759

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126477 --- Fix it, then Ship it! Qian, I will submit a subsequent patch to

Re: Review Request 45563: Added recommended config for production to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45563/#review126500 --- Patch looks great! Reviews applied: [45562, 45563] Passed comman

Re: Review Request 45453: Minor spacing cleanups in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45453/#review126499 --- Ship it! Ship It! - Timothy Chen On March 29, 2016, 10:44 p.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126496 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp (lines 45 -

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 1, 2016, 12:01 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 1, 2016, 12:01 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 1, 2016, midnight) Review request for mesos, Jie Yu and Jiang Ya

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 1, 2016, 12:01 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 1, 2016, 12:01 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 1, 2016, midnight) Review request for mesos, Jie Yu and Jiang Ya

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126490 --- Bad patch! Reviews applied: [45213] Failed command: ./support/ap

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 14, 2016, 10:18 p.m., Anand Mazumdar wrote: > > Qian, any updates on this? > > Qian Zhang wrote: > Sorry Anand, I am a little busy on the implementation of CNI support in > Mesos, will get back to this patch soon. Do you still have cycles to work on this? If not, I can ask someo

Re: Review Request 45557: Clean up the health check launcher code in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45557/#review126486 --- Patch looks great! Reviews applied: [4, 45556, 45557] Passed

Review Request 45567: Added an interface to insert `iptables` rules in linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45567/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-5066 https://i

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/#review126481 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 9:49 p.m.,

Re: Review Request 45557: Clean up the health check launcher code in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45557/#review126480 --- Ship it! Ship It! - Timothy Chen On March 31, 2016, 6:52 p.m

Re: Review Request 45555: Fix indent in docker executor health check code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review126479 --- Ship it! Ship It! - Timothy Chen On March 31, 2016, 6:51 p.m

Re: Review Request 45556: Minor style cleanups to docker health check code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45556/#review126478 --- Ship it! Ship It! - Timothy Chen On March 31, 2016, 6:51 p.m

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 151 > > > > > > Should have pointed in the earlier patches, why do we need `Info` to be

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/#review126475 --- Ship it! src/slave/containerizer/mesos/isolators/network/cni/c

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/#review126474 --- Fix it, then Ship it! docs/configuration.md (line 354)

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 31, 2016, 5:12 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 336 > > > > > > Plural? > > > > We often use a trailing understore: `char* directory_[]`.

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 30, 2016, 6:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > I think this is not needed because if recover fails, slave will restart. > > Qian Z

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126469 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 45532: Renamed 'getNetworkInfoDir' to 'getContainerDir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45532/#review126467 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 11:31 a.m., Qi

Re: Review Request 45531: Made 'ROOT_DIR' a shared mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45531/#review126466 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 11:30 a.m., Qi

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126465 --- src/slave/containerizer/mesos/provisioner/docker/registry_puller.

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

> On April 1, 2016, 1:38 a.m., Vinod Kone wrote: > > 3rdparty/zookeeper-3.4.8.patch, line 13 > > > > > > Can you explain in the description what this patch is doing? It's not > > obvious. > > > > How does th

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/ --- (Updated April 1, 2016, 5:49 a.m.) Review request for mesos, Ben Mahler, Alex C

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > include/mesos/master/contender.hpp, line 65 > > > > > > I am wondering if `type` can be replaced with `moduleName` or something > > more explicit. as discussed,

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated April 1, 2016, 5:32 a.m.) Review request for mesos, Ben Mahler, Alex C

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated April 1, 2016, 5:32 a.m.) Review request for mesos, Ben Mahler, Alex C

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/#review126454 --- Bad patch! Reviews applied: [45371, 44378] Failed command: ./sup

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated March 31, 2016, 9:22 p.m.) Review request for mesos, Jie Yu and Neil C

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still no

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still no

Re: Review Request 45553: Minor cleanups in validation logic for operator endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45553/#review126445 --- Patch looks great! Reviews applied: [45553] Passed command: expo

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated March 31, 2016, 9 p.m.) Review request for mesos, Jie Yu and Neil Conw

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/#review126442 --- docs/configuration.md (line 361)

Review Request 45562: Edited `--work_dir` help strings and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- Review request for mesos, Jie Yu and Neil Conway. Bugs: MESOS-5064 https://

Review Request 45563: Added recommended config for production to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45563/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5064 https://issues.apache

Re: Review Request 45553: Minor cleanups in validation logic for operator endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45553/#review126441 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 5:53 p.m.,

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 --- Can you call this out specifically in the CHANGELOG (under "Binary

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review126415 --- Ship it! Looks good! We'll add some comments to the top of the

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126360 --- src/Makefile.am

Review Request 45556: Minor style cleanups to docker health check code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45556/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Descript

Review Request 45557: Clean up the health check launcher code in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45557/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Descript

Review Request 45555: Fix indent in docker executor health check code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Descript

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126405 --- Ship it! Ship It! - Vinod Kone On March 23, 2016, 1:07 p.m.,

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/#review126401 --- can you rebase this? - Vinod Kone On March 31, 2016, 5:14 p.m.,

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still no

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review126395 --- Bad patch! Reviews applied: [45439, 44364, 44366, 44365, 44363, 4

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126388 --- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/

Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/#review126382 --- Ship it! Ship It! - Vinod Kone On March 22, 2016, 8:44 a.m.,

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126376 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

  1   2   >