Re: Review Request 46168: Add subdirectory support to URI.filename field.

2016-04-22 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/#review130235 --- Ship it! Looks great! I'll commit it with the following minor

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/#review130248 --- Patch looks great! Reviews applied: [42806] Passed command:

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/ --- (Updated April 23, 2016, 4:41 a.m.) Review request for mesos, Adam B and

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

2016-04-22 Thread Greg Mann
> On April 22, 2016, 10:26 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/metrics/metrics.hpp, lines 55-58 > > > > > > trailing underscore? See my comment on https://reviews.apache.org/r/46258/ >

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-22 Thread Greg Mann
> On April 22, 2016, 10:24 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/logging.hpp, lines 28-31 > > > > > > Don't we prefere trailing underscores? For function parameters we use leading

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review130245 --- Patch looks great! Reviews applied: [45377] Passed command:

Re: Review Request 46594: Added test for isolator cleanup before prepare.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/#review130242 --- Bad patch! Reviews applied: [46594, 46593, 46577, 46576] Failed

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-04-22 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- (Updated April 23, 2016, 2:33 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- (Updated 四月 23, 2016, 2:16 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 23, 2016, 2:03 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46588: Added URI struct to stout.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated April 22, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46588: Added URI struct to stout.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated April 22, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46580: Added uriparser as a bundled dependency.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/ --- (Updated April 22, 2016, 5:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46220: Added documentation for Nvidia GPU support.

2016-04-22 Thread Qian Zhang
> On April 22, 2016, 5:55 p.m., Qian Zhang wrote: > > docs/gpu-support.md, line 440 > > > > > > Does this limitation mean that currently we do not support container > > with an image (e.g., Docker image, Appc

Re: Review Request 46580: Added uriparser as a bundled dependency.

2016-04-22 Thread Joseph Wu
> On April 22, 2016, 2:14 p.m., Jie Yu wrote: > > 3rdparty/libprocess/configure.ac, line 892 > > > > > > Is this some specicial autoconf thing? I don't see it being used... Oops, that's a leftover from a more

Re: Review Request 46588: Added URI struct to stout.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/#review130232 --- Bad patch! Reviews applied: [46588, 46580] Failed command:

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 242 > > > > > > YOu can iterate through `volumeInfos` here. > > Guangya Liu wrote: > You

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Jie Yu
> On April 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-22 Thread Jie Yu
> On April 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should that be a hashset given that we don't allow duplicate? > > Guangya

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Jie Yu
> On April 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Review Request 46594: Added test for isolator cleanup before prepare.

2016-04-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy

Review Request 46593: Added test for containerizer destroy while provisioning race.

2016-04-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46593/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy

Re: Review Request 45674: Implemented recover() for dvd isolator.

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 10:20 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 181-185 > > > > > > Please do not copy the comments blindly. The comments here does not

Review Request 46588: Added URI struct to stout.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should that be a hashset given that we don't allow duplicate? The problem is

Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli mount".

2016-04-22 Thread Guangya Liu
> On 四月 22, 2016, 5:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp, lines > > 56-65 > > > > > > I think what we should do here is: > > > > 1) If 'options' is

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

2016-04-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130206 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (lines

Re: Review Request 46577: Fixed isolator cleaup issue when destroying a provisioning container.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46577/#review130207 --- Ship it! Ship It! - Jie Yu On April 22, 2016, 6:21 p.m.,

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 --- Fix it, then Ship it! Ship It!

Re: Review Request 46576: Fixed a mesos containerizer race destroy while preparing.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46576/#review130205 --- Ship it! Ship It! - Jie Yu On April 22, 2016, 6:20 p.m.,

Re: Review Request 45671: Added version checking for dvdcli.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/#review130202 ---

Re: Review Request 45674: Implemented recover() for dvd isolator.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130197 ---

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/#review130180 --- src/slave/main.cpp (line 232)

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/#review130201 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 4:21

Re: Review Request 46577: Fixed isolator cleaup issue when destroying a provisioning container.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46577/#review130199 --- Patch looks great! Reviews applied: [46576, 46577] Passed

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130193 ---

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review130196 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review130192 ---

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review130185 --- 3rdparty/libprocess/include/process/windows/winsock.hpp (line

Re: Review Request 46550: Fixed slave to initialize libprocess before modules.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130186 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 1:41

Re: Review Request 46580: Added uriparser as a bundled dependency.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/#review130179 --- Fix it, then Ship it!

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/#review130183 --- Ship it! Ship It! - Joris Van Remoortere On April 20, 2016,

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/#review130182 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:10

Re: Review Request 46391: Clarified several agent log messages.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/#review130177 --- Patch looks great! Reviews applied: [46391] Passed command:

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review130172 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:28

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review130171 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:58

Re: Review Request 46391: Clarified several agent log messages.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/#review130170 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 3:28

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130165 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 3:15

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130161 --- Patch looks great! Reviews applied: [46469] Passed command:

Re: Review Request 46504: Constructed error string in MethodNotAllowed.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46504/#review130103 --- For posterity, could you please explain a bit in the description

Re: Review Request 46550: Fixed slave to initialize libprocess before modules.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130160 --- Ship it! Ship It! - Joseph Wu On April 21, 2016, 6:41 p.m.,

Re: Review Request 46551: Experimental: Use liburiparser to parse URIs.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46551/ --- (Updated April 22, 2016, 12:24 p.m.) Review request for mesos, Gilbert Song,

Review Request 46580: Added uriparser as a bundled dependency.

2016-04-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/ --- Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/ --- (Updated April 22, 2016, 7:14 p.m.) Review request for mesos, Adam B and

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130133 ---

Re: Review Request 45922: Added agent authorization flags.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review130153 --- Patch looks great! Reviews applied: [45922] Passed command:

Review Request 46577: Fixed isolator cleaup issue when destroying a provisioning container.

2016-04-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46577/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy

Review Request 46576: Fixed a mesos containerizer race destroy while preparing.

2016-04-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46576/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Neil Conway. Bugs:

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 22, 2016, 7:46 p.m.) Review request for mesos, Adam B,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 22, 2016, 7:35 p.m.) Review request for mesos, Adam B,

Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli mount".

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45275/#review130125 --- src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- (Updated April 22, 2016, 5:10 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46220: Added documentation for Nvidia GPU support.

2016-04-22 Thread Kevin Klues
> On April 22, 2016, 9:55 a.m., Qian Zhang wrote: > > docs/gpu-support.md, line 440 > > > > > > Does this limitation mean that currently we do not support container > > with an image (e.g., Docker image, Appc

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/ --- (Updated April 22, 2016, 4:40 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 22, 2016, 4:39 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- (Updated April 22, 2016, 4:40 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 4:40 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review130116 --- Patch looks great! Reviews applied: [46321, 46491, 46322, 46323,

Re: Review Request 46075: Update docs to reflect /containers endpoint.

2016-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46075/#review130115 --- Ship it! Ship It! - Jie Yu On April 18, 2016, 3:39 a.m.,

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

2016-04-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 22, 2016, 4:13 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/#review130113 --- Ship it! Ship It! - Neil Conway On April 22, 2016, 4:10

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130112 --- Fix it, then Ship it! Ship It! src/master/http.cpp (line

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- (Updated April 22, 2016, 4:11 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 4:11 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 22, 2016, 4:11 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/ --- (Updated April 22, 2016, 4:10 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > > > haosdent huang wrote: > Hi, @neilc. Thank you very much for your detail comments! I saw you use > `is xxed` in some comments while use `was xxed` in others. Should I change > all of them to `was xxed` to keep consistent? > > Neil

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- (Updated April 22, 2016, 3:48 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > > > haosdent huang wrote: > Hi, @neilc. Thank you very much for your detail comments! I saw you use > `is xxed` in some comments while use `was xxed` in others. Should I change > all of them to `was xxed` to keep consistent? Good

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 22, 2016, 3:47 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 3:48 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > src/master/http.cpp, line 1307 > > > > > > "Returns 200 OK when the weight update was successful." > > haosdent huang wrote: > Should it be `the weights

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > Hi, @neilc. Thank you very much for your detail comments! I saw you use `is xxed` in some comments while use `was xxed` in others. Should I change all of them to `was xxed` to keep consistent? - haosdent

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > src/master/http.cpp, line 1307 > > > > > > "Returns 200 OK when the weight update was successful." Should it be `the weights update` here? - haosdent

Re: Review Request 46391: Clarified several agent log messages.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/ --- (Updated April 22, 2016, 3:28 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/#review130101 --- docs/high-availability.md (line 29)

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-22 Thread Tim Anderegg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/ --- (Updated April 22, 2016, 3:15 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130099 --- src/master/http.cpp (line 335)

Re: Review Request 46505: Removed MethodNotAllowed error string creation.

2016-04-22 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46505/ --- (Updated April 22, 2016, 3:11 p.m.) Review request for mesos and Alexander

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

2016-04-22 Thread haosdent huang
> On April 19, 2016, 3:37 p.m., Neil Conway wrote: > > Can we update the docs to describe this behavior? e.g., add a note to > > https://mesos.apache.org/documentation/latest/endpoints/ describing the > > redirect behavior -- I suppose it is worth adding a note to every master > > endpoint's

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130097 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

2016-04-22 Thread Alexander Rukletsov
> On April 21, 2016, 9:56 p.m., Ben Mahler wrote: > > Could you pull out the 'killed' bug fix? Any reason it's bundled in this > > patch? Will do. - Alexander --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 22, 2016, 2:46 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

2016-04-22 Thread Alexander Rukletsov
> On April 21, 2016, 9:56 p.m., Ben Mahler wrote: > > src/launcher/http_command_executor.cpp, lines 172-176 > > > > > > Wrap at the paren: > > > > ``` > > kill(event.kill().task_id(), > >

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 22, 2016, 2:38 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46322: Added KillPolicy to scheduler and executor Kill protobuf messages.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46322/ --- (Updated April 22, 2016, 2:37 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated April 22, 2016, 2:36 p.m.) Review request for mesos, Benjamin Bannier

  1   2   >