Re: Review Request 52735: Removed TODO message for docker killing.

> On 十一月 8, 2016, 3:24 a.m., Guangya Liu wrote: > > I would suggest that you create a patch chain based on the following order: > > > > https://reviews.apache.org/r/52735/ > > https://reviews.apache.org/r/50128/ > > https://reviews.apache.org/r/50947/ > > https://reviews.apache.org/r/53532/ > >

Re: Review Request 53352: Updated 'LinuxLauncher->fork()` with *enter* and *clone* namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53352/#review13 --- Ship it! Ship It! - Jie Yu On Nov. 8, 2016, 9:54 p.m.,

Re: Review Request 53351: Added 'ContainerClass' to help decide how best to launch a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53351/#review155549 --- Ship it! Ship It! - Jie Yu On Nov. 4, 2016, 9:32 p.m.,

Re: Review Request 53585: Added a default PATH environment variable when launching a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53585/#review155548 --- Ship it! Ship It! - Jie Yu On Nov. 8, 2016, 9:49 p.m.,

Re: Review Request 53623: Windows: Fixed provisioner copy backend build error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53623/#review155547 --- Fix it, then Ship it!

Re: Review Request 53623: Windows: Fixed provisioner copy backend build error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53623/#review155541 --- Patch looks great! Reviews applied: [53623] Passed command:

Review Request 53623: Windows: Fixed provisioner copy backend build error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53623/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 53636: Fix test ROOT_WriteAccessSharedPersistentVolumeReadOnlyMode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53636/#review155522 --- Ship it! Ship It! - Jiang Yan Xu On Nov. 9, 2016, 4:24

Review Request 53636: Fix test ROOT_WriteAccessSharedPersistentVolumeReadOnlyMode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53636/ --- Review request for mesos, Greg Mann and Jiang Yan Xu. Repository: mesos

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/#review155508 --- Mostly some questions here about whether we can simplify the

Re: Review Request 53624: Use JSON content type in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/#review155518 --- Patch looks great! Reviews applied: [53624] Passed command:

Review Request 53628: Document the namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53628/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6556

Review Request 53627: Implement a namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6556

Review Request 53626: Add net::setDomainname() helper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6556

Re: Review Request 53624: Use JSON content type in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/#review155505 --- src/cli/execute.cpp (line 358)

Review Request 53624: Use JSON content type in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 53490: Added a test for request streaming via the connection abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53490/#review155502 --- What you have looks good, I would just suggest that you also

Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review155500 --- bin/mesos-local-flags.sh.in (lines 19 - 20)

Re: Review Request 52919: Allowed to pass extra envs when launch development scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52919/#review155497 --- Ship it! I would update the description with a bit more detail

Re: Review Request 53615: Cleaned up formatting in home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53615/#review155496 --- Patch looks great! Reviews applied: [53610, 53611, 53612, 53613,

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53559/ --- (Updated Nov. 9, 2016, 8:26 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review155490 --- Ship it! Lots great, thanks a lot. - Benjamin Bannier On

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review155492 --- Ship it! Lots great, thanks a lot. - Benjamin Bannier On

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review155491 --- Ship it! Lots great, thanks a lot. - Benjamin Bannier On

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 9, 2016, 7:37 p.m.) Review request for mesos, James Peach,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 9, 2016, 7:37 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 9, 2016, 7:07 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release this

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 9, 2016, 7:05 p.m.) Review request for mesos, James Peach,

Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51624/#review155474 --- Ship it! Ship It! - Zhitao Li On Oct. 8, 2016, 12:37 p.m.,

Re: Review Request 52919: Allowed to pass extra envs when launch development scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52919/#review155470 --- Patch looks great! Reviews applied: [52856, 52787, 52919]

Re: Review Request 53509: Changed mesos-execute --master flag parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53509/#review155469 --- Ship it! Ship It! - Joseph Wu On Nov. 7, 2016, 6:01 p.m.,

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

> On Nov. 8, 2016, 1:43 a.m., Gastón Kleiman wrote: > > 3rdparty/libprocess/src/process.cpp, line 201 > > > > > > ditto > > Gastón Kleiman wrote: > @joseph: do you know what libprocess advertises if this is set

Re: Review Request 53610: Added health checks documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/#review155454 --- docs/health-checks.md (line 6)

Re: Review Request 53611: Improved comments around health checks in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53611/#review155453 --- Ship it! Ship It! - haosdent huang On Nov. 9, 2016, 5:05

Review Request 53610: Added health checks documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/ --- Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till

Re: Review Request 53613: Fixed style issues in quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53613/ --- (Updated Nov. 9, 2016, 5:09 p.m.) Review request for mesos, Joerg Schad and

Review Request 53615: Cleaned up formatting in home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53615/ --- Review request for mesos, Joerg Schad and Neil Conway. Repository: mesos

Review Request 53613: Fixed style issues in quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53613/ --- Review request for mesos, Joerg Schad and Neil Conway. Repository: mesos

Review Request 53614: Updated the markdown style guide with headings capitalization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53614/ --- Review request for mesos, Joerg Schad and Neil Conway. Repository: mesos

Review Request 53612: Fixed minor style issues in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53612/ --- Review request for mesos, Joerg Schad and Neil Conway. Repository: mesos

Review Request 53611: Improved comments around health checks in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53611/ --- Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till

Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.

> On Nov. 3, 2016, 3:55 p.m., Kevin Klues wrote: > > src/local/flags.hpp, lines 35-52 > > > > > > I don't think we should have a flag for `temp_dir` here. We should > > still have separate flags for `work_dir` and

Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Nov. 9, 2016, 4:53 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 52919: Allowed to pass extra envs when launch development scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52919/ --- (Updated Nov. 9, 2016, 4:51 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Nov. 9, 2016, 4:51 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 52856: Reverted incorrect changes in 1c2ee5c.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52856/ --- (Updated Nov. 9, 2016, 4:50 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

> On Nov. 8, 2016, 9:43 a.m., Gastón Kleiman wrote: > > 3rdparty/libprocess/src/process.cpp, line 183 > > > > > > Shoulnd't port `0` be rejected? AFAIK it is not a valid port. > > Joseph Wu wrote: > Port zero

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review155426 --- Patch looks great! Reviews applied: [52600, 53057, 53058, 53541]

Re: Review Request 53500: Used an environment variable to pass command environment.

> On Nov. 9, 2016, 10:37 a.m., Gastón Kleiman wrote: > > The Docker containerizer still passes the env variables to the executor > > through cmd line flags, we might want to fix that as well: > > > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L244 > >

Re: Review Request 53601: Fixed typos in the changelog and in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53601/#review155421 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 9, 2016,

Re: Review Request 53500: Used an environment variable to pass command environment.

> On Nov. 9, 2016, 10:37 a.m., Gastón Kleiman wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1401 > > > > > > There's a typo here, it should be `launch` instead of `lauch.`

Review Request 53601: Fixed typos in the changelog and in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53601/ --- Review request for mesos, Alexander Rukletsov and Jiang Yan Xu. Repository:

Re: Review Request 53500: Used an environment variable to pass command environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53500/#review155417 --- The Docker containerizer still passes the env variables to the

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review155415 --- Patch looks great! Reviews applied: [52647, 52886, 52754, 52645,