Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156385 --- Patch looks great! Reviews applied: [53704, 53837] Passed

Review Request 53927: Check isJailed in tests that call mknod.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53927/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6612 and MESOS-6613

Review Request 53926: Move isJailed for FreeBSD into utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53926/ --- Review request for mesos and Ian Downes. Bugs: MESOS-5644

Review Request 53925: Fix wait macros on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53925/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6611

Re: Review Request 53879: Removed duplicate note.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53879/#review156384 --- Ship it! Ship It! - Vinod Kone On Nov. 18, 2016, 4:23 p.m.,

Re: Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53574/#review156381 --- src/tests/command_executor_tests.cpp (lines 266 - 268)

Re: Review Request 53573: Added the kill policy test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53573/#review156379 --- src/tests/kill_policy_test_helper.hpp (line 36)

Re: Review Request 52544: Introduced `int_fd` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156376 --- 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/#review156377 --- After discussion offline, there seems to be some interesting

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156374 --- Patch looks great! Reviews applied: [53790, 53791] Passed

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 19, 2016, 1:27 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 52295: Added additional unit tests for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review156368 --- Patch looks great! Reviews applied: [52295] Passed command:

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review156367 --- m4/ax_check_compile_flag.m4 (line 61)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review156362 --- Fix it, then Ship it! src/common/resources.cpp (lines 792 -

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/#review156326 --- src/master/allocator/mesos/hierarchical.cpp (lines 752 - 755)

Re: Review Request 53882: Fix configure on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/ --- (Updated Nov. 19, 2016, 12:11 a.m.) Review request for mesos and Ian Downes.

Review Request 53913: Disable sentinel checks for clang on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53913/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6610

Review Request 53912: Fix xattr for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53912/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6609

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review156353 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 52544: Introduced `int_fd` class.

> On Nov. 16, 2016, 4:57 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 36-38 > > > > > > What are these for? > > Daniel Pravat wrote: > closed is used to detect

Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53790/ --- (Updated Nov. 18, 2016, 10:54 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 1:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 18, 2016, 9:57 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156341 --- Patch looks great! Reviews applied: [53877] Passed command:

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 18, 2016, 9:08 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 18, 2016, 8:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

> On Nov. 18, 2016, 3:28 p.m., Gastón Kleiman wrote: > > src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp, line 38 > > > > > > shouldn't this include be the first one in the file? > > Kevin Klues

Re: Review Request 53882: Fix configure on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/#review156336 --- Patch looks great! Reviews applied: [53882] Passed command:

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156333 --- Anand Mazumdar - Could you please take a look at the patch? -

Re: Review Request 52295: Added additional unit tests for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- (Updated Nov. 18, 2016, 7:49 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52295: Added additional unit tests for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- (Updated Nov. 18, 2016, 7:48 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Nov. 18, 2016, 1:24 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/rootfs.cpp, lines 81-84 > > > > > > If we have to do this, format it this way > > > > ``` > > auto entry = std::find_if( > >

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Nov. 18, 2016, 7:23 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Nov. 18, 2016, 1:24 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/rootfs.cpp, line 234 > > > > > > Would the following look better? > > > > ``` > > hashset needed(programs.begin(),

Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.

> On Nov. 17, 2016, 9:47 p.m., Jiang Yan Xu wrote: > > src/Makefile.am, line 1019 > > > > > > Keep the header file here? > > James Peach wrote: > I moved it because it makes no sense to specify files that are

Review Request 53896: Refactored representation of framework connectedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53896/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53790/ --- (Updated Nov. 18, 2016, 7:21 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53895/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53894: Added helper function, `Master::isCompletedFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53894/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53893: Avoided sending `LostSlaveMessage` to disconnected frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53893/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53892: Fixed typo, removed hard tab character.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53892/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53891: Replaced "slave" with "agent" in status update messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53891/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53890: Tweaked slave removal logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53890/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53889: Improved comments in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53889/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53888: Improved SlaveRecoveryTest.ReconcileShutdownFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53888/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53887: Improved FaultToleranceTest.FrameworkReregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53887/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53886: Improved TeardownTest.Success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53886/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Review Request 53885: Removed stuttering from teardown test names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53885/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419

Re: Review Request 53515: Fixed a typo in slave_recovery_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53515/#review156323 --- Ship it! Ship It! - Jiang Yan Xu On Nov. 6, 2016, 4:47

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ --- (Updated Nov. 18, 2016, 6:18 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.

> On Nov. 17, 2016, 9:47 p.m., Jiang Yan Xu wrote: > > src/Makefile.am, line 1019 > > > > > > Keep the header file here? I moved it because it makes no sense to specify files that are part of `mesos-tests` in the

Review Request 53882: Fix configure on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6607

Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53790/ --- (Updated Nov. 18, 2016, 6:08 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53879: Removed duplicate note.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53879/#review156320 --- Patch looks great! Reviews applied: [53879] Passed command:

Re: Review Request 53877: Added temporary file environment passing towards docker.

> On Nov. 18, 2016, 4:52 p.m., Gastón Kleiman wrote: > > src/docker/docker.cpp, lines 557-561 > > > > > > Do we need the tmp dir? > > > > The CNI port mapper plugin doesn't create one for its tmp file: > >

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

> On Nov. 18, 2016, 3:28 p.m., Gastón Kleiman wrote: > > src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp, line 38 > > > > > > shouldn't this include be the first one in the file? > > Kevin Klues

Re: Review Request 53289: Updated favicon.ico.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53289/#review156315 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 30, 2016,

Re: Review Request 53288: Updated the brand in navbar to Mesos logo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53288/#review156314 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016,

Re: Review Request 53287: Overrided the default navbar color to match project website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53287/#review156313 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016,

Re: Review Request 53286: Applied material style in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53286/#review156312 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016,

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

> On Nov. 18, 2016, 3:28 p.m., Gastón Kleiman wrote: > > src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp, line 38 > > > > > > shouldn't this include be the first one in the file? We typically don't

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156306 --- src/docker/docker.cpp (lines 556 - 560)

Re: Review Request 52295: Added additional unit tests for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review156275 --- Fix it, then Ship it!

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ --- (Updated Nov. 18, 2016, 4:36 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Nov. 18, 2016, 4:27 p.m.) Review request for mesos, James Peach,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Nov. 18, 2016, 4:24 p.m.) Review request for mesos, James Peach,

Review Request 53879: Removed duplicate note.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53879/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, line 21 > > > > > > `#include ` My fault, I have no idea why I decided to add a .h at the time :) - Aaron

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156303 --- Bad patch! Reviews applied: [53877] Failed command:

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ --- (Updated Nov. 18, 2016, 3:39 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 53837: Added a per container mesos-io-switchboard process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/#review156294 --- src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ --- (Updated Nov. 18, 2016, 3:09 p.m.) Review request for mesos, Adam B, Gastón

Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ --- Review request for mesos, Adam B, Gastón Kleiman, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156293 --- src/examples/persistent_volume_framework.cpp (line 150)

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156292 --- src/examples/persistent_volume_framework.cpp (line 265)

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156291 --- Patch looks great! Reviews applied: [53825] Passed command:

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/#review156286 --- Ship it! src/health-check/health_checker.cpp (line 369)

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 18, 2016, 8:04 a.m.) Review request for mesos, Anand Mazumdar