Review Request 54620: Removed "enable_io_switchboard_server" agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54620/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Kevin Klues. Repository:

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review158750 --- src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 408)

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On Dec. 9, 2016, 4:37 p.m., Jiang Yan Xu wrote: > > Can we add a simple test for `isQuotaEnabled()` in ROOT_XFS_QuotaTest? > > James Peach wrote: > I didn't add a new test because I reasoned that this is implicitly tested > already, like `pathIsXfs`. Implicitly testing it is fine and I w

Review Request 54618: Windows: Added `http_tests.cpp` and `type_utils_tests.cpp` to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54618/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54489/#review158749 --- Note: This review breaks the `IOSwitchboardServerTests` on OSX onl

Re: Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54489/#review158747 --- Ship it! I don't know about the Windows helpers used in the Win

Re: Review Request 53803: Added new libprocess socket tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/ --- (Updated Dec. 10, 2016, 1:31 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 54611: Windows: Added `recordio_tests.cpp` to Agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54611/ --- (Updated Dec. 10, 2016, 1:29 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/ --- (Updated Dec. 10, 2016, 1:19 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Dec. 10, 2016, 1:19 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Dec. 10, 2016, 1:19 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

> On Nov. 30, 2016, 8:51 a.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, line 1927 > > > > > > No empty lines here. Ok. Although I do see patterns without { } and / or with empty lines. > On Nov. 30, 201

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Dec. 10, 2016, 1:19 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On Dec. 10, 2016, 12:37 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp, lines 110-120 > > > > > > We check > > > > ``` > > if (!xfs::pathIsXfs(flags.work_dir)) {

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/ --- (Updated Dec. 10, 2016, 1:14 a.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp.

> On Dec. 10, 2016, 12:14 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/posix/temp.hpp, lines 31-35 > > > > > > I'm going to change this to: > > ``` > > return tmpdir.getOrElse("/tmp"); > > ``

Re: Review Request 54529: Exposed framework roles in master and agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54529/#review158744 --- Ship it! Modulo discussion in the comments. - Benjamin Mahler

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On Dec. 10, 2016, 12:37 a.m., Jiang Yan Xu wrote: > > configure.ac, line 1768 > > > > > > Is this change for `Q_XGETQSTATV` and `FS_QSTATV_VERSION1`? > > > > At least explain this (and the change of varia

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/ --- (Updated Dec. 9, 2016, 4:50 p.m.) Review request for mesos, Joseph Wu and Vinod

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On Dec. 10, 2016, 12:37 a.m., Jiang Yan Xu wrote: > > Can we add a simple test for `isQuotaEnabled()` in ROOT_XFS_QuotaTest? I didn't add a new test because I reasoned that this is implicitly tested already, like `pathIsXfs`. - James ---

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On Dec. 10, 2016, 12:37 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 407 > > > > > > Remove redundant space: > > > > ``` > > struct fs_quota_statv statv = {

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review158737 --- Ship it! Ship It! - Joseph Wu On Nov. 23, 2016, 10:34 a.m.,

Re: Review Request 54529: Exposed framework roles in master and agent endpoints.

> On Dec. 8, 2016, 7:59 p.m., Benjamin Mahler wrote: > > src/master/http.cpp, lines 210-211 > > > > > > In the case of a multi-role framework with two roles ("role1", "role2") > > the json here would display: > >

Re: Review Request 52938: Added temporary disabled TEST_P macro for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52938/#review158735 --- Ship it! Ship It! - Joseph Wu On Nov. 22, 2016, 11:52 a.m.,

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review158517 --- Can we add a simple test for `isQuotaEnabled()` in ROOT_XFS_QuotaT

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Dec. 10, 2016, 12:33 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 54490: Move POSIX-specific temporary directory selection out of Agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54490/#review158480 --- Ship it! LGTM. - Joseph Wu On Dec. 7, 2016, 11:06 a.m., Alex

Re: Review Request 54610: Windows: qualify string, map, vector in `subprocess.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54610/#review158733 --- Ship it! Ship It! - Joseph Wu On Dec. 9, 2016, 1:30 p.m., An

Re: Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54489/#review158618 --- Fix it, then Ship it! 3rdparty/stout/include/stout/os/posix/te

Re: Review Request 54589: Improved operator HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54589/#review158732 --- Patch looks great! Reviews applied: [54589] Passed command: expo

Re: Review Request 54519: Stout: Moved `os::getenv` from `os.hpp` -> `os/getenv.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54519/#review158614 --- Ship it! LGTM. I'm going to reword a bit of the description

Re: Review Request 54611: Windows: Added `recordio_tests.cpp` to Agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54611/ --- (Updated Dec. 9, 2016, 11:59 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 52461: Ported apply-reviews.py script to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52461/#review158729 --- I like this, but in the same vein we are still calling `git` the C

Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/ --- Review request for mesos, Benjamin Bannier, Alex Clemmer, and Joseph Wu. Bugs:

Re: Review Request 54571: Timed health check duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54571/#review158726 --- Patch looks great! Reviews applied: [54570, 54571] Passed comman

Review Request 54611: Windows: Added `recordio_tests.cpp` to Agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54611/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 54610: Windows: qualify string, map, vector in `subprocess.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54610/ --- (Updated Dec. 9, 2016, 9:30 p.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54587/ --- (Updated Dec. 9, 2016, 9:29 p.m.) Review request for mesos and Jie Yu. Summar

Review Request 54610: Windows: qualify string, map, vector in `subprocess.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54610/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Descr

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Dec. 9, 2016, 9:26 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

> On Dec. 9, 2016, 1 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 366-367 > > > > > > Let's remove this part of the case: > > > > ``` > > events & BEV_EVENT_ERR

Re: Review Request 54587: Introduce a ScaleTestContainerizer suitable for scale testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54587/ --- (Updated Dec. 9, 2016, 9:20 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

> On Dec. 9, 2016, 7:45 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 400-402 > > > > > > Any reason this is in the locked section? The implication of it being > > locked it

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Dec. 9, 2016, 9:19 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 54607: Add Andrew Schwartzmeyer to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54607/#review158721 --- Ship it! Ship It! - Alex Clemmer On Dec. 9, 2016, 7:51 p.m.,

Re: Review Request 54524: Updated `resources()` method to return resources used by role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/#review158717 --- Ship it! This could benefit from a clearer commit summary and d

Re: Review Request 54493: Turned off Master's auth flags tests when platform doesn't support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54493/ --- (Updated Dec. 9, 2016, 7:56 p.m.) Review request for mesos, Andrew Schwartzmeye

Review Request 54607: Add Andrew Schwartzmeyer to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54607/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Descr

Re: Review Request 54493: Turned off Master's auth flags tests when platform doesn't support it.

> On Dec. 9, 2016, 1:59 a.m., Joseph Wu wrote: > > src/tests/mesos.cpp, lines 203-205 > > > > > > We shouldn't need to set this flag to `None()` explicitly. It should > > default to such. I actually prefer explici

Re: Review Request 54410: Made the style of the cluster name consistent with others.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54410/#review158716 --- If it looks the same as the other navbar tabs, it seems clickable?

Re: Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54489/ --- (Updated Dec. 9, 2016, 7:47 p.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/#review158710 --- Fix it, then Ship it! Looks good to me. I just added another su

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

> On Dec. 9, 2016, 1 a.m., Benjamin Mahler wrote: > > I went over this with Greg. > > > > This looks good, some suggestions around some of the existing logic that we > > should fix. > > > > Also, some other items: > > > > (1) It looks like the shutdown override is no longer overriding. The co

Re: Review Request 54570: Added comments around some health check limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54570/#review158708 --- Ship it! Ship It! - haosdent huang On Dec. 9, 2016, 3:11 p.m

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Dec. 9, 2016, 7:10 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 54597: Introduced an `os::pipe` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54597/#review158699 --- 3rdparty/stout/include/stout/os/windows/pipe.hpp (line 27)

Review Request 54597: Introduced an `os::pipe` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54597/ --- Review request for mesos. Repository: mesos Description --- Introduced a

Re: Review Request 54589: Improved operator HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54589/ --- (Updated Dec. 9, 2016, 5:17 p.m.) Review request for mesos and Vinod Kone. Ch

Review Request 54589: Improved operator HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54589/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 54524: Updated `resources()` method to return resources used by role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/ --- (Updated Dec. 10, 2016, 12:57 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 54570: Added comments around some health check limitations.

> On Dec. 9, 2016, 3:46 p.m., Till Toenshoff wrote: > > docs/health-checks.md, line 306 > > > > > > I wonder how significant this overhead is. Do we have any profiling > > information we could add to the ticket for

Re: Review Request 54571: Timed health check duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54571/#review158687 --- Ship it! Ship It! - Till Toenshoff On Dec. 9, 2016, 4:23 p.m

Re: Review Request 54571: Timed health check duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54571/ --- (Updated Dec. 9, 2016, 4:23 p.m.) Review request for mesos, Gastón Kleiman, hao

Re: Review Request 54571: Timed health check duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54571/ --- (Updated Dec. 9, 2016, 4:19 p.m.) Review request for mesos, Gastón Kleiman, hao

Re: Review Request 54570: Added comments around some health check limitations.

> On Dec. 9, 2016, 3:46 p.m., Till Toenshoff wrote: > > docs/health-checks.md, line 306 > > > > > > I wonder how significant this overhead is. Do we have any profiling > > information we could add to the ticket for

Review Request 54587: Introduce a ScaleTestContainerizer suitable for scale testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54587/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6768 https://issues.apache

Re: Review Request 54570: Added comments around some health check limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54570/#review158684 --- Ship it! docs/health-checks.md (line 306)

Re: Review Request 54535: WIP: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54535/ --- (Updated Dec. 9, 2016, 4:32 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 54538: WIP: Enabled fine grained authorization for the getContainers API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/ --- (Updated Dec. 9, 2016, 4:33 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 54570: Added comments around some health check limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54570/ --- (Updated Dec. 9, 2016, 3:11 p.m.) Review request for mesos, Gastón Kleiman, hao

Re: Review Request 54571: Timed health check duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54571/ --- (Updated Dec. 9, 2016, 3:11 p.m.) Review request for mesos, Gastón Kleiman, hao

Re: Review Request 54570: Added comments around some health check limitations.

> On Dec. 9, 2016, 4:33 a.m., haosdent huang wrote: > > docs/health-checks.md, line 282 > > > > > > Should be `e.g., 0.05 xx` here? I refer to > > https://en.wiktionary.org/wiki/e.g. Yup, you're right. - Alexande

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Dec. 9, 2016, 2:38 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 54182: Improved various comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54182/ --- (Updated Dec. 9, 2016, 2:37 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 54553: Removed `using namespace` decl from slave namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54553/#review158679 --- Ship it! Ship It! - Till Toenshoff On Dec. 8, 2016, 11:05 p.

Re: Review Request 54554: Do not assume std symbols are visible without using FQN.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54554/#review158678 --- Ship it! Ship It! - Till Toenshoff On Dec. 8, 2016, 11:05 p.

Re: Review Request 54555: Removed using declarations in headers in global scope in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54555/#review158677 --- Ship it! Ship It! - Till Toenshoff On Dec. 8, 2016, 11:05 p.

Re: Review Request 54529: Exposed framework roles in master and agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54529/#review158674 --- Patch looks great! Reviews applied: [54529] Passed command: expo

Re: Review Request 54205: Improved equality check in SlaveTest.StateEndpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54205/#review158673 --- Ship it! Ship It! - Till Toenshoff On Dec. 8, 2016, 1:57 p.m

Re: Review Request 54524: Updated `resources()` method to return resources used by role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/#review158669 --- Fix it, then Ship it! Ship It! src/master/master.hpp (line 26

Re: Review Request 54524: Updated `resources()` method to return resources used by role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/#review158666 --- Patch looks great! Reviews applied: [54524] Passed command: expo

Re: Review Request 54529: Exposed framework roles in master and agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54529/ --- (Updated Dec. 9, 2016, 11:09 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 54529: Exposed framework roles in master and agent endpoints.

> On Dec. 8, 2016, 8:59 p.m., Benjamin Mahler wrote: > > src/master/http.cpp, lines 210-211 > > > > > > In the case of a multi-role framework with two roles ("role1", "role2") > > the json here would display: > >

Re: Review Request 54538: WIP: Enabled fine grained authorization for the getContainers API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158661 --- src/slave/http.cpp (line 1826)

Re: Review Request 54535: WIP: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54535/#review158660 --- I'm a bit confused why we don't just have a simple single `ViewCon

Re: Review Request 54524: Updated `resources()` method to return resources used by role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/ --- (Updated Dec. 9, 2016, 5:39 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/ --- (Updated Dec. 9, 2016, 5:38 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 54524: Updated `resources()` method to return resources used by role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54524/#review158653 --- Bad review! Reviews applied: [54524, 54365, 54361] Error: Circul