Re: Review Request 56681: Use glog to log EXIT() messages.

> On March 20, 2017, 1:32 p.m., Benjamin Mahler wrote: > > Have you seen the feedback > > [here](https://issues.apache.org/jira/browse/MESOS-3465?focusedCommentId=14944383=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14944383)? > > It would be nice to make it clear

Re: Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

> On May 8, 2017, 8:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/paths.cpp > > Lines 210 (patched) > > > > > > Why `isdir`? not os::exists? > > Gilbert Song wrote: > Following the patern

Re: Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59061/#review174257 --- Patch looks great! Reviews applied: [59061] Passed command:

Re: Review Request 59015: Implemented passing docker config to URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174256 ---

Re: Review Request 59014: Implemented resolving an image secret in registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59014/#review174255 --- Ship it! Ship It! - Vinod Kone On May 5, 2017, 8:30 p.m.,

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174253 --- Ship it!

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

> On May 5, 2017, 11:55 p.m., Chun-Hung Hsiao wrote: > > Should we use a shared pointer for `SecretResolver` instead of passing a > > `SecretResolver*` around? +1. Since provisioner and env isolator are both sharing the pointer, it's probably worth having the containerizer take in a shared

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/#review174251 --- Updated summary/description to "SecretResolver"

Re: Review Request 59011: Fixed docker/appc store 'using' format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59011/#review174250 --- Ship it! Ship It! - Vinod Kone On May 4, 2017, 11:22 p.m.,

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59010/#review174249 --- Ship it! Ship It! - Vinod Kone On May 5, 2017, 8:30 p.m.,

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review174246 --- src/slave/containerizer/mesos/containerizer.cpp Lines 226

Re: Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

> On May 8, 2017, 1:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/paths.cpp > > Lines 210 (patched) > > > > > > Why `isdir`? not os::exists? Following the patern in this file. We are only

Re: Review Request 58999: Added --secret_resolver flag to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/#review174242 --- src/slave/containerizer/containerizer.hpp Lines 33 (patched)

Re: Review Request 58760: Added default secret resolver module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/#review174240 --- Fix it, then Ship it! src/secret/resolver.cpp Lines 40

Re: Review Request 58759: Introduced SecretResolver module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review174238 --- Fix it, then Ship it! include/mesos/module.hpp Lines 113

Review Request 59074: Updated all tests that use Containerizer::launch(...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59074/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304 and MESOS-7449

Review Request 59073: Updated Docker containerizer tests to use the old naming scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59073/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Re: Review Request 58910: Addressed a TODO about checkpointing in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/ --- (Updated May 8, 2017, 4:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59068: Updated release/versioning docs for "-dev" version scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59068/#review174236 --- docs/release-guide.md Lines 150 (patched)

Re: Review Request 58908: Updated test mocks per interface changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58908/ --- (Updated May 8, 2017, 3:45 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 58977: Add local and peer address accessors to http::Connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58977/#review174233 --- 3rdparty/libprocess/include/process/http.hpp Lines 960-968

Re: Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/#review174232 --- Request for comment... src/slave/containerizer/fetcher.cpp

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- (Updated May 8, 2017, 6:20 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 8, 2017, 3:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/ --- (Updated May 8, 2017, 6:19 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 58999: Added --secret_resolver flag to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/ --- (Updated May 8, 2017, 6:19 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58759: Introduced SecretResolver module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated May 8, 2017, 6:19 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58760: Added default secret resolver module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- (Updated May 8, 2017, 6:19 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58847: Checkpointed and recovered ContainerLaunchInfo for non-orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/#review174229 --- Ship it! Ship It! - Gastón Kleiman On May 3, 2017, 4:45

Re: Review Request 59068: Updated release/versioning docs for "-dev" version scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59068/ --- (Updated May 8, 2017, 10:01 p.m.) Review request for mesos and Vinod Kone.

Review Request 59069: Changed version number to "1.4.0-dev".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59069/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7473

Review Request 59068: Updated release/versioning docs for "-dev" version scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59068/ --- Review request for mesos. Bugs: MESOS-7473

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ --- (Updated May 8, 2017, 9:43 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 59067: Changed `#elif ...` to `#elif defined(...)` in Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59067/ --- Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.

Re: Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59061/#review174225 --- src/slave/containerizer/mesos/provisioner/paths.cpp Lines 210

Review Request 59063: Changed #elif to #elif defined() in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59063/ --- Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.

Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59061/ --- Review request for mesos, Chun-Hung Hsiao, Jie Yu, Michael Park, Neil Conway,

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ --- (Updated May 8, 2017, 7:03 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

> On May 7, 2017, 8:13 p.m., Kevin Klues wrote: > > src/cli_new/lib/cli/constants.py > > Lines 18-25 (patched) > > > > > > Aso is, I think we should bundle this under cli/tests/constants.py. > > > > However,

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 8, 2017, 5:27 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58998/ --- (Updated May 8, 2017, 5:04 p.m.) Review request for mesos and haosdent huang.

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174191 --- Patch looks great! Reviews applied: [58874] Passed command:

Re: Review Request 59038: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59038/ --- (Updated May 8, 2017, 4:40 p.m.) Review request for mesos, Anindya Sinha and

Re: Review Request 58924: Updated containerizer for isolator task_environment merge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58924/ --- (Updated May 8, 2017, 3:41 p.m.) Review request for mesos, Adam B, Gilbert

Re: Review Request 58949: Introduced ResourceProviderInfo proto.

> On May 8, 2017, 4:59 p.m., Jie Yu wrote: > > src/common/type_utils.cpp > > Lines 372-377 (patched) > > > > > > Let's don't introduce this yet until it's actually being used. For that > > reason, we don't have

Re: Review Request 58924: Updated containerizer for isolator task_environment merge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58924/#review174173 --- Fix it, then Ship it!

Re: Review Request 58949: Introduced ResourceProviderInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58949/#review174168 --- Fix it, then Ship it! include/mesos/mesos.proto Line 107

Re: Review Request 58949: Introduced ResourceProviderInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58949/ --- (Updated May 8, 2017, 4:49 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review174166 --- Patch looks great! Reviews applied: [58095, 58096, 58097, 58099]

Re: Review Request 59047: Added internal wrapper messages for local resource provider Event/Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59047/#review174162 --- Fix it, then Ship it! src/messages/messages.proto Lines

Re: Review Request 59046: Added basic resource provider Event/Call types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59046/#review174163 --- Ship it! Ship It! - Benjamin Bannier On May 8, 2017, 2:20

Review Request 59047: Added internal wrapper messages for local resource provider Event/Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59047/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7469

Review Request 59046: Added basic resource provider Event/Call types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59046/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7336

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated May 8, 2017, 8:01 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated May 8, 2017, 8 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

> On April 27, 2017, 11:05 p.m., Alexander Rojas wrote: > > src/tests/master_authorization_tests.cpp > > Line 2063 (original), 2062 (patched) > > > > > > Not yours, but no test verifies that the serialzation of

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 3, 2017, 7:45 p.m., Benjamin Mahler wrote: > > src/webui/master/static/browse.html > > Lines 15-16 (original), 15-16 (patched) > > > > > > Looking at the gif, it seems the slashes weren't copied before? Do

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- (Updated May 8, 2017, 3:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- (Updated May 8, 2017, 3:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated May 8, 2017, 3:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

> On April 27, 2017, 10:58 p.m., Alexander Rojas wrote: > > src/master/http.cpp > > Line 3401 (original), 3403 (patched) > > > > > > your changes here make this function non safe thread. Notice that the > >

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated May 8, 2017, 3:41 p.m.) Review request for mesos, Adam B, Alexander