Re: Review Request 59012: Implemented passing the secret resolver to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/ --- (Updated May 10, 2017, 5:47 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59140: Fixed task_environment serializing in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59140/#review174462 --- Ship it! Ship It! - Gilbert Song On May 10, 2017, 5:34

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review174461 --- src/master/http.cpp Line 3647 (original), 3670-3676 (patched)

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

> On May 5, 2017, 2:42 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 693 (patched) > > > > > > Is it a good idea to overload the "password" field in a URI as a docker > > config carrier? >

Review Request 59140: Fixed task_environment serializing in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59140/ --- Review request for mesos, Gilbert Song, Jie Yu, and Kapil Arya. Repository:

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

> On May 9, 2017, 4:25 p.m., Vinod Kone wrote: > > include/mesos/docker/spec.hpp > > Lines 83 (patched) > > > > > > no unit test for this? This helper was tested in unit test when the parameter is a JSON object.

Re: Review Request 59092: Added local resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59092/#review174451 --- src/resource_provider/local_driver.cpp Lines 19-25 (patched)

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/#review174445 --- src/master/http.cpp Line 406 (original), 412-418 (patched)

Re: Review Request 59015: Implemented passing docker config to URIs.

> On May 8, 2017, 5:29 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Lines 270-271 (patched) > > > > > > am i reading it correctly that `None` represents

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

> On May 8, 2017, 5:22 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Line 235 (original), 243-244 (patched) > > > > > > I'm assuming you need `config` here explicitly and

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

> On May 9, 2017, 9:17 p.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Lines 706-730 (patched) > > > > > > I wonder if it might be better to improve the check command instead of > > doing this (is there a

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

> On May 9, 2017, 2 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > > Lines 153 (patched) > > > > > > + @kapil > > > > It's sad to see that raw pointer has been

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

> On May 8, 2017, 5:17 p.m., Vinod Kone wrote: > > Updated summary/description to "SecretResolver" ah, missed that. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review174453 --- src/master/http.cpp Lines 3489-3497 (original), 3491-3499

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

> On May 8, 2017, 5:17 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp > > Lines 77 (patched) > > > > > > is the default needed here to avoid updating tests? yes. - Gilbert

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

> On May 5, 2017, 4:55 p.m., Chun-Hung Hsiao wrote: > > Should we use a shared pointer for `SecretResolver` instead of passing a > > `SecretResolver*` around? > > Vinod Kone wrote: > +1. Since provisioner and env isolator are both sharing the pointer, it's > probably worth having the

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

> On May 8, 2017, 5:17 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > > Lines 48 (patched) > > > > > > no need for a default? it does not hurt here. but we should set a

Re: Review Request 58587: Clarified comments about resource operations through operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58587/#review174448 --- Patch looks great! Reviews applied: [58587] Passed command:

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review17 --- I really like the shape this is taking. Just a really minor issue

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review174439 --- Patch looks great! Reviews applied: [58872] Passed command:

Re: Review Request 59135: Implemented resource provider bookkeeping primitives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59135/ --- (Updated May 10, 2017, 11:33 a.m.) Review request for mesos, Benjamin Bannier

Review Request 59136: Added functions to add/remove resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59136/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 59135: Implemented resource provider bookkeeping primitives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59135/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 59107: [WIP] Added extra debugging statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59107/#review174427 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review174425 --- Patch looks great! Reviews applied: [58939] Passed command:

Review Request 59131: Added an IPv6 address storage to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59131/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7488

Review Request 59130: Added storage for IPv6 in a `libprocess` process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59130/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7488

Review Request 59129: Introduced `inet6::Address` to handle IPv6 addresses in `libprocess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59129/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7488

Review Request 59128: Added initialization logic in Mesos agent for IPv6 flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59128/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7488

Review Request 59127: Added IPv6 flags for Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7488

<    1   2