Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/#review181321 --- Patch looks great! Reviews applied: [60500, 60557, 60558, 61075,

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/ --- (Updated July 25, 2017, 2:08 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60761/ --- (Updated July 25, 2017, 2:07 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/ --- (Updated July 25, 2017, 2:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated July 25, 2017, 2:05 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60557: Passed default container DNS info to Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60557/ --- (Updated July 25, 2017, 2:04 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 25, 2017, 2:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 25, 2017, 1:46 a.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 41 (patched) > > > > > > I'd s/MesosDNS/MesosInfo/ here. Same for DockerDNS below. This seems to > > be consistent with what's insid

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 25, 2017, 1:42 a.m., Avinash sridharan wrote: > > src/slave/flags.cpp > > Lines 773 (patched) > > > > > > We need a validation for the `HOST` mode here? Yeah, I have it here: https://reviews.apache.org/r/6

Re: Review Request 61095: Updated LICENSE information for grpc 1.4.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61095/#review181310 --- Patch looks great! Reviews applied: [61095] Passed command: supp

Review Request 61095: Updated LICENSE information for grpc 1.4.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61095/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu. Bugs: MESOS-7

Re: Review Request 61005: Added a test to check for copy assignment of `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61005/#review181308 --- Bad patch! Reviews applied: [61005, 61004] Failed command: pytho

Re: Review Request 61005: Added a test to check for copy assignment of `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61005/#review181307 --- Ship it! Ship It! - Benjamin Hindman On July 20, 2017, 6:08

Re: Review Request 61004: Added a copy assignment operator to `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61004/#review181306 --- Ship it! Ship It! - Benjamin Hindman On July 20, 2017, 6:06

Re: Review Request 61094: Multi-role: Adjusted `long-lived-framework` to use allocated resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61094/#review181303 --- Patch looks great! Reviews applied: [61094] Passed command: supp

Re: Review Request 61056: Removed unused mutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61056/#review181301 --- Ship it! Might be worth clarifying in the commit description th

Re: Review Request 61059: Added --enable-lock-free-event-queue configuration in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61059/#review181296 --- Ship it! configure.ac Lines 151-154 (original), 151-159 (patch

Re: Review Request 61092: Windows: Fixed rvalue cast bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61092/#review181298 --- Patch looks great! Reviews applied: [61092] Passed command: supp

Re: Review Request 61066: Added 'process::workers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61066/#review181295 --- Fix it, then Ship it! Have you considered having a test for thi

Re: Review Request 61054: Added a functional "map" abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61054/#review181294 --- Ship it! Ship It! - Benjamin Mahler On July 22, 2017, 1:09 a

Re: Review Request 61094: Multi-role: Adjusted `long-lived-framework` to use allocated resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61094/#review181291 --- Ship it! src/examples/long_lived_framework.cpp Lines 109-111 (

Re: Review Request 61052: Refactored Gate and updated Gate per Process implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61052/#review181280 --- Fix it, then Ship it! For posterity, could you also add a bit t

Re: Review Request 61093: Windows: Disabled permissive building.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61093/#review181290 --- Ship it! Ship It! - Michael Park On July 24, 2017, 4:11 p.m.

Re: Review Request 61093: Windows: Disabled permissive building.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61093/#review181289 --- Ship it! The additional flag looks odd enough to warrant puttin

Review Request 61094: Multi-role: Adjusted `long-lived-framework` to use allocated resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61094/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 61090: Store container reference in a variable if it will be used repeatedly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61090/#review181287 --- Patch looks great! Reviews applied: [61089, 61090] Passed comman

Review Request 61093: Windows: Disabled permissive building.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61093/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 61092: Windows: Fixed rvalue cast bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61092/#review181284 --- Ship it! Ship It! - Michael Park On July 24, 2017, 4:03 p.m.

Review Request 61092: Windows: Fixed rvalue cast bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61092/ --- Review request for mesos and Michael Park. Bugs: MESOS-7794 https://issues.

Re: Review Request 61089: Logged each container state transition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61089/#review181281 --- Patch looks great! Reviews applied: [61089] Passed command: supp

Review Request 61090: Store container reference in a variable if it will be used repeatedly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61090/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review181277 --- Patch looks great! Reviews applied: [60928, 60929, 60930, 60931]

Review Request 61089: Logged each container state transition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61089/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review181271 --- Patch looks great! Reviews applied: [60203, 59294] Passed comman

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/#review181260 --- Patch looks great! Reviews applied: [60500, 60557, 60558, 61075,

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review181254 --- Mostly some comments around using the `/teardown` endpoint to trig

Re: Review Request 60900: Updated Python linter to work with multiple directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review181259 --- Bad patch! Reviews applied: [60900, 60899] Failed command: pytho

Re: Review Request 61069: Introduced an optimized fixed size last-in-first-out semaphore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61069/#review181258 --- Bad review! Reviews applied: [61069, 61068, 61067] Error: No rev

Re: Review Request 60930: Added 'FRAMEWORK_REMOVED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60930/#review181252 --- include/mesos/master/master.proto Lines 530 (patched)

Re: Review Request 60929: Added 'FRAMEWORK_UPDATED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60929/#review181248 --- Looks good for the most part; just some comments around better rep

Re: Review Request 60928: Added 'FRAMEWORK_ADDED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60928/#review181243 --- Fix it, then Ship it! src/common/protobuf_utils.cpp Lines 821

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated July 24, 2017, 11:36 a.m.) Review request for mesos, Dmitry Zhuk, Ilya

Re: Review Request 60203: Introduce HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/ --- (Updated July 24, 2017, 11:36 a.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181233 --- Fix it, then Ship it! The protobuf looks good to me! Thanks Qia

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181234 --- src/slave/flags.cpp Lines 773 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 23, 2017, 3:22 p.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 69 (patched) > > > > > > Qian, sorry, should have pointed this out earlier. I think we decided > > that for Docker we can

Re: Review Request 61082: Removed tracking ResourceProvider total resources in its info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61082/#review181225 --- Ship it! Ship It! - Jie Yu On July 24, 2017, 1:15 p.m., Benj

Re: Review Request 61081: Considered ResourceProvider 'name' and 'type' in equality checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61081/#review181224 --- Ship it! Ship It! - Jie Yu On July 24, 2017, 1:15 p.m., Benj

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/#review181218 --- src/resource_provider/manager.cpp Lines 224-231 (patched)

Re: Review Request 61082: Removed tracking ResourceProvider total resources in its info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61082/#review181213 --- Ship it! Ship It! - Jan Schlicht On July 24, 2017, 3:15 p.m.

Re: Review Request 61081: Considered ResourceProvider 'name' and 'type' in equality checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61081/#review181212 --- Ship it! Ship It! - Jan Schlicht On July 24, 2017, 3:15 p.m.

Re: Review Request 61032: Fixed slaves_unreachable metric.

> On July 22, 2017, 10:47 a.m., Armand Grillet wrote: > > Regarding the summary: is this a fix? This looks like the addition of one > > metric and there is no bug linked to the review request (except > > [MESOS-7747](https://issues.apache.org/jira/browse/MESOS-7747) at the > > beginning of the

Re: Review Request 61030: Added metrics for the number of active http and driver frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61030/ --- (Updated July 24, 2017, 1:35 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 61029: Added metric for connected API subscribers in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61029/ --- (Updated July 24, 2017, 1:34 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 61028: Added metric for API subscribe calls in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61028/ --- (Updated July 24, 2017, 1:34 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/ --- (Updated July 24, 2017, 3:24 p.m.) Review request for mesos, Benjamin Bannier a

Review Request 61082: Removed tracking ResourceProvider total resources in its info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61082/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos Descript

Review Request 61081: Considered ResourceProvider 'name' and 'type' in equality checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61081/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos Descript

Re: Review Request 60770: Added validation functions for resource provider calls.

> On July 24, 2017, 11:53 a.m., Benjamin Bannier wrote: > > src/resource_provider/validation.cpp > > Lines 39-40 (patched) > > > > > > Any reason we cannot reject an `UNKNOWN` `type` here? Is there any > > value to k

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

> On July 17, 2017, 11:50 p.m., Jie Yu wrote: > > src/resource_provider/manager.cpp > > Lines 134 (patched) > > > > > > Can we use `Owned` pointer here so that you don't need to release them > > in destructor. Inst

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/ --- (Updated July 24, 2017, 2:07 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 60770: Added validation functions for resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60770/ --- (Updated July 24, 2017, 2:05 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 60769: Added evolve functions for resource provider Event/Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60769/#review181199 --- Ship it! Ship It! - Benjamin Bannier On July 12, 2017, 5:01

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181195 --- Ship it! Ship It! - Qian Zhang On July 21, 2017, 7:57 a.m.,

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated July 24, 2017, 4:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/ --- (Updated July 24, 2017, 4:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60761/ --- (Updated July 24, 2017, 4:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/ --- (Updated July 24, 2017, 4:01 p.m.) Review request for mesos, Avinash sridharan

Review Request 61075: Set container DNS with `--default_container_dns` in DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61075/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709 ht