Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review181526 --- Patch looks great! Reviews applied: [58939] Passed command: supp

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ --- (Updated July 27, 2017, 2:40 a.m.) Review request for mesos, Anand Mazumdar, Gi

Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61157/#review181523 --- Bad patch! Reviews applied: [61157, 61156, 61155, 61154, 61153, 6

Review Request 61155: Added http::Server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61155/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61154: Added safe downcasts for Socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61154/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61147: Added Future::onAbandoned and Future::isAbandoned.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61147/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61149: Added Future::condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61149/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61148: Added Future::recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61148/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61157/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61150: Added Future::onAbandoned semantics to process::collect/await.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61150/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61152: Added overload of process::await that takes and returns single future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61152/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61153: Added discard happens-before relationship in process::await/collect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61153/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61156: Factored out HttpProxy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61156/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 61151: Used Future::recover in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61151/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 60440: Updated local development workflow of mesos website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/#review181522 --- Patch looks great! Reviews applied: [60438, 60439, 60440] Passed

Re: Review Request 61097: Added gRPC support in libprocess.

> On July 26, 2017, 10:49 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 148 (patched) > > > > > > I would use the name `Stub` here. > > ``` > > auto call( > > const Ch

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

> On July 26, 2017, 11:08 p.m., Gastón Kleiman wrote: > > docs/ssl.md > > Lines 81 (patched) > > > > > > There was only one empty line before, do we need two? True - thanks a bunch again :) - Till ---

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181517 --- docs/ssl.md Lines 81 (patched)

Re: Review Request 60440: Updated local development workflow of mesos website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/ --- (Updated July 27, 2017, 12:30 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181514 --- Ship it! Ship It! - Till Toenshoff On July 26, 2017, 9:25 a.

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 3, 2017, 4:47 p.m., haosdent huang wrote: > > support/mesos-website/entrypoint.sh > > Lines 32 (patched) > > > > > > Is it OK to run support/mesos-website/build.sh as root? looks like you answered yourself

Re: Review Request 60440: Updated local development workflow of mesos website.

> On July 4, 2017, 12:10 p.m., Benjamin Bannier wrote: > > I am confused why we need this at all at this point. With > > https://reviews.apache.org/r/60439/ we should be able to generate the site > > locally and look at its output. Executing the rake rules is already now > > pretty much possib

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 3, 2017, 5:11 p.m., haosdent huang wrote: > > Really sorry for the delay. LGTM, just want to sure is it possible to merge > > build.sh into entrypoint.sh We need to keep this separate because build.sh needs to be run as non-root user, whereas entrypoint.sh need to be run as root user

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/ --- (Updated July 27, 2017, 12:28 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 4, 2017, 12:02 p.m., Benjamin Bannier wrote: > > This is a great start, but I would prefer if we wouldn't directly mount an > > existing source directory into the container and bootstrap, configure and > > build in it (this is also broken for e.g., in-source builds). > > > > What abo

Re: Review Request 60440: Updated local development workflow of mesos website.

> On July 3, 2017, 5:15 p.m., haosdent huang wrote: > > Should we make `support/mesos-website/entrypoint.sh` support a environment > > variable `MODE=dev` and then we `export MODE=dev` in > > `site/mesos-website-dev.sh` and just call `support/mesos-website.sh`? It > > would help to avoid write

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

> On July 26, 2017, 11:12 p.m., Greg Mann wrote: > > docs/ssl.md > > Lines 78-79 (patched) > > > > > > Proposing a couple small tweaks for grammar/spelling: > > > > ``` > > List of elliptic curves which s

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60438/ --- (Updated July 27, 2017, 12:27 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

> On July 19, 2017, 11:50 a.m., Jan-Philip Gehrcke wrote: > > Hey! This looks great. > > > > I have a few remarks. > > > > 1) The test in this patch seems to prove that the patch introduces support > > for the _ephemeral_ elliptic curve Diffie-Hellman key exchange, usually > > abbreviated wit

Re: Review Request 61097: Added gRPC support in libprocess.

> On July 26, 2017, 10:49 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 123 (patched) > > > > > > who is going to delete the lambda function? This lambda will be retrieved and manage

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/#review181509 --- Ship it! Ship It! - Jie Yu On July 26, 2017, 9:35 a.m., Jan

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review181508 --- Patch looks great! Reviews applied: [58939] Passed command: supp

Re: Review Request 60770: Added validation functions for resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60770/#review181507 --- Ship it! Ship It! - Jie Yu On July 26, 2017, 10:48 a.m., Jan

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

> On July 26, 2017, 11:08 p.m., Gastón Kleiman wrote: > > docs/ssl.md > > Lines 78 (patched) > > > > > > s/Valid values depends on OpenSSL version used/Valid values depend on > > the OpenSSL version used./ Indeed -

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

> On July 26, 2017, 11:08 p.m., Gastón Kleiman wrote: > > Nit: AFAIK we try to write our commit messages in simple past. The summary should be past tense, description present tense. - Till --- This is an automatically generated e-mail.

Re: Review Request 60524: Stout: Made the `Duration` operators handle int overflows explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60524/ --- (Updated July 26, 2017, 11:31 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 60525: Fixed the default filter used by the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60525/ --- (Updated July 26, 2017, 11:30 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ --- (Updated July 26, 2017, 11:29 p.m.) Review request for mesos, Anand Mazumdar, G

Re: Review Request 60721: Stout: Made `Duration::parse()` handle durations out of range.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60721/ --- (Updated July 26, 2017, 11:12 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181502 --- docs/ssl.md Lines 78-79 (patched)

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181500 --- Nit: AFAIK we try to write our commit messages in simple past. d

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/#review181469 --- Good work! See my detailed comments. I'll do a second pass once th

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

> On July 26, 2017, 8:55 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 672 (patched) > > > > > > This would break with OpenSSL < 0.9.8 as the function > > `initialize_ecdh_curve` woul

Re: Review Request 61063: Do not track files generated by stout autotools build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61063/#review181497 --- Ship it! Ship It! - Till Toenshoff On July 23, 2017, 9:09 a.

Re: Review Request 61064: Do not track files generated by libprocess autotools build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61064/#review181496 --- Ship it! Ship It! - Till Toenshoff On July 23, 2017, 9:09 a.

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181491 --- Ship it! Ship It! - Till Toenshoff On July 21, 2017, 9:30 a.

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review181487 --- Bad patch! Reviews applied: [58939] Failed command: python suppo

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

> On July 20, 2017, 8:19 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1112-1126 (patched) > > > > > > I don't like the checks here, since we have the following case: > >

Re: Review Request 61089: Logged each container state transition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61089/ --- (Updated July 26, 2017, 12:18 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 61089: Logged each container state transition.

> On July 26, 2017, 10:48 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 2599-2603 (patched) > > > > > > Would suggest we either > > 1. add a check here: `CHECK(container

Re: Review Request 61123: Added regression test for host volume ownership issue.

> On July 26, 2017, 7:08 p.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > > > > > Why do we need Docker for this test? The problem should be rep

Re: Review Request 61123: Added regression test for host volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61123/#review181467 --- Fix it, then Ship it! LGTM! The comment is mostly a question.

Re: Review Request 61122: Fixed the host volume relative host path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61122/#review181457 --- Fix it, then Ship it! LGTM! src/slave/containerizer/mesos/iso

Re: Review Request 61090: Store container reference in a variable if it will be used repeatedly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61090/#review181473 --- Ship it! Ship It! - Gilbert Song On July 24, 2017, 3:07 p.m.

Re: Review Request 61089: Logged each container state transition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61089/#review181472 --- src/slave/containerizer/mesos/containerizer.cpp Lines 2599-2603 (

Re: Review Request 61122: Fixed the host volume relative host path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61122/#review181468 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 61121: Added regression test for sandbox_path volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61121/#review181464 --- Fix it, then Ship it! src/tests/containerizer/volume_sandbox_p

Re: Review Request 60961: Added Prometheus support to the `/metrics/snapshot` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60961/#review181465 --- Patch looks great! Reviews applied: [61124, 60957, 61125, 60958,

Re: Review Request 61137: Cleaned up style in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/#review181455 --- Patch looks great! Reviews applied: [61110, 6, 61112, 61134,

Review Request 61137: Cleaned up style in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7814 https://

Review Request 61136: Extracted strings into constants in docker no executor framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61136/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7814 https://

Review Request 61135: Extracted strings into constants in disk full framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61135/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7814 https://

Review Request 61134: Added name flag to disk full framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61134/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7814 https://

Re: Review Request 61112: Added flag executor_extra_uris to balloon framework.

> On July 25, 2017, 7:08 p.m., Till Toenshoff wrote: > > src/examples/balloon_framework.cpp > > Lines 120-124 (patched) > > > > > > I would suggest to use a different approach here -- instead of allowing > > multipl

Re: Review Request 61111: Extracted strings into constants in balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated July 26, 2017, 1:16 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 60770: Added validation functions for resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60770/ --- (Updated July 26, 2017, 12:48 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60769: Added evolve functions for resource provider Event/Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60769/ --- (Updated July 26, 2017, 12:46 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/ --- (Updated July 26, 2017, 11:35 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 26, 2017, 11:25 a.m.) Review request for mesos, Jie Yu, James Pea

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181444 --- 3rdparty/libprocess/src/openssl.cpp Lines 672 (patched)

Re: Review Request 61111: Extracted strings into constants in balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review181439 --- src/examples/balloon_framework.cpp Line 302 (original), 306 (patc