Re: Review Request 63342: Fixed CMake binary dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63342/#review189398 --- Bad patch! Reviews applied: [63342, 63341, 63340, 60628, 60626,

Re: Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review189392 --- Patch looks great! Reviews applied: [63268, 63269, 63271, 63272,

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

> On Oct. 26, 2017, 11:45 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp > > Lines 170 (patched) > > > > > > why is it an `Option`? Similar to `ContainerConfig`, we might be

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

> On Oct. 26, 2017, 12:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1113-1120 (original), 1152-1164 (patched) > > > > > > After looking at the slave code. it seems to

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review189378 --- src/slave/containerizer/mesos/provisioner/provisioner.hpp Lines

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/#review189376 --- Patch looks great! Reviews applied: [63314] Passed command:

Re: Review Request 63094: Added resource version uuid for offer operations.

> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review189372 --- PASS: Mesos patch 62938 was successfully built and tested.

Re: Review Request 63094: Added resource version uuid for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review189371 --- include/mesos/v1/resource_provider/resource_provider.proto Lines

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/ --- (Updated Oct. 26, 2017, 3:55 p.m.) Review request for mesos, Jeff Coffler,

Review Request 63342: Fixed CMake binary dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63342/ --- Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu. Bugs:

Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/ --- Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu. Bugs:

Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/ --- Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189354 --- include/mesos/mesos.proto Lines 2157 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review189363 --- src/tests/check_tests.cpp Line 80 (original), 80 (patched)

Re: Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review189362 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:40

Re: Review Request 63277: Windows: Ported CPU and memory isolator tests.

> On Oct. 26, 2017, 2:59 p.m., Jeff Coffler wrote: > > src/tests/containerizer/cpu_isolator_tests.cpp > > Lines 120 (patched) > > > > > > Given what we learned about quoting, why not just do: > > > >

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/#review189360 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:34

Re: Review Request 63277: Windows: Ported CPU and memory isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63277/#review189358 --- src/tests/containerizer/cpu_isolator_tests.cpp Lines 120

Re: Review Request 63275: Windows: Abstracted out `os::name_job` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63275/#review189355 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:31

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review189351 --- Fix it, then Ship it!

Re: Review Request 63312: Updated Resources::apply for new operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63312/#review189350 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 63315: Allowe override of parallel jobs in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63315/#review189349 --- Patch looks great! Reviews applied: [63315] Passed command:

Re: Review Request 63271: Windows: Added `os::set_job_memory_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/#review189347 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:29

Re: Review Request 63273: Windows: Added `os::get_job_processes` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63273/#review189346 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:31

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review189345 --- src/tests/containerizer/mesos_containerizer_tests.cpp Lines

Re: Review Request 63271: Windows: Added `os::set_job_memory_limit` to stout.

> On Oct. 26, 2017, 1:55 p.m., Jeff Coffler wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Lines 784 (patched) > > > > > > I usually see NOLINT on a line of it's own. Is that a mistake, making > > the

Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63272/#review189343 --- 3rdparty/stout/include/stout/windows/os.hpp Lines 730 (patched)

Re: Review Request 63271: Windows: Added `os::set_job_memory_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/#review189342 --- 3rdparty/stout/include/stout/windows/os.hpp Lines 784 (patched)

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189340 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:27

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

> On Oct. 26, 2017, 7:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1113-1120 (original), 1152-1164 (patched) > > > > > > After looking at the slave code. it seems to

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

> On Sept. 25, 2017, 6:23 p.m., Gilbert Song wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp > > Line 714 (original), 714-720 (patched) > > > > > > will it look cleaner if use `createTask()` helper?

Re: Review Request 63269: Windows: Added `os::set_job_cpu_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63269/#review189334 --- PASS: Mesos patch 63269 was successfully built and tested.

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review188981 --- Fix it, then Ship it!

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/#review189328 --- Ship it! Ship It! - Jiang Yan Xu On Oct. 26, 2017, 12:01

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/ --- (Updated Oct. 26, 2017, 7:01 p.m.) Review request for mesos, James Peach and

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/#review189327 --- src/master/allocator/sorter/drf/sorter.hpp Lines 392 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189326 --- Patch looks great! Reviews applied: [60620, 60621, 60622, 60623,

Re: Review Request 63322: Added placeholder handlers and other changes for operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63322/#review189325 --- PASS: Mesos patch 63322 was successfully built and tested.

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/ --- (Updated Oct. 26, 2017, 6:26 p.m.) Review request for mesos, James Peach and

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/#review189324 --- Fix it, then Ship it!

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/ --- (Updated Oct. 26, 2017, 6:12 p.m.) Review request for mesos, James Peach and

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/ --- (Updated Oct. 26, 2017, 6:10 p.m.) Review request for mesos, James Peach and

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/#review189323 --- Fix it, then Ship it!

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review189321 --- src/python/cli_new/lib/cli/util.py Lines 247-253 (patched)

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/ --- (Updated Oct. 26, 2017, 4:52 p.m.) Review request for mesos, Eric Chung and

Review Request 63332: Logged the resources in DRF sorter CHECK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/ --- Review request for mesos, James Peach and Jiang Yan Xu. Repository: mesos

Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/ --- Review request for mesos, Akash Gupta, Alexander Rukletsov, Jeff Coffler,

Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich,

Review Request 63277: Windows: Ported CPU and memory isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63277/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich,

Review Request 63276: Windows: Added `Cpuset` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich,

Review Request 63273: Windows: Added `os::get_job_processes` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63273/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich,

Review Request 63274: Windows: Added `os::get_job_memory` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63274/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich,

Review Request 63275: Windows: Abstracted out `os::name_job` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63275/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and

Review Request 63272: Windows: Added `os::get_job_info` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63272/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and

Review Request 63271: Windows: Added `os::set_job_memory_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and

Review Request 63269: Windows: Added `os::set_job_cpu_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63269/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and

Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/ --- Review request for mesos, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.

Re: Review Request 63293: Update google-glog to 0.3.5.

> On Oct. 25, 2017, 6:43 p.m., Andrew Schwartzmeyer wrote: > > Is there a pressing need to update this _right now_? As it is, we are > > waiting for 0.3.6 (MESOS-3394) so that we can converge on a single version > > of Glog for all platforms. > > Tomasz Janiszewski wrote: > Nope. We can

Re: Review Request 63245: Ported and enabled Os Tests on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63245/ --- (Updated Oct. 26, 2017, 2:59 p.m.) Review request for mesos and Andrew

Re: Review Request 63245: Ported and enabled Os Tests on Windows.

> On Oct. 24, 2017, 6:55 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/windows/stat.hpp > > Line 112 (original), 112 (patched) > > > > > > Why was this change made? The test failed. My guess

Re: Review Request 63245: Ported and enabled Os Tests on Windows.

> On Oct. 24, 2017, 6:55 p.m., Andrew Schwartzmeyer wrote: > > This review request should really be at least three separate patches. THere > > is work to be done to fix several of these tests, and right now they're all > > mixed together. should I discard this commit and make separate ones

Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Re: Review Request 63239: Ported and enabled Flag Tests on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63239/ --- (Updated Oct. 26, 2017, 11:01 a.m.) Review request for mesos and Andrew

Re: Review Request 63238: Ported and enabled Path Tests on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63238/ --- (Updated Oct. 26, 2017, 10:56 a.m.) Review request for mesos and Andrew

Re: Review Request 63238: Ported and enabled Path Tests on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63238/ --- (Updated Oct. 26, 2017, 10:33 a.m.) Review request for mesos and Andrew

Re: Review Request 63293: Update google-glog to 0.3.5.

> On Oct. 26, 2017, 1:43 a.m., Andrew Schwartzmeyer wrote: > > Is there a pressing need to update this _right now_? As it is, we are > > waiting for 0.3.6 (MESOS-3394) so that we can converge on a single version > > of Glog for all platforms. Nope. We can wait for 0.3.6. We have merged

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review188966 --- src/master/http.cpp Line 317 (original), 317 (patched)

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote: > > support/docker-build.sh > > Lines 72 (patched) > > > > > > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not > > in other versions? I'm not

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/ --- (Updated Oct. 26, 2017, 8:08 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 63315: Allowe override of parallel jobs in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63315/#review189279 --- Ship it! Ship It! - Vinod Kone On Oct. 25, 2017, 9:58 p.m.,

Re: Review Request 63322: Added placeholder handlers and other changes for operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63322/#review189277 --- Fix it, then Ship it! src/master/master.hpp Lines 1005

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/#review189278 --- support/docker-build.sh Lines 65-67 (original), 65-67 (patched)

Re: Review Request 63321: Added protobuf messages for V1 scheduler operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63321/#review189276 --- include/mesos/scheduler/scheduler.proto Lines 386 (patched)

Re: Review Request 63321: Added protobuf messages for V1 scheduler operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63321/#review189275 --- Ship it! Ship It! - Jie Yu On Oct. 26, 2017, 6:58 a.m.,

Review Request 63322: Added placeholder handlers and other changes for operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63322/ --- Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone. Bugs:

Review Request 63321: Added protobuf messages for V1 scheduler operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63321/ --- Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone. Bugs: