Re: Review Request 64689: Windows: Fixed `os::open()` to always use `O_BINARY`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64689/#review194127 --- Ship it! Ship it!!! It would have saved me a lot of time last w

Re: Review Request 64698: Made quota headroom calculation on a per-role basis.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64698/#review194122 --- Fix it, then Ship it! Nice fix! I would suggest a summary that

Re: Review Request 64699: Added a test to ensure quota headroom is maintained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64699/#review194126 --- Ship it! Very nice! src/tests/hierarchical_allocator_tests.cp

Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64690/#review194125 --- FAIL: Mesos tests failed to build. Reviews applied: `['64689', '6

Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64701/#review194124 --- FAIL: Mesos tests failed to build. Reviews applied: `['64701']`

Re: Review Request 64699: Added a test to ensure quota headroom is maintained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64699/#review194123 --- PASS: Mesos patch 64699 was successfully built and tested. Review

Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64701/ --- Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park. Repository:

Re: Review Request 64664: Updated logging for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64664/#review194121 --- Ship it! Ship It! - Jie Yu On Dec. 18, 2017, 11:57 p.m., Chu

Re: Review Request 64665: Fixed the calculation of available capacity test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64665/#review194120 --- Ship it! Ship It! - Jie Yu On Dec. 16, 2017, 10:28 a.m., Chu

Review Request 64690: Windows: Removed manual use of `O_BINARY`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64690/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Gaston Kleiman, and Joseph

Review Request 64689: Windows: Fixed `os::open()` to always use `O_BINARY`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64689/ --- Review request for mesos, Akash Gupta, Jeff Coffler, Gaston Kleiman, and Joseph

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/#review194107 --- src/master/allocator/mesos/hierarchical.cpp Line 1750 (original),

Re: Review Request 64615: Moved SLRP resource recovery logic into a helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64615/#review194119 --- Ship it! Ship It! - Jie Yu On Dec. 14, 2017, 1:34 p.m., Jose

Re: Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64612/#review194118 --- Fix it, then Ship it! src/resource_provider/volume_profile.cpp

Re: Review Request 64695: Improved the comments describing the offer operation states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64695/#review194117 --- PASS: Mesos patch 64695 was successfully built and tested. Review

Re: Review Request 64697: Windows: Deleted unused and unnecessary OS version functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64697/#review194116 --- PASS: Mesos patch 64697 was successfully built and tested. Review

Re: Review Request 64354: Added tests for UriVolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64354/ --- (Updated Dec. 18, 2017, 7:07 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- (Updated Dec. 18, 2017, 7:08 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64612/ --- (Updated Dec. 18, 2017, 7:08 p.m.) Review request for mesos, Chun-Hung Hsiao an

Review Request 64699: Added a test to ensure quota headroom is maintained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64699/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8339 https://issu

Review Request 64698: Made quota headroom calculation on a per-role basis.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64698/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8339 https://issu

Re: Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP.

> On Dec. 15, 2017, 3:26 p.m., Jie Yu wrote: > > src/resource_provider/local.cpp > > Lines 39 (patched) > > > > > > It's weird that LocalResourceProvider needs to be aware > > `volumeProfileAdaptor` which is very Sto

Re: Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64612/ --- (Updated Dec. 18, 2017, 6:35 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64694/#review194111 --- PASS: Mesos patch 64694 was successfully built and tested. Review

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/#review194110 --- src/master/allocator/mesos/hierarchical.cpp Lines 1599 (patched)

Review Request 64697: Windows: Deleted unused and unnecessary OS version functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64697/ --- Review request for mesos, Akash Gupta, Jeff Coffler, and Joseph Wu. Bugs: MESOS

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review194106 --- 3rdparty/libprocess/src/process.cpp Lines 3530-3531 (patched)

Review Request 64695: Improved the comments describing the offer operation states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64695/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos Description

Re: Review Request 64658: Modified SLRP to use the VolumeProfileAdaptor module.

> On Dec. 19, 2017, 12:12 a.m., Jie Yu wrote: > > src/resource_provider/storage/provider.cpp > > Lines 2587-2588 (patched) > > > > > > Maybe we need a helper here? > > > > `Result getDiskProfile(const Resou

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review194100 --- PASS: Mesos patch 64033 was successfully built and tested. Review

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review194098 --- Fix it, then Ship it! src/csi/uri_volume_profile.proto Lines 2

Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review194099 --- PASS: Mesos patch 64590 was successfully built and tested. Review

Re: Review Request 64658: Modified SLRP to use the VolumeProfileAdaptor module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64658/#review194084 --- src/resource_provider/storage/provider.cpp Lines 897-912 (patched

Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64694/ --- Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. Repository: meso

Re: Review Request 64664: Updated logging for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64664/ --- (Updated Dec. 18, 2017, 11:57 p.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 64354: Added tests for UriVolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64354/ --- (Updated Dec. 18, 2017, 3:55 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- (Updated Dec. 18, 2017, 3:54 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/ --- (Updated Dec. 18, 2017, 3:24 p.m.) Review request for mesos, Chun-Hung Hsiao, G

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

> On Dec. 5, 2017, 2:17 a.m., Anand Mazumdar wrote: > > src/exec/exec.cpp > > Lines 350-359 (patched) > > > > > > hmm, wondering how is this even possible? We explicitly `link()` the > > executor's PID when the exec

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review194092 --- src/docker/executor.cpp Lines 389 (patched)

Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/#review194091 --- src/executor/v0_v1executor.cpp Lines 155 (patched)

Re: Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194088 --- What about the fix for other built-in executors (docker, default)?

Re: Review Request 64685: Improved the comment around the union in ns::clone().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/#review194089 --- Ship it! Ship It! - Armand Grillet On Dec. 18, 2017, 7:06 p.

Re: Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/#review194087 --- Ship it! Ship It! - Vinod Kone On Dec. 13, 2017, 2:49 p.m.,

Re: Review Request 64506: Correctly reset slave status when aborting a registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64506/#review194086 --- Ship it! Ship It! - Vinod Kone On Dec. 14, 2017, 3:32 p.m.,

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194083 --- PASS: Mesos patch 64686 was successfully built and tested. Review

Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review193824 --- Fix it, then Ship it! src/slave/slave.cpp Lines 7276 (patched)

Re: Review Request 64683: Updated support/mesos-style.py to build the virtualenv less often.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64683/#review194081 --- PASS: Mesos patch 64683 was successfully built and tested. Review

Review Request 64685: Improved the comment around the union in ns::clone().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park. R

Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park. B

Review Request 64683: Updated support/mesos-style.py to build the virtualenv less often.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64683/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs: MESOS-8217

Re: Review Request 64680: Fixed flaky `ROOT_CGROUPS_RecoverLauncherOrphans` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64680/#review194068 --- PASS: Mesos patch 64680 was successfully built and tested. Review

Review Request 64680: Fixed flaky `ROOT_CGROUPS_RecoverLauncherOrphans` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64680/ --- Review request for mesos, Alexander Rukletsov and Gilbert Song. Bugs: MESOS-826

Re: Review Request 64506: Correctly reset slave status when aborting a registration.

> On Dec. 14, 2017, 9:37 p.m., Benjamin Mahler wrote: > > Could you please file a ticket that describes the bug from what a user > > would experience, and link that in to the review? I would like to target it > > for backporting, seems pretty bad. Here you go: https://issues.apache.org/jira/br

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/ --- (Updated Dec. 18, 2017, 10:05 a.m.) Review request for mesos and Alexander Rukl

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64575/ --- (Updated Dec. 18, 2017, 10:03 a.m.) Review request for mesos and Alexander Rukl