Re: Review Request 64857: Updated example frameworks for mesos-local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/#review195015 --- PASS: Mesos patch 64857 was successfully built and tested.

Re: Review Request 64847: Added collection of example framework flag definitions.

> On Jan. 9, 2018, 1:29 a.m., Vinod Kone wrote: > > src/examples/example_framework_flags.hpp > > Lines 32 (patched) > > > > > > It's not clear to me why you broke down the flags like this? Also, not > > clear why v0

Re: Review Request 64847: Added collection of example framework flag definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64847/ --- (Updated Jan. 9, 2018, 3:20 a.m.) Review request for mesos, Alexander

Re: Review Request 64848: Updated example frameworks to make use of added flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64848/ --- (Updated Jan. 9, 2018, 3:19 a.m.) Review request for mesos, Alexander

Re: Review Request 64857: Updated example frameworks for mesos-local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/ --- (Updated Jan. 9, 2018, 3:19 a.m.) Review request for mesos, Alexander

Re: Review Request 64849: Added authentication to some example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/ --- (Updated Jan. 9, 2018, 3:19 a.m.) Review request for mesos, Alexander

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review195010 --- FAIL: Mesos tests failed to build. Reviews applied: `['63859',

Re: Review Request 64847: Added collection of example framework flag definitions.

> On Jan. 9, 2018, 1:29 a.m., Vinod Kone wrote: > > src/examples/example_framework_flags.hpp > > Lines 32 (patched) > > > > > > It's not clear to me why you broke down the flags like this? Also, not > > clear why v0

Re: Review Request 64847: Added collection of example framework flag definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64847/#review195007 --- src/examples/example_framework_flags.hpp Lines 17 (patched)

Re: Review Request 64846: Updated example frameworks environment parameter prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64846/#review195006 --- Ship it! Ship It! - Vinod Kone On Dec. 28, 2017, 2:06 a.m.,

Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/#review195004 --- PASS: Mesos patch 64969 was successfully built and tested.

Review Request 65034: Made resource provider manager conditionally set framework ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65034/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review195003 --- src/slave/slave.cpp Lines 2795-2829 (patched)

Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/#review195002 --- src/tests/storage_local_resource_provider_tests.cpp Lines 256

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review195000 --- Can you add a test or update an existing test to verify the

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review195001 --- Ship it! Ship It! - Gaston Kleiman On Jan. 4, 2018, 4:32

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review194994 --- src/tests/environment.cpp Lines 334-335 (patched)

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/#review194998 --- src/master/master.cpp Line 10043 (original), 10038-10044

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/#review194999 --- FAIL: Some Mesos tests failed. Reviews applied: `['64940']`

Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/ --- (Updated Jan. 8, 2018, 3:18 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64386: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/#review194992 --- Fix it, then Ship it! src/checks/checker_process.hpp Lines

Re: Review Request 64386: Windows: Enabled docker health checks.

> On Jan. 8, 2018, 2:54 p.m., Gaston Kleiman wrote: > > I can't review the powershell commands, but the rest looks sane. - Gaston --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 64570: Windows: Temporarily fixed the docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64570/#review194991 --- Ship it! Ship It! - Gaston Kleiman On Jan. 4, 2018, 4:32

Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`.

> On Jan. 5, 2018, 2:14 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/duration.hpp > > Lines 173 (patched) > > > > > > Why sacrifice the precision of integer * integer multiplication? > > > > ```

Re: Review Request 63861: Windows: Updated networking doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/#review194989 --- Fix it, then Ship it! docs/networking.md Lines 118 (patched)

Re: Review Request 65031: Replaced `convertResourceFormat` with `downgradeResources` accordingly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65031/#review194988 --- PASS: Mesos patch 65031 was successfully built and tested.

Re: Review Request 65032: Added a SLRP unit test for agent reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/#review194987 --- PASS: Mesos patch 65032 was successfully built and tested.

Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/ --- (Updated Jan. 8, 2018, 10:18 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review194986 --- Fix it, then Ship it! src/docker/docker.cpp Lines 742-744

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

> On Jan. 5, 2018, 1:25 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10037-10056 (original), 10039-10062 (patched) > > > > > > I think we shouldn't create a TASK_UNREACHABLE status update and call

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 444-447 (patched) > > > > > > Shouldn't this be a flag like in `no_executor_framework.cpp` and in > >

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194983 --- Ship it! - Gaston Kleiman On Jan. 8, 2018, 2:06 a.m.,

Re: Review Request 65016: Use flag class to perform example framework flag validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65016/#review194981 --- Ship it! Thanks a lot for the cleanup! - Gaston Kleiman On

Re: Review Request 65030: Replaced `convertResourceFormat` with `upgradeResources` accordingly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65030/#review194980 --- PASS: Mesos patch 65030 was successfully built and tested.

Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/ --- (Updated Jan. 8, 2018, 8:42 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/ --- (Updated Jan. 8, 2018, 8:42 p.m.) Review request for mesos, Gaston Kleiman,

Review Request 65032: Added a SLRP unit test for agent reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Bugs:

Review Request 65031: Replaced `convertResourceFormat` with `downgradeResources` accordingly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65031/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/ --- (Updated Jan. 8, 2018, 8:35 p.m.) Review request for mesos, Gaston Kleiman,

Review Request 65030: Replaced `convertResourceFormat` with `upgradeResources` appropriately.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65030/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Review Request 65029: Added `vector` overloads for `(down/up)gradeResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65029/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Re: Review Request 65012: Added tests to ensure that libprocess metrics are alphabetical.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65012/#review194978 --- Ship it! Ship It! - James Peach On Jan. 8, 2018, 12:57

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64630/#review194976 --- PASS: Mesos patch 64630 was successfully built and tested.

Re: Review Request 65026: Replaced `ResourcesState::recoverResources` with `state::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65026/#review194975 --- PASS: Mesos patch 65026 was successfully built and tested.

Re: Review Request 65019: Added new reconfiguration_policy flag to docs/updgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65019/#review194971 --- PASS: Mesos patch 65019 was successfully built and tested.

Re: Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/#review194970 --- PASS: Mesos patch 63661 was successfully built and tested.

Review Request 65025: Replaced `os::read` with `state::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65025/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Review Request 65023: Added `state::read` to complement `state::checkpoint`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65023/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Review Request 65026: Replaced `ResourcesState::recoverResources` with `state::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65026/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Review Request 65022: Updated uses of `protobuf::read(path)` which now returns `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65022/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Review Request 65024: Replaced `protobuf::read` with `state::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65024/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Review Request 65021: Returned `Try` from `protobuf::read(path)` rather than `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65021/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375

Re: Review Request 65019: Added new reconfiguration_policy flag to docs/updgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65019/#review194969 --- Ship it! Ship It! - Vinod Kone On Jan. 8, 2018, 1:52 p.m.,

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64630/ --- (Updated Jan. 8, 2018, 6:11 p.m.) Review request for mesos, Andrew

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

> On Jan. 5, 2018, 11:53 p.m., Ilya Pronin wrote: > > src/slave/paths.hpp > > Lines 404-405 (patched) > > > > > > Again judging by other functions here. The convention seems to be that > > the user provides a root

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194968 --- PASS: Mesos patch 64932 was successfully built and tested.

Re: Review Request 64930: Unified the marking agent unreachable logic in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64930/#review194946 --- The structure of the new `markUnreachable()` seems to be

Re: Review Request 65013: Removed gtest thread safe filter in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65013/#review194964 --- PASS: Mesos patch 65013 was successfully built and tested.

Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/#review194963 --- PASS: Mesos patch 64969 was successfully built and tested.

Re: Review Request 65011: Reverted back to alphabetical ordering of libprocess metrics in JSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65011/#review194959 --- Ship it! Ship It! - James Peach On Jan. 8, 2018, 12:57

Re: Review Request 65012: Added tests to ensure that libprocess metrics are alphabetical.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65012/#review194958 --- 3rdparty/libprocess/src/tests/metrics_tests.cpp Lines 298

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review194957 --- PASS: Mesos patch 64978 was successfully built and tested.

Re: Review Request 65013: Removed gtest thread safe filter in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65013/#review194956 --- Ship it! This looks fine to me, though what it means for the

Re: Review Request 64995: Improved image store manifest parsing errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64995/#review194952 --- PASS: Mesos patch 64995 was successfully built and tested.

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/#review194950 --- PASS: Mesos patch 65000 was successfully built and tested.

Re: Review Request 64962: Windows: Explicitly state source and destination path for extract.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64962/#review194947 --- PASS: Mesos patch 64962 was successfully built and tested.

Review Request 65019: Added new reconfiguration_policy flag to docs/updgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65019/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 64920: Introduced `upgradeResources` to complement `downgradeResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64920/#review194945 --- PASS: Mesos patch 64920 was successfully built and tested.

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- (Updated Jan. 8, 2018, 11:06 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 9:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 399 (patched) > > > > > > Why don't we make this a `string` instead of an `Option`? > > > > That

Review Request 65016: Use flag class to perform example framework flag validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65016/ --- Review request for mesos and Gaston Kleiman. Repository: mesos Description