Re: Review Request 65298: Split test flags into header and source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65298/#review196218 --- src/tests/flags.hpp Line 23 (original)

Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196219 --- src/tests/fetcher_cache_tests.cpp Lines 77 (patched)

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/#review196220 --- PASS: Mesos patch 65322 was successfully built and tested. Review

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

> On Jan. 22, 2018, 10:08 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/gtest.hpp > > Line 249 (original), 251 (patched) > > > > > > We don't really fully qualify the names here, but instead u

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/ --- (Updated Jan. 25, 2018, 7:32 a.m.) Review request for mesos, Benno Evers, Till

Re: Review Request 65334: Added quota limit to the master API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review196200 --- PASS: Mesos patch 65334 was successfully built and tested. Review

Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65223/#review196197 --- Hm.. I couldn't really follow from the ticket and desription here

Review Request 65334: Added quota limit to the master API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/ --- Review request for mesos, Alexander Rukletsov, Michael Park, and Meng Zhu. Bugs

Review Request 65333: Fixed errors in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65333/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Repository: mesos Des

Review Request 65332: Tested that a CSI persistent volume can be used after recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65332/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Repository: mesos Des

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/ --- (Updated Jan. 25, 2018, 1:44 a.m.) Review request for mesos, Gaston Kleiman, Gr

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 981 (patched) > > > > > > s/becomes a pre-existing volume/become pre-existing volumes/ s/volumes/volu

Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

> On Jan. 24, 2018, 10:11 a.m., Jie Yu wrote: > > Looks like this is related to > > https://github.com/apache/mesos/pull/221 > > > > Qian, can you commit the patch by tweaking the PR above and using his name? The code base of that PR is too old. So I will commit this patch and then close that

Re: Review Request 65245: Renamed `LOG` by `Stream logs` in Web UI.

> On Jan. 22, 2018, 7:33 p.m., Vinod Kone wrote: > > src/webui/master/static/agent.html > > Line 45 (original), 45 (patched) > > > > > > Hmm. This is inconsistent with how we did the stream vs download for > > sandbo

Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/#review196188 --- Ship it! Ship It! - Till Toenshoff On Jan. 18, 2018, 10:53 a

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196185 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Re: Review Request 65180: Removed a comment in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/#review196184 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 17, 2018, 11

Re: Review Request 65317: Used a namespace for paths in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65317/#review196183 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 24, 2018, 6:

Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65306/#review196180 --- Ship it! Ship It! - Jie Yu On Jan. 24, 2018, 1:18 a.m., Qian

Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support.

> On Jan. 24, 2018, 11:10 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 893-899 (original), 901-910 (patched) > > > > > > Checking `__s__ != nullptr` here no longer serves any purpose, as t

Re: Review Request 65326: Fixed conversion warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65326/#review196178 --- Ship it! I am not a native speaker, but maybe we could make the

Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65183/#review196174 --- Ship it! LGTM. 3rdparty/libprocess/src/process.cpp Lines 893-

Re: Review Request 65326: Fixed conversion warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65326/#review196177 --- PASS: Mesos patch 65326 was successfully built and tested. Review

Re: Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65324/#review196176 --- FAIL: Mesos tests failed to build. Reviews applied: `['65320', '6

Re: Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65324/#review196175 --- Do we really want to make Mesos aware of DC/OS's adminrouter and i

Re: Review Request 65326: Fixed conversion warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65326/ --- (Updated Jan. 24, 2018, 2:16 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 65326: Fixed conversion warning.

> On Jan. 24, 2018, 1:56 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp > > Line 677 (original), 677 (patched) > > > > > > We do not seem to depend on this being a `size_t`, so I'd sug

Re: Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65323/#review196172 --- FAIL: Mesos tests failed to build. Reviews applied: `['65320', '6

Re: Review Request 65326: Fixed conversion warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65326/#review196171 --- 3rdparty/libprocess/src/tests/benchmarks.cpp Line 677 (original),

Review Request 65326: Fixed conversion warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65326/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65324/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Kapil Arya. Repository

Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65323/ --- Review request for mesos, Greg Mann, Kapil Arya, and Kevin Klues. Repository: m

Review Request 65320: WIP: Conditionally set LIBPROCESS_IP into docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65320/ --- Review request for mesos, Greg Mann and Kapil Arya. Repository: mesos Descrip

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/#review196165 --- FAIL: Mesos tests failed to build. Reviews applied: `['65315', '6

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

> On Jan. 24, 2018, 5:18 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 506 (patched) > > > > > > Any specific reason why this is not a value, i.e., > > ``` > > static std:

Re: Review Request 65319: Implement os::eraseenv on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65319/#review196162 --- PASS: Mesos patch 65319 was successfully built and tested. Review

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/ --- (Updated Jan. 24, 2018, 8:04 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/#review196161 --- src/tests/api_tests.cpp Lines 2598-2600 (patched)

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/ --- (Updated Jan. 24, 2018, 7:50 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/ --- (Updated Jan. 24, 2018, 7:38 p.m.) Review request for mesos, Benjamin Mahler, G

Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/ --- Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone. Bugs

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196152 --- src/master/http.cpp Lines 741-742 (patched)

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196156 --- FAIL: Mesos tests failed to build. Reviews applied: `['65317', '6

Re: Review Request 65319: Implement os::eraseenv on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65319/#review196154 --- Ship it! Ship It! - Akash Gupta On Jan. 24, 2018, 7:06 p.m.,

Re: Review Request 65319: Implement os::eraseenv on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65319/#review196153 --- Ship it! Nit: two lines around functions in a namespace. LGTM,

Review Request 65319: Implement os::eraseenv on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65319/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos Descript

Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65315/#review196150 --- FAIL: Mesos tests failed to build. Reviews applied: `['65315']`

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

> On Jan. 24, 2018, 8:47 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos tests failed to build. > > > > Reviews applied: `['65308', '62447']` > > > > Failed command: `cmake.exe --build . --target mesos-tests --config Debug` > > > > All the build artifacts available at: > > http://dcos-wi

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review196148 --- FAIL: Mesos stout-tests failed to build. Reviews applied: `['6531

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/paths.hpp > > Lines 147-149 (patched) > > > > > > Let's find a more descriptive word for this, "temp" can mean anything. >

Review Request 65317: Used a namespace for paths in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65317/ --- Review request for mesos, Alexander Rukletsov and Kevin Klues. Repository: meso

Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65315/ --- Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone. Bugs

Re: Review Request 65310: Added lambda::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65310/#review196146 --- FAIL: Mesos stout-tests failed to build. Reviews applied: `['6531

Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/ --- Review request for mesos, Benjamin Hindman and Greg Mann. Bugs: MESOS-8434

Review Request 65312: Refactored authorization logic in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65312/ --- Review request for mesos, Benjamin Hindman and Greg Mann. Bugs: MESOS-8434

Review Request 65313: Refactored authorization logic in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65313/ --- Review request for mesos, Benjamin Hindman and Greg Mann. Bugs: MESOS-8434

Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/ --- Review request for mesos, Benjamin Hindman and Greg Mann. Bugs: MESOS-8434

Review Request 65310: Added lambda::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65310/ --- Review request for mesos, Benjamin Hindman and Greg Mann. Bugs: MESOS-8434

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review196142 --- FAIL: Failed to apply the dependent review: 63366. Failed command

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65305/#review196143 --- 3rdparty/libprocess/src/process.cpp Lines 506 (patched)

Re: Review Request 65290: Reverted usage of the -isystem flag for includes (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65290/#review196141 --- FAIL: Mesos tests failed to build. Reviews applied: `['65308', '6

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/#review196140 --- I would prefer a more general, systematic approach to this situati

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review196137 --- FAIL: Mesos tests failed to build. Reviews applied: `['65308', '6

Re: Review Request 65307: Cleaned up interface defintion in duration header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65307/#review196136 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 24, 2018, 4:

Re: Review Request 63366: Added jemalloc release tarball and build rules.

> On Nov. 10, 2017, 3:52 p.m., Alexander Rukletsov wrote: > > configure.ac > > Lines 213 (patched) > > > > > > Maybe "jemalloc-allocator"? Or "bundled-jemalloc"? I think 'jemalloc-allocator' sounds good, changed.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/ --- (Updated Jan. 24, 2018, 4:40 p.m.) Review request for mesos and Alexander Rukle

Review Request 65307: Cleaned up interface defintion in duration header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65307/ --- Review request for mesos. Repository: mesos Description --- Moved a func

Re: Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated Jan. 24, 2018, 4:37 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65305/#review196133 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 24, 2018, 12

Review Request 65290: Reverted usage of the -isystem flag for includes (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65290/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 65289: Reverted usage of the -isystem flag for includes (2/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65289/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/ --- (Updated Jan. 24, 2018, 4:18 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65308: Fix shadowed sign-compare and enum-compare warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65308/ --- (Updated Jan. 24, 2018, 4:17 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review196127 --- FAIL: Mesos tests failed to build. Reviews applied: `['65308', '6

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/ --- (Updated Jan. 24, 2018, 3:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/ --- (Updated Jan. 24, 2018, 2:57 p.m.) Review request for mesos, Benjamin Bannier a

Review Request 65308: WIP: Fix warnings in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65308/ --- Review request for mesos. Repository: mesos Description --- WIP: Fix war

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

> On Jan. 24, 2018, 2:24 p.m., Benno Evers wrote: > > Ship It! Modulo Ben Mahlers comments, of course. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review196115

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review196115 --- Ship it! Ship It! - Benno Evers On Jan. 18, 2018, 5:46 p.m.,

Re: Review Request 63365: Re-ordered some configuration options alphabetically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63365/ --- (Updated Jan. 24, 2018, 1:58 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65305/#review196106 --- Ship it! Ship It! - Alexander Rojas On Jan. 24, 2018, 1:54 a

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 24, 2018, 10:36 a.m.) Review request for mesos, Benjamin Bannier,