Re: Review Request 65541: WIP: Experimented with the MessageDifferencer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65541/#review196970 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65541: WIP: Experimented with the MessageDifferencer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65541/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-2487

Review Request 65540: WIP: Removed most equality operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65540/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-2487

Re: Review Request 65538: WIP: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review196966 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65538: WIP: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review196965 --- src/resource_provider/storage/disk_profile.proto Lines 39

Re: Review Request 65538: WIP: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/ --- (Updated Feb. 7, 2018, 1:12 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review196962 --- PASS: Mesos patch 65448 was successfully built and tested.

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

> On Feb. 1, 2018, 2:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/main.cpp > > Lines 40-50 (patched) > > > > > > Flying by. Why this logic is not in launch.cpp? Sounds to me it's > > unrelated to, for

Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65408/#review196956 --- Ship it! Couple of comment tweaks for you to do before

Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65409/#review196958 --- src/tests/slave_recovery_tests.cpp Line 3832 (original), 3832

Re: Review Request 65406: Added `TYPED_TEST_TEMP_DISABLED_ON_WINDOWS` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65406/#review196957 --- Ship it! Ship It! - Joseph Wu On Jan. 29, 2018, 12:39 p.m.,

Re: Review Request 65407: Windows: Enabled tests that were blocked by MESOS-7604.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65407/#review196953 --- Ship it! Ship It! - Joseph Wu On Feb. 1, 2018, 4:03 p.m.,

Re: Review Request 65407: Windows: Enabled tests that were blocked by MESOS-7604.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65407/#review196952 --- Ship it! Ship It! - Joseph Wu On Feb. 1, 2018, 4:03 p.m.,

Re: Review Request 65538: WIP: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review196951 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review196947 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 4:17 a.m.,

Re: Review Request 65405: Implemented `net::socket()` for Windows using `WSASocket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65405/#review196946 --- Ship it! Ship It! - Joseph Wu On Feb. 1, 2018, 3:30 p.m.,

Review Request 65538: WIP: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65061: Speeded up tests for resource provider config agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65061/#review196944 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 4:14 a.m.,

Re: Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65499/#review196943 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2018, 1:40 a.m.,

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/#review196941 --- src/tests/cluster.cpp Lines 685 (patched)

Re: Review Request 65472: Added `csi::paths::parseContainerPath` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65472/#review196940 --- Ship it! Ship It! - Jie Yu On Feb. 2, 2018, 5:23 a.m.,

Re: Review Request 65471: Made the SLRP tests more consistent in coding style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65471/#review196939 --- Ship it! Ship It! - Jie Yu On Feb. 2, 2018, 5:08 a.m.,

Re: Review Request 65032: Added a SLRP unit test for agent reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/#review196937 --- Ship it! Ship It! - Jie Yu On Feb. 2, 2018, 5:07 a.m.,

Re: Review Request 65467: Windows: Added `internal::windows::enable_inherit(WindowsFD)`.

> On Feb. 6, 2018, 1:55 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > > Lines 31-43 (patched) > > > > > > This is basically what the ChildHook `UNSET_CLOEXEC` > >

Re: Review Request 65467: Windows: Added `internal::windows::enable_inherit(WindowsFD)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review196932 --- 3rdparty/stout/include/stout/internal/windows/inherit.hpp Lines

Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196928 --- Patch looks great! Reviews applied: [65201, 65343, 65298, 65202]

Re: Review Request 65403: Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65403/#review196759 --- Ship it! - Joseph Wu On Feb. 1, 2018, 3:23 p.m., Andrew

Re: Review Request 65402: Windows: Use Unicode API to duplicate sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65402/#review196757 --- Ship it! 3rdparty/stout/include/stout/os/windows/dup.hpp Line

Re: Review Request 65401: Windows: Enabled `Flags::runtime_directory` for checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65401/#review196743 --- Ship it! - Joseph Wu On Feb. 1, 2018, 3:22 p.m., Andrew

Re: Review Request 65400: Windows: Tied task lifetimes to executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65400/#review196737 --- Ship it! - Joseph Wu On Jan. 29, 2018, 12:34 p.m., Andrew

Re: Review Request 65399: Windows: Moved "kill on close" job object flag to own function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65399/#review196733 --- Fix it, then Ship it! Style nits only.

Re: Review Request 65398: Removed workaround in ZooKeeper test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65398/#review196731 --- Ship it! - Joseph Wu On Jan. 29, 2018, 12:32 p.m., Andrew

Re: Review Request 65397: Windows: Fixed `fs::list` to return full paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65397/#review196730 --- Ship it! LGTM. - Joseph Wu On Jan. 29, 2018, 12:32 p.m.,

Re: Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65445/#review196924 --- Ship it! Ship It! - Vinod Kone On Feb. 5, 2018, 2:44 a.m.,

Re: Review Request 65520: Reverted plugin name randomization in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65520/#review196923 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 4:08 a.m.,

Re: Review Request 65534: Improved logging for container daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65534/#review196922 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 7:11 p.m.,

Re: Review Request 65521: Improved isolation for agent RP API config tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65521/#review196921 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 4:11 a.m.,

Re: Review Request 65523: Fixed the flakiness in the SLRP metrics test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65523/#review196920 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 7:12 p.m.,

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review196919 --- PASS: Mesos patch 65246 was successfully built and tested.

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

> On Feb. 6, 2018, 10:29 a.m., Gaston Kleiman wrote: > > src/slave/slave.cpp > > Line 9530 (original), 9529 (patched) > > > > > > I noticed that if a single task is passed, we surround its ID in single > > quotes,

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote: > > src/slave/slave.cpp > > Line 9530 (original), 9529 (patched) > > > > > > I noticed that if a single task is passed, we surround its ID in single > > quotes,

Re: Review Request 65510: Enable 'curl' uri_fetcher tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65510/#review196913 --- Ship it! Nit: Fix the summary and description. - Andrew

Re: Review Request 65509: The CURL_ prefix in unit test name should always succeed on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65509/#review196912 --- Fix it, then Ship it! We should also note in the description

Re: Review Request 65508: Allow curl program to be properly executed on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65508/#review196911 --- Ship it! Nit: Fix summary to be in past tense, and fix

Re: Review Request 65523: Fixed the flakiness in the SLRP metrics test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65523/ --- (Updated Feb. 6, 2018, 7:12 p.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 65508: Allow curl program to be properly executed on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65508/#review196910 --- src/uri/fetchers/curl.cpp Line 99 (original), 99-104 (patched)

Review Request 65534: Improved logging for container daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65534/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/ --- (Updated Feb. 6, 2018, 6:43 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review196908 --- PASS: Mesos patch 65497 was successfully built and tested.

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review196906 --- Fix it, then Ship it! I noticed a minor inconsistency in

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review196894 --- 3rdparty/libprocess/include/process/memory_profiler.hpp Lines 57

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated Feb. 6, 2018, 5:45 p.m.) Review request for mesos, Alexander

Re: Review Request 63366: Add jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated Feb. 6, 2018, 5:45 p.m.) Review request for mesos, Alexander

Re: Review Request 65109: Fixed a bug relating to lingering executors [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/ --- (Updated Feb. 6, 2018, 9:45 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65496: Fixed a bug relating to lingering executors [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65496/ --- (Updated Feb. 6, 2018, 9:42 a.m.) Review request for mesos and Benjamin

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

> On Feb. 3, 2018, 12:06 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/process.hpp > > Lines 325-352 (original), 325-352 (patched) > > > > > > These look obviated by your new one? Why do we

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/ --- (Updated Feb. 6, 2018, 5:40 p.m.) Review request for mesos, Alexander

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review196893 --- PASS: Mesos patch 65518 was successfully built and tested.

Re: Review Request 65462: Use the new 'route()' overload from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65462/ --- (Updated Feb. 6, 2018, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/ --- (Updated Feb. 6, 2018, 9:45 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 65529: Added --clean flag to bootstrap script for Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65529/#review196889 --- PASS: Mesos patch 65529 was successfully built and tested.

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6349-6352 (patched) > > > > > > Are these necessary? I think that framework registration may be > > sufficient to produce an

Review Request 65529: Added --clean flag to bootstrap script for Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65529/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8240

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196885 --- PASS: Mesos patch 65045 was successfully built and tested.

Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196878 --- Fix it, then Ship it! src/tests/flags.hpp Lines 49 (patched)

Re: Review Request 65343: Adopted `DEFAULT_TEST_TIMEOUT` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65343/#review196877 --- Fix it, then Ship it! 3rdparty/libprocess/src/tests/main.cpp

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/#review196876 --- Fix it, then Ship it! 3rdparty/libprocess/Makefile.am Lines

Re: Review Request 65298: Split test flags into header and source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65298/#review196884 --- Fix it, then Ship it! src/tests/flags.hpp Line 25 (original),

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 6, 2018, 11:11 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Feb. 6, 2018, 11:10 a.m.) Review request for mesos, Benjamin Bannier,