Re: Review Request 66114: Added supporting scripts for Mesos LLVM Tools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66114/#review199408 --- Ship it! We might want to merge this patch with https://reviews

Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66115/#review199409 --- I am not convinced that this tool will be much more useful than e.

Re: Review Request 66008: CMake: Enabled compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66008/#review199413 --- Fix it, then Ship it! Looking good, could not verify Windows-re

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review199414 --- src/tests/master_allocator_tests.cpp Line 175 (original), 177-178

Review Request 66137: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66137/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Re: Review Request 66137: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66137/#review199416 --- Ship it! Ship It! - Benno Evers On March 19, 2018, 3:16 p.m.

Review Request 66138: Add dockerfile for ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66138/ --- Review request for mesos, James Peach, Michael Park, and Vinod Kone. Repository

Re: Review Request 66138: Add dockerfile for ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66138/#review199417 --- Ship it! Ship It! - James Peach On March 19, 2018, 3:23 p.m.

Re: Review Request 66137: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66137/#review199419 --- PASS: Mesos patch 66137 was successfully built and tested. Review

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199422 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 1:55 p.m.,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199423 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 1:55 p.m.,

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/#review199424 --- Ship it! Ship It! src/master/metrics.cpp Line 484 (original),

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

> On March 19, 2018, 9:41 a.m., Zhitao Li wrote: > > src/master/metrics.cpp > > Line 484 (original), 498 (patched) > > > > > > I'm not sure how this pattern can sustain in the long run as long as we > > keep adding

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199426 --- src/master/master.cpp Lines 5934 (patched)

Re: Review Request 65994: Made the master forward operation status updates to the schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65994/#review199427 --- src/master/master.cpp Line 8148 (original), 8150 (patched)

Re: Review Request 66056: Updated `CREATE_VOLUME()` helper to allow specifying an operation ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66056/#review199428 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 12:57 p.m.,

Re: Review Request 66057: Added a `createCallAcknowledgeOperationStatus()` test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66057/#review199429 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 12:58 p.m.,

Re: Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66059/#review199432 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 12:58 p.m.,

Re: Review Request 66008: CMake: Enabled compiler warnings.

> On March 19, 2018, 6:35 a.m., Benjamin Bannier wrote: > > src/CMakeLists.txt > > Lines 484-486 (patched) > > > > > > Let's make this a `PRIVATE` option. We wouldn't necessarily want to > > push this on each and ev

Re: Review Request 66060: Added end-to-end tests for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/#review199431 --- src/tests/storage_local_resource_provider_tests.cpp Lines 3282 (p

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > > > > > whitespace line after multi-line log Do we have an official rule saying that there should be an empty

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66058/#review199430 --- src/tests/mesos.hpp Lines 2574 (patched)

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

> On March 19, 2018, 10:14 a.m., Zhitao Li wrote: > > src/tests/mesos.hpp > > Lines 2574 (patched) > > > > > > Do we need to make this `ACTION_P` and takes a (decline) `Filters`? I think we should add helpers as we

Re: Review Request 66060: Added end-to-end tests for operation feedback.

> On March 19, 2018, 10:12 a.m., Zhitao Li wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3282 (patched) > > > > > > Is there a reason this test requires `ROOT_` filter? A lot of people do

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > > > > > whitespace line after multi-line log > > Gaston Kleiman wrote: > Do we have an official rule sayin

Re: Review Request 66138: Add dockerfile for ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66138/#review199440 --- PASS: Mesos patch 66138 was successfully built and tested. Review

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5969 (patched) > > > > > > whitespace after block > > > > `const UUID& ...` This one is moved at the end of the function

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199445 --- I've taken a first pass, but before we get into the details of the

Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66142/ --- Review request for mesos, Greg Mann and Zhitao Li. Repository: mesos Descript

Review Request 66141: Fixed whitespace in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li. Repository

Re: Review Request 66060: Added end-to-end tests for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/ --- (Updated March 19, 2018, 11:09 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 65994: Made the master forward operation status updates to the schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65994/ --- (Updated March 19, 2018, 11:11 a.m.) Review request for mesos, Greg Mann and Zh

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > > > > > whitespace line after multi-line log > > Gaston Kleiman wrote: > Do we have an official rule sayin

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated March 19, 2018, 11:13 a.m.) Review request for mesos, Greg Mann and Zh

Re: Review Request 66002: Fixed the HTTP API path variables on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/ --- (Updated March 19, 2018, 6:20 p.m.) Review request for mesos, Akash Gupta, Andr

Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624 h

Review Request 66140: Fixed bug in `Framework::removeOperation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66140/ --- Review request for mesos, Greg Mann and Zhitao Li. Repository: mesos Descript

Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624 h

Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624 h

Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624 h

Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66147/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues. Bugs

Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66142/#review199453 --- PASS: Mesos patch 66142 was successfully built and tested. Review

Re: Review Request 66008: CMake: Enabled compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66008/ --- (Updated March 19, 2018, 12:08 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66009/ --- (Updated March 19, 2018, 12:09 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66010: Windows: Switched to default CRT linkage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66010/ --- (Updated March 19, 2018, 12:12 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/ --- (Updated March 19, 2018, 12:13 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66013/ --- (Updated March 19, 2018, 12:14 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/ --- (Updated March 19, 2018, 12:13 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66046/ --- (Updated March 19, 2018, 12:14 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66141: Fixed whitespace in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/#review199454 --- Ship it! Ship It! - Zhitao Li On March 19, 2018, 11:08 a.m.,

Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66142/#review199455 --- Ship it! Ship It! - Zhitao Li On March 19, 2018, 11:08 a.m.,

Re: Review Request 66008: CMake: Enabled compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66008/ --- (Updated March 19, 2018, 12:36 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65869/#review199457 --- PASS: Mesos patch 65869 was successfully built and tested. Review

Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66140/#review199458 --- PASS: Mesos patch 66140 was successfully built and tested. Review

Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66142/#review199459 --- Patch looks great! Reviews applied: [63992, 63994, 65300, 64618,

Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/#review199461 --- Ship it! Ship It! - Joseph Wu On March 19, 2018, 12:13 p.m.,

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199462 --- Ship it! Ship It! - Joseph Wu On March 19, 2018, 12:13 p.m.,

Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66013/#review199463 --- Ship it! Ship It! - Joseph Wu On March 19, 2018, 12:14 p.m.,

Re: Review Request 66014: Windows: Made SASL use default CRT linking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66014/#review199464 --- Ship it! Ship It! - Joseph Wu On March 9, 2018, 2:39 p.m., A

Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66046/#review199465 --- Ship it! Ship It! - Joseph Wu On March 19, 2018, 12:14 p.m.,

Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65833/#review199466 --- Ship it! Ship It! - Greg Mann On Feb. 28, 2018, 12:55 p.m.,

Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66140/#review199467 --- src/master/master.hpp Lines 2628 (patched)

Review Request 66150: WIP: Add -Werror semantics to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66150/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-8689

Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66147/#review199472 --- PASS: Mesos patch 66147 was successfully built and tested. Review

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/#review199473 --- PASS: Mesos patch 66145 was successfully built and tested. Review

Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66147/ --- (Updated March 19, 2018, 9:41 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 66002: Fixed the HTTP API path variables on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/#review199478 --- PASS: Mesos patch 66002 was successfully built and tested. Review

Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66147/#review199479 --- Ship it! Ship It! - Alexander Rukletsov On March 19, 2018, 9

Re: Review Request 66002: Fixed the HTTP API path variables on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/#review199483 --- Patch looks great! Reviews applied: [66002] Passed command: expo

Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/#review199484 --- Ship it! Ship It! - Greg Mann On Feb. 28, 2018, 12:55 p.m.,

Re: Review Request 66150: WIP: Add -Werror semantics to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66150/#review199489 --- PASS: Mesos patch 66150 was successfully built and tested. Review

Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66142/ --- (Updated March 19, 2018, 4:16 p.m.) Review request for mesos, Greg Mann and Zhi

Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8492 htt

Review Request 66157: Fixed header inclusions for `csi/spec.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66157/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos Desc

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66058/#review199492 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 2581 (patched)

Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8697 htt

Review Request 66159: Made tests `CSIClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66159/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8697 htt

Re: Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66059/#review199493 --- Ship it! - Greg Mann On March 16, 2018, 7:58 p.m., Gaston Kle

Review Request 66160: Renamed `disk_profile` files to `disk_profile_adatpor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66160/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu. Repository:

Review Request 66161: Renamed the internal namespace `profile` to `storage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66161/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu. R

Re: Review Request 66044: Refactored resources chopping logic in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66044/ --- (Updated March 19, 2018, 4:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66044: Refactored resources chopping logic in allocator.

> On March 16, 2018, 7:26 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1577-1590 (patched) > > > > > > This function seems rather specific to the usage in this code, which

Review Request 66162: Changed names in tests related to `DiskProfileAdaptor` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66162/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu. Repository:

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated March 19, 2018, 11:50 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 61118: libprocess: Building gRPC support with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/ --- (Updated March 19, 2018, 11:53 p.m.) Review request for mesos, Andrew Schwartzm

Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Jo

Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`.

> On March 19, 2018, 1:24 p.m., Zhitao Li wrote: > > src/master/master.hpp > > Lines 2628 (patched) > > > > > > A more higher level question: I wonder whether there is a more > > structured way to kee `Framework::o

Re: Review Request 53267: Added log and counter for tracking subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/ --- (Updated March 19, 2018, 5:06 p.m.) Review request for mesos, Anand Mazumdar, X

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

> On March 19, 2018, 2:14 p.m., Alexander Rukletsov wrote: > > Thanks Alex - as discussed today, coming up with an update via https://issues.apache.org/jira/browse/MESOS-8613. - Till --- This is an automatically generated e-mail. To re

Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66142/#review199499 --- PASS: Mesos patch 66142 was successfully built and tested. Review

Re: Review Request 66141: Fixed whitespace in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/#review199506 --- PASS: Mesos patch 66141 was successfully built and tested. Review

Re: Review Request 53267: Added log and counter for tracking subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/#review199507 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199508 --- FAIL: Failed to apply the dependent review: 66094. Failed command

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66058/ --- (Updated March 19, 2018, 6:54 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 65974: Added comments and made some renaming in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65974/ --- (Updated March 20, 2018, 2:05 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 66141: Fixed whitespace in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/#review199510 --- Patch looks great! Reviews applied: [63992, 63994, 65300, 64618,

Re: Review Request 66002: Fixed the HTTP API path variables on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/#review199511 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 19, 2018,

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated March 20, 2018, 3:13 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated March 20, 2018, 3:21 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/ --- (Updated March 20, 2018, 3:23 a.m.) Review request for mesos, Alexander Ruklets

  1   2   >