Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated May 11, 2018, 12:20 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/ --- (Updated May 11, 2018, 12:24 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated May 11, 2018, 12:25 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66822: Added per Framework Calls to metrics.

> On May 8, 2018, 1:33 p.m., Gaston Kleiman wrote: > > src/master/metrics.cpp > > Lines 595-623 (patched) > > > > > > We could replace these two methods with a single method that that takes > > a `const scheduler::C

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67078/#review202900 --- Patch looks great! Reviews applied: [67078] Passed command: expo

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated May 11, 2018, 12:39 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated May 11, 2018, 12:40 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66845: Made per-framework metrics count heartbeat events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66845/ --- (Updated May 11, 2018, 12:40 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66825: Added per framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66825/ --- (Updated May 11, 2018, 12:41 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66846: Added per framework metrics support for terminal task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/ --- (Updated May 11, 2018, 12:44 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66847: Added per framework metric for offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66847/ --- (Updated May 11, 2018, 12:46 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated May 11, 2018, 1:22 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated May 11, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated May 11, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66847: Added per framework metric for offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66847/ --- (Updated May 11, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66846: Added per framework metrics support for terminal task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/ --- (Updated May 11, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 67054: Added .tox to files excluded by Python linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67054/#review202925 --- This looks good, but I think we should also add the .virtualenv an

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67078/#review202928 --- src/resource_provider/storage/uri_disk_profile_adaptor.cpp Line 2

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 9, 2018, 3:15 p.m., Qian Zhang wrote: > > I checked the callers of `Containerizer::destroy()`, it seems no one > > actually cares about its return value (`Option`), so > > why do we need to return that? Can we just make it return `Future`? > > Qian Zhang wrote: > And then for the

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 9, 2018, 3:15 p.m., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Lines 658-661 (original) > > > > > > If we remove these codes, will the container be missed to delete and > > erased from

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/ --- (Updated May 11, 2018, 1:55 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review202941 --- Bad patch! Reviews applied: [9, 8] Failed command: pytho

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review202943 --- PASS: Mesos patch 66817 was successfully built and tested. Review

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review202944 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review202951 --- Patch looks great! Reviews applied: [8, 66670, 66671, 66817]

Re: Review Request 66650: Removed an invalid TODO in puller.cpp.

> On April 17, 2018, 6:33 p.m., Qian Zhang wrote: > > Mind to explain why this TODO is invalid in the description? :-) It means registry per container I believe. We already support registry prefix like quay.io/alpine:lastest - Gilbert

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67078/#review202959 --- Ship it! I am fine with this. Let's add a TODO about a potentia

Review Request 67094: Split linux chroot into prepare and enter phases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li. Bugs:

Review Request 67095: Added a containerizer devices path helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67095/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li. Bugs:

Review Request 67096: Added a `linux/devices` isolator skeleton.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67096/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li. Bugs:

Review Request 67097: Added `linux/devices` isolator whitelist support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li. Bugs:

Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li. Bugs:

Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.

> On May 10, 2018, 9:23 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Lines 488-502 (original), 493-512 (patched) > > > > > > I'm wondering if, instead of also adding a callback for this in >

Re: Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/#review202963 --- PASS: Mesos patch 67098 was successfully built and tested. Review

Re: Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/#review202964 --- Patch looks great! Reviews applied: [67094, 67095, 67096, 67097,

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

> On May 11, 2018, 12:05 p.m., James DeFelice wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Line 281 (original) > > > > > > this seems like a pretty aggressive change. instead of removing

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

> On May 11, 2018, 12:05 p.m., James DeFelice wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > > Line 281 (original) > > > > > > this seems like a pretty aggressive change. instead of removing

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67078/ --- (Updated May 11, 2018, 9:28 p.m.) Review request for mesos, James DeFelice, Jie

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am > > Lines 30 (patched) > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the optimiz

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202969 --- Great to see the split of `fs::enter::prepare` from `fs::enter::ch

Re: Review Request 67055: Added Python 3 version of cpplint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/ --- (Updated mai 11, 2018, 9:49 après-midi) Review request for mesos, Andrew Schwar

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- (Updated mai 11, 2018, 9:57 après-midi) Review request for mesos, Andrew Schwar

Re: Review Request 67059: Ported all support scripts to Python 3.

> On mai 10, 2018, 8:34 après-midi, Andrew Schwartzmeyer wrote: > > support/build-virtualenv > > Lines 49-51 (original), 49-51 (patched) > > > > > > I didn't know where else to comment to open this issue: > > > >

Review Request 67099: Updated support scripts to check for Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67099/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, an

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202971 --- Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp

Re: Review Request 67095: Added a containerizer devices path helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67095/#review202972 --- Ship it! Ship It! - Jie Yu On May 11, 2018, 6:32 p.m., James

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67078/#review202973 --- PASS: Mesos patch 67078 was successfully built and tested. Review

Re: Review Request 67096: Added a `linux/devices` isolator skeleton.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67096/#review202974 --- Ship it! Ship It! - Jie Yu On May 11, 2018, 6:32 p.m., James

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202976 --- src/linux/fs.cpp Lines 968-1034 (original), 973-1041 (patched)

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/#review202975 --- src/slave/containerizer/mesos/isolators/linux/devices.cpp Lines 7

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 11, 2018, 11:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 73 (patched) > > > > > > I'd suggest we just skip this whitelist entry, instead of fail the > > age

Re: Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/#review202977 --- high level comments: should we just create `/dev` in the linux dev

Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67078/#review202979 --- Patch looks great! Reviews applied: [67078] Passed command: expo

Re: Review Request 67099: Updated support scripts to check for Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67099/#review202980 --- PASS: Mesos patch 67099 was successfully built and tested. Review

Review Request 67104: Fixed a race condition in the allocator metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67104/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-8904

Re: Review Request 67101: Displayed modifications of all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67101/#review202982 --- PASS: Mesos patch 67101 was successfully built and tested. Review

Re: Review Request 67099: Updated support scripts to check for Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67099/#review202983 --- Patch looks great! Reviews applied: [67055, 67059, 67099] Passed

Re: Review Request 67104: Fixed a race condition in the allocator metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67104/#review202984 --- PASS: Mesos patch 67104 was successfully built and tested. Review